[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...
Github user conker84 commented on the issue: https://github.com/apache/zeppelin/pull/1582 Hi guys, I added the #2478 for the last part of the original PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...
Github user conker84 commented on the issue: https://github.com/apache/zeppelin/pull/1582 @jexp thanks for the hints i will integrate them and when i'll be ready i'll ask you another review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...
Github user jexp commented on the issue: https://github.com/apache/zeppelin/pull/1582 @conker84 @felixcheung I looked at the java-driver Neo4j bits and made some comments. In general it looks great and I really like the ideas. If you need anything else from me to make this PR happen, please let me know. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1582 Then, clicking `restart` button in the failed job would work. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...
Github user conker84 commented on the issue: https://github.com/apache/zeppelin/pull/1582 I can't understand if it is related to something made by me becouse i haven't touched the zeppelin-server --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1582
```
Zeppelin start [60G[[1;32m OK [0;39m]
< HTTP/1.1 200 OK
[31mException encountered when invoking run on a nested suite - The code
passed to eventually never returned normally. Attempted 832 times over
3.00255161803 minutes. Last failure message:
AbstractFunctionalSuite.this.find("welcome")(AbstractFunctionalSuite.this.webDriver).isDefined
was false. *** ABORTED ***[0m
[31m Exception encountered when invoking run on a nested suite - The code
passed to eventually never returned normally. Attempted 832 times over
3.00255161803 minutes. Last failure message:
AbstractFunctionalSuite.this.find("welcome")(AbstractFunctionalSuite.this.webDriver).isDefined
was false. (AbstractFunctionalSuite.scala:44)[0m
[36mRun completed in 3 minutes, 18 seconds.[0m
[36mTotal number of tests run: 0[0m
[36mSuites: completed 1, aborted 1[0m
[36mTests: succeeded 0, failed 0, canceled 0, ignored 0, pending 0[0m
[31m*** 1 SUITE ABORTED ***[0m
[ERROR] Failed to execute goal
org.scalatest:scalatest-maven-plugin:1.0:test (test) on project
zeppelin-server: There are test failures -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions,
please read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the
command
[ERROR] mvn -rf :zeppelin-server
```
I think this profile failed due to one of flaky tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...
Github user conker84 commented on the issue: https://github.com/apache/zeppelin/pull/1582 @felixcheung @Leemoonsoo i'm ready to make a new PR but my [travis](https://travis-ci.org/conker84/zeppelin) fails in one [job](https://s3.amazonaws.com/archive.travis-ci.org/jobs/208402587/log.txt) Can you help me to understand why? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1582 @jexp it would be great if you could review the neo4j parts in this PR. @conker84 would you be opening a new PR? please link to this one (type #1582) so I could help review and get this in soon --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...
Github user conker84 commented on the issue: https://github.com/apache/zeppelin/pull/1582 @jexp any help i appreciated! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...
Github user jexp commented on the issue: https://github.com/apache/zeppelin/pull/1582 @conker84 wow what a long story. Do you need any help from us (Neo4j) or @felixcheung @Leemoonsoo is there anything we can do? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1582 Right! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...
Github user conker84 commented on the issue: https://github.com/apache/zeppelin/pull/1582 Perfect just to clarify what i have to do: 1. Close this PR 2. Open a new PR (and the related jira issue) for (c) & (b) (i have to made a new fork?) I'm right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1582 Sorry for late response. Sounds like a plan! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1582 Let's go with (c) & (b) and then (a)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...
Github user conker84 commented on the issue: https://github.com/apache/zeppelin/pull/1582 Hi guys any news? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...
Github user conker84 commented on the issue: https://github.com/apache/zeppelin/pull/1582 If i can do anything to simplify the review process, for me there is no problem to split this PR into more activities; just one thing, for me the (c) and (b) are one piece becouse the (c) expose the API used by (b) to visualize the network. I can make the (a) after we close (c)&(b) becouse it uses the new [GraphResult class](https://github.com/conker84/zeppelin/blob/master/neo4j/src/main/java/org/apache/zeppelin/graph/neo4j/Neo4jCypherInterpreter.java#L270). Let me know how do you want proceed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1582 Some build fail looks like oriented from flaky test. Recently, a lot of flaky test has been fixed and i think it's better take advantage of those fix by merge master to this branch. By the way, i'm afraid to say this, but i suggest split this PR to small pieces if you don't mind. Because it adds/touches many places and review takes long time, and while reviewing, current code base changes/adds new things and this branch change code to resolve conflicts, that require more reviews and so on and so on. For example, beginning of this pullrequest didn't have such things like tabledata.js, but during the pullrequest, this branch had to change your code because of tabledata.js and new visualization code. And this branch changed tabledata.js to datasetfactory.js, which i'm about to review we can't change this because tabledata.js is now part of visualization api. By the way, neo4j interpreter is not related with all these stuff at all, but couldn't merged. I'm feeling like we're going to repeat the same thing again and again. So I'd suggest split this PR into 3 peaces. a) Neo4j Interpreter b) Visualization c) Adding display type I think a) and b) are modular, so i guess it's not going to be too complicated to split it into 3 PR. What do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...
Github user conker84 commented on the issue: https://github.com/apache/zeppelin/pull/1582 The [build](https://travis-ci.org/conker84/zeppelin) fails, can you help me to understand why? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1582 @conker84 We're changing Zeppelin CI system from ASF travis account to Individual contributor's travis account (see [ZEPPELIN-2123](https://issues.apache.org/jira/browse/ZEPPELIN-2123)). So you need to setup and [switch on travis-ci](https://travis-ci.org/profile) for your zeppelin fork. Once you have done, you'll need add a commit in zeppelin fork to trigger your travis-ci for the first time. Let me know if you have any questions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1582 @Leemoonsoo it looks like CI failed because of the Jenkins looks up script - can you tell @conker84 what needs to be done to fix it please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1582 Sorry about the delay. Will look at shortly - thanks for the ping. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...
Github user conker84 commented on the issue: https://github.com/apache/zeppelin/pull/1582 Hi guys any news on this? Thanks Andrea --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...
Github user conker84 commented on the issue: https://github.com/apache/zeppelin/pull/1582 hi @felixcheung , the PR is ready! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...
Github user conker84 commented on the issue: https://github.com/apache/zeppelin/pull/1582 The bug is in: `org.apache.zeppelin.helium.HeliumVisualizationFactory.installNodeAndNpm(HeliumVisualizationFactory.java:80)` and is not related to the PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...
Github user conker84 commented on the issue:
https://github.com/apache/zeppelin/pull/1582
@felixcheung after the last rebase i can't get Zeppelin running,
```bash
WARN [2017-01-20 15:24:13,141]
({org.apache.zeppelin.server.ZeppelinServer.main()}
ZeppelinConfiguration.java[create]:97) - Failed to load configuration,
proceeding with a default
INFO [2017-01-20 15:24:13,292]
({org.apache.zeppelin.server.ZeppelinServer.main()}
ZeppelinConfiguration.java[create]:109) - Server Host: 0.0.0.0
INFO [2017-01-20 15:24:13,293]
({org.apache.zeppelin.server.ZeppelinServer.main()}
ZeppelinConfiguration.java[create]:111) - Server Port: 8080
INFO [2017-01-20 15:24:13,293]
({org.apache.zeppelin.server.ZeppelinServer.main()}
ZeppelinConfiguration.java[create]:115) - Context Path: /
INFO [2017-01-20 15:24:13,360]
({org.apache.zeppelin.server.ZeppelinServer.main()}
ZeppelinConfiguration.java[create]:116) - Zeppelin Version: 0.8.0-SNAPSHOT
INFO [2017-01-20 15:24:14,036]
({org.apache.zeppelin.server.ZeppelinServer.main()} Log.java[initialized]:186)
- Logging initialized @191590ms
INFO [2017-01-20 15:24:16,736]
({org.apache.zeppelin.server.ZeppelinServer.main()}
ZeppelinServer.java[main]:176) - Starting zeppelin server
INFO [2017-01-20 15:24:16,742]
({org.apache.zeppelin.server.ZeppelinServer.main()} Server.java[doStart]:327) -
jetty-9.2.15.v20160210
INFO [2017-01-20 15:24:17,460]
({org.apache.zeppelin.server.ZeppelinServer.main()}
StandardDescriptorProcessor.java[visitServlet]:297) - NO JSP Support for /, did
not find org.eclipse.jetty.jsp.JettyJspServlet
java.lang.reflect.InvocationTargetException
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
Method)
at
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:422)
at
org.apache.cxf.jaxrs.servlet.CXFNonSpringJaxrsServlet.createSingletonInstance(CXFNonSpringJaxrsServlet.java:382)
at
org.apache.cxf.jaxrs.servlet.CXFNonSpringJaxrsServlet.createApplicationInstance(CXFNonSpringJaxrsServlet.java:454)
at
org.apache.cxf.jaxrs.servlet.CXFNonSpringJaxrsServlet.createServerFromApplication(CXFNonSpringJaxrsServlet.java:432)
at
org.apache.cxf.jaxrs.servlet.CXFNonSpringJaxrsServlet.init(CXFNonSpringJaxrsServlet.java:93)
at
org.eclipse.jetty.servlet.ServletHolder.initServlet(ServletHolder.java:616)
at
org.eclipse.jetty.servlet.ServletHolder.initialize(ServletHolder.java:396)
at
org.eclipse.jetty.servlet.ServletHandler.initialize(ServletHandler.java:871)
at
org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:298)
at
org.eclipse.jetty.webapp.WebAppContext.startWebapp(WebAppContext.java:1349)
at
org.eclipse.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1342)
at
org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:741)
at
org.eclipse.jetty.webapp.WebAppContext.doStart(WebAppContext.java:505)
at
org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
at
org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:132)
at
org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:114)
at
org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:61)
at
org.eclipse.jetty.server.handler.ContextHandlerCollection.doStart(ContextHandlerCollection.java:163)
at
org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
at
org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:132)
at org.eclipse.jetty.server.Server.start(Server.java:387)
at
org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:114)
at
org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:61)
at org.eclipse.jetty.server.Server.doStart(Server.java:354)
at
org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
at
org.apache.zeppelin.server.ZeppelinServer.main(ZeppelinServer.java:178)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at
[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...
Github user conker84 commented on the issue: https://github.com/apache/zeppelin/pull/1582 @felixcheung SourceTree works very well, thanks for the advice! Now focusing to the PR, there still are conflicts, so i'll rebase the code again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1582 I think if you are doing a rebase it might be easier to use a tool. Have you tried SourceTree or GitHub Desktop tool? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...
Github user conker84 commented on the issue: https://github.com/apache/zeppelin/pull/1582 I can't get the rebase done good this time. Can you suggest some resource on the web to better understand how to rebase the code on Eclipse? I google around but i haven't fine anything valuable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1582 What's the issue and how can I help? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...
Github user conker84 commented on the issue: https://github.com/apache/zeppelin/pull/1582 @felixcheung i'm having some issue when i made the rebase. Can you help me? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...
Github user conker84 commented on the issue: https://github.com/apache/zeppelin/pull/1582 Sure, i'm working on it! Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1582 I reviewed these changes again and didn't see why they would cause that error. Could you rebase this PR and check our my comment (which should simplify the diff). These changes would be very good to have in the coming release; let's try this again - if test fails again you could close and reopen this PR to trigger CI runs manually. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...
Github user conker84 commented on the issue: https://github.com/apache/zeppelin/pull/1582 My devloping evironment is Windows (10) if it can help --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1582 hmm, I'm not sure ``` 17:29:54,140 INFO org.apache.zeppelin.interpreter.InterpreterOutputChangeWatcher:71 - watch /tmp/ZeppelinLTest_1480267793139 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.151 sec <<< FAILURE! - in org.apache.zeppelin.interpreter.InterpreterOutputChangeWatcherTest test(org.apache.zeppelin.interpreter.InterpreterOutputChangeWatcherTest) Time elapsed: 2.141 sec <<< ERROR! java.io.IOException: User limit of inotify watches reached at sun.nio.fs.LinuxWatchService$Poller.implRegister(LinuxWatchService.java:261) at sun.nio.fs.AbstractPoller.processRequests(AbstractPoller.java:260) at sun.nio.fs.LinuxWatchService$Poller.run(LinuxWatchService.java:326) at java.lang.Thread.run(Thread.java:745) ``` Doesn't seem like we are seeing this error recently, @bzz do you know? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...
Github user conker84 commented on the issue: https://github.com/apache/zeppelin/pull/1582 @felixcheung the CI still fails. The `org.apache.zeppelin.interpreter.InterpreterOutputChangeWatcherTest` fails but in my enviroment it passes the test. Where am i wrong? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1582 could you rebase this PR and see if CI passes? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...
Github user conker84 commented on the issue: https://github.com/apache/zeppelin/pull/1582 Hi @Leemoonsoo i have just published the code refactored as from #1529 I will look forward to your feedback! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1582 Front-end visualization code has been refactored from https://github.com/apache/zeppelin/pull/1529. I think that's the biggest conflicts that this branch have right now. Could you merge master branch to this branch and resolve conflict? Basically you'll need to move network visualization into `zeppelin-web/src/app/visualization/builtins` like other built-in visualizations. Let me know if you need any help on it. I'd like to help. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
