[GitHub] zeppelin issue #1716: [ ZEPPELIN-531 ] execute and stop note in job menu
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1716 Tested and LGTM. Merge to master if there're no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1716: [ ZEPPELIN-531 ] execute and stop note in job menu
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1716 Hello @bzz , could you please review? ci is green. I think ready for merge on this pr. Thank you :) Have a nice day. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1716: [ ZEPPELIN-531 ] execute and stop note in job menu
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1716 @bzz Sure! I will That. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1716: [ ZEPPELIN-531 ] execute and stop note in job menu
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1716 @cloverhearts can you please rebase it on latest master - `git rebase master` and force push it? This will trigger CI with latest fixes and help to see if there are any relevant failures here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1716: [ ZEPPELIN-531 ] execute and stop note in job menu
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1716 @cloverhearts thank you for contribution! In my experience, if PR author or one of reviewers post the reason for CI failure - that speeds up the review\merge process dramatically. CI is failing with flaky pySpark tests, not relevant to the PR ``` Results : Failed tests: ZeppelinSparkClusterTest.pySparkDepLoaderTest:430 expected: but was: ZeppelinSparkClusterTest.pySparkAutoConvertOptionTest:312 expected: but was: Tests run: 82, Failures: 2, Errors: 0, Skipped: 1 ``` It will be handled under [ZEPPELIN-1761](https://issues.apache.org/jira/browse/ZEPPELIN-1761). \cc @felizbear to review the frontend part. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1716: [ ZEPPELIN-531 ] execute and stop note in job menu
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1716 @astroshim Thank you, have a good day! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1716: [ ZEPPELIN-531 ] execute and stop note in job menu
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1716 It's working as expected. Thank you for great improvement. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
