[GitHub] zeppelin issue #1879: [HOTFIX : ZEPPELIN-1932] paragraph blur error

2017-01-12 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1879
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1879: [HOTFIX : ZEPPELIN-1932] paragraph blur error

2017-01-11 Thread minahlee
Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/1879
  
@cloverhearts Can you also look into 
https://github.com/apache/zeppelin/blob/master/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js#L764
 this line?

I see another error related to editor.
![screen shot 2017-01-12 at 3 49 44 
pm](https://cloud.githubusercontent.com/assets/8503346/21879897/01df6686-d8df-11e6-9300-c6dc8dc9c8fa.png)

How to reproduce
1. go to `Basic Features (Spark)` tutorial notebook
2. run first markdown paragraph



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1879: [HOTFIX : ZEPPELIN-1932] paragraph blur error

2017-01-11 Thread minahlee
Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/1879
  
Merge if there is no more discussion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1879: [HOTFIX : ZEPPELIN-1932] paragraph blur error

2017-01-11 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/1879
  
Tested and it works well :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1879: [HOTFIX : ZEPPELIN-1932] paragraph blur error

2017-01-11 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/1879
  
@cloverhearts Thank you :+1: 
Let me test it out and I'll comment this. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1879: [HOTFIX : ZEPPELIN-1932] paragraph blur error

2017-01-10 Thread cloverhearts
Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/1879
  
@soralee 
Sure :)

rebase is done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1879: [HOTFIX : ZEPPELIN-1932] paragraph blur error

2017-01-10 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/1879
  
@cloverhearts I'd like to test this. could you resolve some conflict file?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1879: [HOTFIX : ZEPPELIN-1932] paragraph blur error

2017-01-09 Thread minahlee
Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/1879
  
Tested, LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---