Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2239
Merging into master if no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2239
reopen for CI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2239
hey sorry, so in your screen shot here
https://github.com/apache/zeppelin/pull/2239#issuecomment-297239470
if cancel when owner is empty it resets also writer/reader, is that a bit
odd?
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2239
Ready to review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2239
Ping!
@felixcheung @khalidhuseynov @1ambda, could you guys confirm again, please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2239
Hi, there.
CI became green now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2239
Ping!
And this CI fail is irrelevant this PR.
```
Tests in error:
SecurityRestApiTest.testGetUserList:69 » JsonSyntax
java.lang.IllegalStateExce...
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2239
@felixcheung I updated as your advice!
@khalidhuseynov I added a logic which is reverted with old value if user
cancel button like above `4 step`. How about this?
> 4. then, the
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2239
@khalidhuseynov Thanks for opinion! Yeah, I see. This PR is for showing a
dialog when (already existing backend logic) that note's permission set
Readers/Writers but Owners is empty. I think I
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2239
@soralee it's disappearance is based on multi-user logic and it's correct
since if note have `owners`, `readers`, `writers` as `user1` it doesn't have
anything to do in `admin`'s list.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2239
@khalidhuseynov thanks for checking it really!
You're right! I think so too! this should be considered.
Furthermore, I checked above steps which I addressed, I saw that zeppelin
run
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/2239
@soralee yeah the steps are correct. so if you follow those steps and click
`Save`, say for `Note A`, then `Note A` will disappear from the list of your
notes, and then you will not have
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2239
@khalidhuseynov Thanks for comments!
You mean, this can be occurred another problem like the following steps.
1. A user who has admin permissions sets `readers` and `writers` and empty
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2239
@felixcheung Thanks for review and useful comments!
I initially think something wrong. Let me modify this part again!
Thanks a lots!
---
If your project is set up for it, you can reply
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2239
I modified dialog title and `OK` button.
I've checked the `whitespace` and the `$scope.permissions.owners` array
don't insert `whitespace` originally. But for stability, I added `if
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2239
@1ambda Thanks for information always :+1:
I already worked to rebase and run build successfully, but now, I'm
checking the `white space` problem.
Let me updated ASAP!
---
If your
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2239
@soralee Since conflicts are about lint errors, you can simply rebase by
1. keeping your change and run `rebase --continue`
2. then, execute `eslint src --fix` in `zeppelin-web` dir.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2239
@felixcheung Thanks for detail suggestion! That's sounds good. Let me
update as each comment.
@1ambda Sure, I agree! I'll remove `!!!`
---
If your project is set up for it, you can reply to
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2239
Hi, @felixcheung :slightly_smiling_face:
I added JIRA url about this improvement in this PR description and I
reverted some code in `notebook Rest API` side except that, if only setting
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2239
@felixcheung Thanks for review!
Yeah, you're right. It would be better if we also check on the REST API
side stably.
So, let me create a JIRA ticket and revert code in `REST API`.
---
20 matches
Mail list logo
