[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

[bern80]

Github user bern80 commented on the issue:

https://github.com/apache/zeppelin/pull/2439
  
Dear All,
Is this 
_zeppelin-web/src/app/notebook/paragraph/result/result.controller.js_ script 
already fixed on master branch?

Thanks,
R.


---

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

[weand]

Github user weand commented on the issue:

https://github.com/apache/zeppelin/pull/2439
  
@herval: I merged latest master: 
[https://github.com/weand/zeppelin/tree/ZEPPELIN-2680](https://github.com/weand/zeppelin/tree/ZEPPELIN-2680)

But I also face continuous requests against helium endpoint (without having 
any helium configured at all). Same behavior like @khalidhuseynov. I recognized 
this only by having a look at the Network Communication in the browsers 
developer tools.

I'm not into the angular stuff so much. Could you have a look?


---

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

[weand]

Github user weand commented on the issue:

https://github.com/apache/zeppelin/pull/2439
  
@herval would you mind merging again on latest master?

@soralee @zjffdu as we face the same issue, and we are using helium, I will 
also test it.


---

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

[herval]

Github user herval commented on the issue:

https://github.com/apache/zeppelin/pull/2439
  
Hi folks,

Please let me know if I should close this. Tks!


---

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

[herval]

Github user herval commented on the issue:

https://github.com/apache/zeppelin/pull/2439
  
@soralee @khalidhuseynov would you or anyone else like to give this a new 
try?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

[herval]

Github user herval commented on the issue:

https://github.com/apache/zeppelin/pull/2439
  
hmm I'll see if I can somehow split "report mode" and "view only mode".

I didnt experience the Helium issue, personally


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

[khalidhuseynov]

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2439
  
thanks for the improvement, this scenario needs to be fixed indeed. after 
trying the pr, i noticed couple of things
 * when following scenario and going into note as user2, my browser got 
stuck with the continuous requests to the helium endpoint, anyone experienced 
it?
 * the note opens in report mode, although it say in the top-right corner 
`default` mode. that seems a bit inconsistent
  



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

[herval]

Github user herval commented on the issue:

https://github.com/apache/zeppelin/pull/2439
  
all tests passing now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

[soralee]

Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2439
  
Tested and LGTM! 
It looks cool that when a `writers` logins a note, it shows report mode.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

[soralee]

Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2439
  
I just checked again, but there is still a same problem. could you check 
this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

[soralee]

Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2439
  
Yes, I did. I run `mvn clean package -DskipTests`
I'll check again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

[herval]

Github user herval commented on the issue:

https://github.com/apache/zeppelin/pull/2439
  
Hmm I’ll try again.

Btw, did you `mvn clean` after switching branches? I think changes on the 
js/html files don’t get picked up unless you do that...


From: Sora Lee 
Sent: Tuesday, July 4, 2017 1:23:03 AM
To: apache/zeppelin
Cc: Herval Freire; Mention
Subject: Re: [apache/zeppelin] [ZEPPELIN-2680] allow opening notebook as a 
reader (#2439)


I could reproduce this problem on master branch but, I could not see to 
resolve on your branch.
It has same error.
Could you test it out on your branch?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on 
GitHub, or 
mute the 
thread.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

[soralee]

Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2439
  
I could reproduce this problem on master branch but, I could not see to 
resolve on your branch.
It has same error.
Could you test it out on your branch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

[soralee]

Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2439
  
Oh, Thanks for quick answer and check! 
Let me test as your comment and come back here!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

[herval]

Github user herval commented on the issue:

https://github.com/apache/zeppelin/pull/2439
  
@soralee thanks for taking the time :-) there's one more step to your list:

1. login as user1
2. create a note
3. add a paragraph
**4. change the visualization to a chart (instead of table)**
5. set owners and writers field set user1
6. set readers field sets user2
7. logout user1 and login user2.
8. back to note and check whether popup is appeared or not.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

[soralee]

Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2439
  
I have a question quickly.
For reproduce, I just make sure test flow clearly. 
1. login as user1
2. create a note
3. add a paragraph
4. set `owners` and `writers` field set user1
5. set `readers` field sets user2
6. logout user1 and login user2.
7. back to note and check whether popup is appeared or not.

Is it correct?






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

[soralee]

Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2439
  
Hi, @herval. Thanks for contribution and sorry for late response.
Let me take a look this one.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

[herval]

Github user herval commented on the issue:

https://github.com/apache/zeppelin/pull/2439
  
any thoughts on this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

[herval]

Github user herval commented on the issue:

https://github.com/apache/zeppelin/pull/2439
  
Build is green: https://travis-ci.org/herval/zeppelin/builds/247345573


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---