[GitHub] zeppelin issue #2552: WIP: [ZEPPELIN-2881] Fix OIDC logout
Github user tiboun commented on the issue: https://github.com/apache/zeppelin/pull/2552 Hi, I've made an integration of the oidc logout and have included a new profile (oidc) in order to build zeppelin with oidc related libs. I've started my work on branch-0.8 because master doesn't build with scala 2.11 at the moment. Would you like me to push my PR in this issue or do I have to create a new issue and ask if I can add a new profile for oidc ? I think it would be better to create a new one. ---
[GitHub] zeppelin issue #2552: WIP: [ZEPPELIN-2881] Fix OIDC logout
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2552 waiting is over but `pac4j` introduced a few regressions that needs to be fixed to have the documented process working... I'm looking into, slowly, but if you wanna take over feel free to go ahead and contact me privately if you need any help. @saba0815 ---
[GitHub] zeppelin issue #2552: WIP: [ZEPPELIN-2881] Fix OIDC logout
Github user saba0815 commented on the issue: https://github.com/apache/zeppelin/pull/2552 Is waiting now over? ---
[GitHub] zeppelin issue #2552: WIP: [ZEPPELIN-2881] Fix OIDC logout
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2552 Hmm sounds like we need to wait. ---
[GitHub] zeppelin issue #2552: WIP: [ZEPPELIN-2881] Fix OIDC logout
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2552 Hi thanks for getting back into this, unfortunately even if https://github.com/pac4j/pac4j/pull/975 got merged we do not have yet a release of pac4j out in public repositories that will enable this fix. if you agree I wait to have first a release of pac4j and then I will update this PR accordingly. WDYT? ---
[GitHub] zeppelin issue #2552: WIP: [ZEPPELIN-2881] Fix OIDC logout
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2552 hi - sorry about the delay, it looks like Jenkins can't locate the test results - could you close/reopen this PR to kick off another test run? ---
[GitHub] zeppelin issue #2552: WIP: [ZEPPELIN-2881] Fix OIDC logout
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2552 also please update the title to remove WIP if you are ready ---
[GitHub] zeppelin issue #2552: WIP: [ZEPPELIN-2881] Fix OIDC logout
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2552 sorry @felixcheung misunderstood your comment, should be fixed now! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2552: WIP: [ZEPPELIN-2881] Fix OIDC logout
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2552 yes, the original code I think is the result of a few iterations. This is the blocking pop-up: https://github.com/apache/zeppelin/blob/6bd6c70881e8515a5b0679e5a8d6c235cfb1adf6/zeppelin-web/src/components/navbar/navbar.controller.js#L104 But you can also notice that a double `post` is performed without meaningful comments to justify why... I think that someone like @1ambda or @Leemoonsoo maybe can clarify and add it's opinion to decide if keep the pop-up or not (personally I do not care ...) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2552: WIP: [ZEPPELIN-2881] Fix OIDC logout
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2552 I don't see the alert in the original code? Could you point me to it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
