[GitHub] zeppelin issue #2624: [ZEPPELIN-2965] Add code completion for livy interpret...
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2624 This commit seems broke Tab to indent text behavior. https://issues.apache.org/jira/browse/ZEPPELIN-3253 ---
[GitHub] zeppelin issue #2624: [ZEPPELIN-2965] Add code completion for livy interpret...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2624 @pellmont CI is failed, could you rebase and rerun it ? ---
[GitHub] zeppelin issue #2624: [ZEPPELIN-2965] Add code completion for livy interpret...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2624 ping @pellmont I also left some comments, in case you miss it. ---
[GitHub] zeppelin issue #2624: [ZEPPELIN-2965] Add code completion for livy interpret...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2624 @pellmont Could you update interpreter-setting.json to make tab as the completion key ? Because livy should be consistent with the built-in spark interpreter. ---
[GitHub] zeppelin issue #2624: [ZEPPELIN-2965] Add code completion for livy interpret...
Github user pellmont commented on the issue: https://github.com/apache/zeppelin/pull/2624 Of course I did :-) But: - Code-Completion is by ctrl-. (as before ZEPPELIN-277). If it should be tab it has to be configured probably in livy/interpreter-settings.json - You need a fresh 0.5.0-SNAPSHOT version of livy (since 0.5.0 with LIVY-7 is not yet released). But code completion in LivyInterpreter won't produce any errors if the feature is not available in livy... ---
[GitHub] zeppelin issue #2624: [ZEPPELIN-2965] Add code completion for livy interpret...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2624 @pellmont have you verified in from end to end ? It seems doesn't work for me when I type tab in frontend. I think it may need frontend change as well. ---
[GitHub] zeppelin issue #2624: [ZEPPELIN-2965] Add code completion for livy interpret...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2624 IMHOï¼it is better to have integration test for interpreter. Because interpreter is usually 3rd party library outside zeppelin. Unit test usually has many assumption which may not be true in real scenario. While integration test can simulate the real scenario. ---
[GitHub] zeppelin issue #2624: [ZEPPELIN-2965] Add code completion for livy interpret...
Github user pellmont commented on the issue: https://github.com/apache/zeppelin/pull/2624 welcome @zjffdu. Actually I am not a big fan of integration tests, because they are usually slow and brittle. In my opinion integration tests should be used sparely, the main functionality should be tested by unit tests. Also the way I put it now separates the code for making the HTTP call of the actual features of the livy API. But if you prefer, I can put everything into BaseLivyInterpreter... ---
[GitHub] zeppelin issue #2624: [ZEPPELIN-2965] Add code completion for livy interpret...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2624 Thanks for the contribution @pellmont , but I don't think it make sense to make so large change just for unit test. Actually livy interpreter can run integration which is much better than unit test to guarantee the function of livy interpreter. ---
