Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2646
Ok to me.
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2646
Awesome, merge if no more comments
---
Github user conker84 commented on the issue:
https://github.com/apache/zeppelin/pull/2646
@zjffdu travis is green now
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2646
@conker84 Could you rebase and rerun ?
---
Github user conker84 commented on the issue:
https://github.com/apache/zeppelin/pull/2646
CI is failling, the cause seems this:
```
Failed tests:
IPySparkInterpreterTest.testBasics:96 expected: but was:
```
Do you think is related to the PR?
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2646
LGTM, wait for travis pass
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2646
@conker84 you can update this PR by removing this plugin. That should also
work for you.
---
Github user conker84 commented on the issue:
https://github.com/apache/zeppelin/pull/2646
@zjffdu so I have to close this PR, right?
---
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2646
Oops, it is caused by last PR. Actually we can just remove this plugin from
zeppelin-interpreter module. Now all the interpreter depends on
interpreter-parent module.
---
Github user conker84 commented on the issue:
https://github.com/apache/zeppelin/pull/2646
@zjffdu the cause is totaly because of the `:` in the `project.name`, but
it almost in every pom (Zeppelin: Elasticsearch interpreter, Zeppelin: Apache
Cassandra interpreter, ecc...) so i think
10 matches
Mail list logo
