[GitHub] zeppelin issue #2671: [ZEPPELIN-3045] Add the option which prevents the cron...

2018-03-29 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2671 @msk84 This is what I propsed in [ZEPPELIN-3350](https://issues.apache.org/jira/browse/ZEPPELIN-3350) ---

[GitHub] zeppelin issue #2671: [ZEPPELIN-3045] Add the option which prevents the cron...

2018-03-29 Thread msk84
Github user msk84 commented on the issue: https://github.com/apache/zeppelin/pull/2671 For me having the solution with the restriction to set only myself as a cron user would be perfect. ---

[GitHub] zeppelin issue #2671: [ZEPPELIN-3045] Add the option which prevents the cron...

2018-03-13 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2671 Ping @kjmrknsn, are you still working on this? ---

[GitHub] zeppelin issue #2671: [ZEPPELIN-3045] Add the option which prevents the cron...

2017-11-18 Thread kjmrknsn
Github user kjmrknsn commented on the issue: https://github.com/apache/zeppelin/pull/2671 @felixcheung @zjffdu > we still want a check in the backend right, since this is a security/authentication issue. OK, thanks. So, I won't rewrite this PR to modify frontend. I'

[GitHub] zeppelin issue #2671: [ZEPPELIN-3045] Add the option which prevents the cron...

2017-11-18 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2671 we still want a check in the backend right, since this is a security/authentication issue. ---

[GitHub] zeppelin issue #2671: [ZEPPELIN-3045] Add the option which prevents the cron...

2017-11-17 Thread kjmrknsn
Github user kjmrknsn commented on the issue: https://github.com/apache/zeppelin/pull/2671 @felixcheung @zjffdu Thanks for your reviewing. I'll rewrite this PR to modify frontend instead of backend as @zjffdu said at the beginning of next week. ---

[GitHub] zeppelin issue #2671: [ZEPPELIN-3045] Add the option which prevents the cron...

2017-11-17 Thread kjmrknsn
Github user kjmrknsn commented on the issue: https://github.com/apache/zeppelin/pull/2671 > Would it be much easier that we can just do not allow user to set cron executing user in frontend when this zeppelin.notebook.cronExecutingUser.loginUserOnly is true ? So that there would be l

[GitHub] zeppelin issue #2671: [ZEPPELIN-3045] Add the option which prevents the cron...

2017-11-16 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2671 Would it be much easier that we can just do not allow user to set cron executing user in frontend when this `zeppelin.notebook.cronExecutingUser.loginUserOnly` is true ? So that there would be le

[GitHub] zeppelin issue #2671: [ZEPPELIN-3045] Add the option which prevents the cron...

2017-11-16 Thread kjmrknsn
Github user kjmrknsn commented on the issue: https://github.com/apache/zeppelin/pull/2671 The default value of `zeppelin.notebook.cronExecutingUser.loginUserOnly` was changed to `true`. The Commits are squashed. ---

[GitHub] zeppelin issue #2671: [ZEPPELIN-3045] Add the option which prevents the cron...

2017-11-16 Thread kjmrknsn
Github user kjmrknsn commented on the issue: https://github.com/apache/zeppelin/pull/2671 @Leemoonsoo Thanks for your comment and suggestion. > One question, how about make zeppelin.notebook.cronExecutingUser.loginUserOnly default value true? Does it make sense to you? or do

[GitHub] zeppelin issue #2671: [ZEPPELIN-3045] Add the option which prevents the cron...

2017-11-16 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2671 Thanks @kjmrknsn for the great contribution. One question, how about make `zeppelin.notebook.cronExecutingUser.loginUserOnly` default value `true`? Does it make sense to you? or do yo

[GitHub] zeppelin issue #2671: [ZEPPELIN-3045] Add the option which prevents the cron...

2017-11-15 Thread kjmrknsn
Github user kjmrknsn commented on the issue: https://github.com/apache/zeppelin/pull/2671 The build result on Travis CI turned to green by rebuilding: https://travis-ci.org/kjmrknsn/zeppelin/builds/302473619 ---