Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2683
Sure yes, just missed it, have updated it.
---
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2683
need to add in https://github.com/apache/zeppelin/blob/master/LICENSE
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2683
Sure, thanks a lot let me add that.
---
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2683
@prabhjyotsingh
https://github.com/sroze/ngInfiniteScroll/blob/master/LICENSE
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2683
CI green; will merge this if no more discussion.
---
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2683
yep, all works now
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2683
@tinkoff-dwh Look's like `expand-collapse.directive.js:44` ->
"event.stopPropagation()" was prevening it to close, have fixed it.
---
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2683
Tested. LGTM
found bug for navbar dropdown (bug into branch master).
1) Open navbar list of notes
2) click to some folder
3) click to note in folder
4) Note loaded
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2683
Sure, I was experimenting with few more infinity scroll, let me try those
for performance, then will fix this.
---
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2683
i think looks good
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2683
Sure, in my todo list. Will find this, if this implementation/UX looks OK
---
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2683
works fine! But have some problems with sorting.
sorting on ui
1) folders (alphabet)
2) note (alphabet)
load home page, we have part of tree with "local sorting" (one
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2683
@tinkoff-dwh Thank you for the link. This seems to perform well.
Preview GIF
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2683
Yes, thanks I'm trying to explore infinity scroll.
---
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2683
@prabhjyotsingh
maybe more pretty http://sroze.github.io/ngInfiniteScroll/ . or a another
implementation of infinite scrolling
---
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2683
@tinkoff-dwh Sure let me work on that as well.
---
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2683
navbar have the same tree
---
17 matches
Mail list logo
