[GitHub] zeppelin issue #2683: ZEPPELIN-3072: Zeppelin UI becomes slow/unresponsive i...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2683
  
Sure yes, just missed it, have updated it.


---

[GitHub] zeppelin issue #2683: ZEPPELIN-3072: Zeppelin UI becomes slow/unresponsive i...

[tinkoff-dwh]

Github user tinkoff-dwh commented on the issue:

https://github.com/apache/zeppelin/pull/2683
  
need to add in https://github.com/apache/zeppelin/blob/master/LICENSE


---

[GitHub] zeppelin issue #2683: ZEPPELIN-3072: Zeppelin UI becomes slow/unresponsive i...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2683
  
Sure, thanks a lot let me add that.


---

[GitHub] zeppelin issue #2683: ZEPPELIN-3072: Zeppelin UI becomes slow/unresponsive i...

[tinkoff-dwh]

Github user tinkoff-dwh commented on the issue:

https://github.com/apache/zeppelin/pull/2683
  
@prabhjyotsingh 
https://github.com/sroze/ngInfiniteScroll/blob/master/LICENSE


---

[GitHub] zeppelin issue #2683: ZEPPELIN-3072: Zeppelin UI becomes slow/unresponsive i...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2683
  
CI green; will merge this if no more discussion.


---

[GitHub] zeppelin issue #2683: ZEPPELIN-3072: Zeppelin UI becomes slow/unresponsive i...

[tinkoff-dwh]

Github user tinkoff-dwh commented on the issue:

https://github.com/apache/zeppelin/pull/2683
  
yep, all works now


---

[GitHub] zeppelin issue #2683: ZEPPELIN-3072: Zeppelin UI becomes slow/unresponsive i...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2683
  
@tinkoff-dwh Look's like `expand-collapse.directive.js:44`  -> 
"event.stopPropagation()" was prevening it to close, have fixed it.


---

[GitHub] zeppelin issue #2683: ZEPPELIN-3072: Zeppelin UI becomes slow/unresponsive i...

[tinkoff-dwh]

Github user tinkoff-dwh commented on the issue:

https://github.com/apache/zeppelin/pull/2683
  
Tested. LGTM

found bug for navbar dropdown (bug into branch master). 
1) Open navbar list of notes 
2) click to some folder
3) click to note in folder
4) Note loaded but dropdown menu not hide


---

[GitHub] zeppelin issue #2683: ZEPPELIN-3072: Zeppelin UI becomes slow/unresponsive i...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2683
  
Sure, I was experimenting with few more infinity scroll, let me try those 
for performance, then will fix this.


---

[GitHub] zeppelin issue #2683: ZEPPELIN-3072: Zeppelin UI becomes slow/unresponsive i...

[tinkoff-dwh]

Github user tinkoff-dwh commented on the issue:

https://github.com/apache/zeppelin/pull/2683
  
i think looks good


---

[GitHub] zeppelin issue #2683: ZEPPELIN-3072: Zeppelin UI becomes slow/unresponsive i...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2683
  
Sure, in my todo list. Will find this, if this implementation/UX looks OK 


---

[GitHub] zeppelin issue #2683: ZEPPELIN-3072: Zeppelin UI becomes slow/unresponsive i...

[tinkoff-dwh]

Github user tinkoff-dwh commented on the issue:

https://github.com/apache/zeppelin/pull/2683
  
works fine! But have some problems with sorting.

sorting on ui 
1) folders (alphabet)
2) note (alphabet)

load home page, we have part of tree with "local sorting" (one folder on 
top Zeppelin Tutorial)
![2017-11-22 
15-29-55](https://user-images.githubusercontent.com/25951039/33122973-9b758fa2-cf9a-11e7-88e0-bac0040159e5.png)

after scroll to bootom and return to top
![2017-11-22 
15-30-14](https://user-images.githubusercontent.com/25951039/33123019-bb25d384-cf9a-11e7-8f7c-dd98bfacc77b.png)



---

[GitHub] zeppelin issue #2683: ZEPPELIN-3072: Zeppelin UI becomes slow/unresponsive i...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2683
  
@tinkoff-dwh Thank you for the link. This seems to perform well.

Preview GIF

![after](https://user-images.githubusercontent.com/674497/33120645-bddf7884-cf98-11e7-87ca-c5ad0091cb3a.gif)


Let me know your thoughts.


---

[GitHub] zeppelin issue #2683: ZEPPELIN-3072: Zeppelin UI becomes slow/unresponsive i...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2683
  
Yes, thanks I'm trying to explore infinity scroll.


---

[GitHub] zeppelin issue #2683: ZEPPELIN-3072: Zeppelin UI becomes slow/unresponsive i...

[tinkoff-dwh]

Github user tinkoff-dwh commented on the issue:

https://github.com/apache/zeppelin/pull/2683
  
@prabhjyotsingh 
maybe more pretty http://sroze.github.io/ngInfiniteScroll/ . or a another 
implementation of infinite scrolling


---

[GitHub] zeppelin issue #2683: ZEPPELIN-3072: Zeppelin UI becomes slow/unresponsive i...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2683
  
@tinkoff-dwh Sure let me work on that as well.


---

[GitHub] zeppelin issue #2683: ZEPPELIN-3072: Zeppelin UI becomes slow/unresponsive i...

[tinkoff-dwh]

Github user tinkoff-dwh commented on the issue:

https://github.com/apache/zeppelin/pull/2683
  
navbar have the same tree


---