[GitHub] zeppelin issue #2738: [ZEPPELIN-3182] Support saving notebooks to Google Clo...

2018-02-04 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2738
  
Thanks @karth295 will merge if no more comments


---


[GitHub] zeppelin issue #2738: [ZEPPELIN-3182] Support saving notebooks to Google Clo...

2018-02-04 Thread karth295
Github user karth295 commented on the issue:

https://github.com/apache/zeppelin/pull/2738
  
Nice, it's green now (though Jenkins didn't update).


---


[GitHub] zeppelin issue #2738: [ZEPPELIN-3182] Support saving notebooks to Google Clo...

2018-02-03 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2738
  
The failure should due to jar file corrupted, could you clean travis cache 
and trigger the failed build again ? (I mean only rerun the failed build, not 
all the travis build matrix)


---


[GitHub] zeppelin issue #2738: [ZEPPELIN-3182] Support saving notebooks to Google Clo...

2018-02-03 Thread karth295
Github user karth295 commented on the issue:

https://github.com/apache/zeppelin/pull/2738
  
@zjffdu do you know what's causing these failure? (I can't tell whether my 
PR is breaking the tests)


---


[GitHub] zeppelin issue #2738: [ZEPPELIN-3182] Support saving notebooks to Google Clo...

2018-02-03 Thread karth295
Github user karth295 commented on the issue:

https://github.com/apache/zeppelin/pull/2738
  
The new CI failure doesn't seem real to me -- going to close/reopen to make 
it run again.


---


[GitHub] zeppelin issue #2738: [ZEPPELIN-3182] Support saving notebooks to Google Clo...

2018-01-29 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2738
  
@karth295 The only concern is guava, if that doens't affect other function, 
it is fine to me to merge into 0.8 as well 


---


[GitHub] zeppelin issue #2738: [ZEPPELIN-3182] Support saving notebooks to Google Clo...

2018-01-29 Thread karth295
Github user karth295 commented on the issue:

https://github.com/apache/zeppelin/pull/2738
  
@zjffdu I noticed that you just bumped the version to 0.9 -- can this 
feature be integrated into branch-0.8 release as well?


---


[GitHub] zeppelin issue #2738: [ZEPPELIN-3182] Support saving notebooks to Google Clo...

2018-01-28 Thread karth295
Github user karth295 commented on the issue:

https://github.com/apache/zeppelin/pull/2738
  
FYI I finally resolved the dependency issues by using guava 20.0, which is 
the only version that works for both the `google-cloud-java` libraries as well 
as Hadoop (the deprecated `Objects` class).


---


[GitHub] zeppelin issue #2738: [ZEPPELIN-3182] Support saving notebooks to Google Clo...

2018-01-24 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2738
  
CI still fails, could you retrigger it again ? Just close and reopen this 
PR. 


---


[GitHub] zeppelin issue #2738: [ZEPPELIN-3182] Support saving notebooks to Google Clo...

2018-01-23 Thread karth295
Github user karth295 commented on the issue:

https://github.com/apache/zeppelin/pull/2738
  
These two commits are rebased over master.


---


[GitHub] zeppelin issue #2738: [ZEPPELIN-3182] Support saving notebooks to Google Clo...

2018-01-23 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2738
  
@karth295 Please try to rebase your PR, I think the build issue you 
mentioned above has been fixed. 


---


[GitHub] zeppelin issue #2738: [ZEPPELIN-3182] Support saving notebooks to Google Clo...

2018-01-23 Thread karth295
Github user karth295 commented on the issue:

https://github.com/apache/zeppelin/pull/2738
  
The TravisCI failure doesn't look right to me:

```
[WARNING] 
Dependency convergence error for com.google.guava:guava:15.0 paths to 
dependency are:
+-org.apache.zeppelin:zeppelin-zengine:0.8.0-SNAPSHOT
  +-org.apache.zeppelin:zeppelin-interpreter:0.8.0-20170802.043121-7
+-com.google.guava:guava:15.0
and
+-org.apache.zeppelin:zeppelin-zengine:0.8.0-SNAPSHOT
  +-com.google.guava:guava:23.0-android
[WARNING] The requested profile "web-ci" could not be activated because it 
does not exist.
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-enforcer-plugin:1.3.1:enforce (enforce) on 
project zeppelin-zengine: 
org.apache.maven.plugins.enforcer.DependencyConvergence failed with message:
[ERROR] Failed while enforcing releasability the error(s) are [
[ERROR] Dependency convergence error for com.google.guava:guava:15.0 paths 
to dependency are:
[ERROR] +-org.apache.zeppelin:zeppelin-zengine:0.8.0-SNAPSHOT
[ERROR]   +-org.apache.zeppelin:zeppelin-interpreter:0.8.0-20170802.043121-7
[ERROR] +-com.google.guava:guava:15.0
[ERROR] and
[ERROR] +-org.apache.zeppelin:zeppelin-zengine:0.8.0-SNAPSHOT
[ERROR]   +-com.google.guava:guava:23.0-android
```

If you run `mvn clean package`, it should not use the cached 
`org.apache.zeppelin:zeppelin-interpreter:0.8.0-20170802.043121-7`, and the 
dependencies should be correct. (Though maven still scares/confuses me)


---