[GitHub] zeppelin issue #2794: ZEPPELIN-3225: Add a bunch of missing annotations to A...

2018-02-14 Thread monsieurp
Github user monsieurp commented on the issue:

https://github.com/apache/zeppelin/pull/2794
  
Ok something is up. I'm going to file a new PR.


---


[GitHub] zeppelin issue #2794: ZEPPELIN-3225: Add a bunch of missing annotations to A...

2018-02-14 Thread monsieurp
Github user monsieurp commented on the issue:

https://github.com/apache/zeppelin/pull/2794
  
Alright.


---


[GitHub] zeppelin issue #2794: ZEPPELIN-3225: Add a bunch of missing annotations to A...

2018-02-14 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2794
  
Just close and reopen this PR


---


[GitHub] zeppelin issue #2794: ZEPPELIN-3225: Add a bunch of missing annotations to A...

2018-02-14 Thread monsieurp
Github user monsieurp commented on the issue:

https://github.com/apache/zeppelin/pull/2794
  
Hi @zjffdu! Cool. I will file another PR after this one. 

I made a mistake, amended my commit and forced pushed it, which is why the 
CI build failed. How can I get Jenkins to start a build again?


---


[GitHub] zeppelin issue #2794: ZEPPELIN-3225: Add a bunch of missing annotations to A...

2018-02-13 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2794
  
@monsieurp welcome any contribution including document 


---


[GitHub] zeppelin issue #2794: ZEPPELIN-3225: Add a bunch of missing annotations to A...

2018-02-13 Thread monsieurp
Github user monsieurp commented on the issue:

https://github.com/apache/zeppelin/pull/2794
  
Hey @mebelousov! We also use Active Directory at work. We don't go through 
the AD connector though but instead rely on the LDAP connector.

By the way, there are many improvements that are to be made to this class. 
Would the Zeppelin contributors accept a PR to document the class for instance?

Thanks!


---


[GitHub] zeppelin issue #2794: ZEPPELIN-3225: Add a bunch of missing annotations to A...

2018-02-13 Thread mebelousov
Github user mebelousov commented on the issue:

https://github.com/apache/zeppelin/pull/2794
  
Our team uses AD. I have tested.
Seems that it works good.


---