[GitHub] zeppelin issue #2914: [ZEPPELIN-3350] Don't allow set cronExecutionUser

2018-04-12 Thread zjffdu 
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2914
  
Thanks @weand I have created ZEPPELIN-3404 for it


---

[GitHub] zeppelin issue #2914: [ZEPPELIN-3350] Don't allow set cronExecutionUser

2018-04-12 Thread zjffdu 
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2914
  
Thanks @weand I have created ZEPPELIN-3404 for it


---

[GitHub] zeppelin issue #2914: [ZEPPELIN-3350] Don't allow set cronExecutionUser

2018-04-12 Thread weand 
Github user weand commented on the issue:

https://github.com/apache/zeppelin/pull/2914
  
not directly when logged out. instead the NPE happens when Zeppelin gets 
restartet and next cron runs before the note was run manually, which is a 
frequent use case IMHO.
> ERROR [2018-04-12 21:11:00,024] ({DefaultQuartzScheduler_Worker-1} 
QuartzScheduler.java[schedulerError]:2425) - Job (note.2DBFZ9GGT threw an 
exception.
org.quartz.SchedulerException: Job threw an unhandled exception. [See 
nested exception: java.lang.NullPointerException: while trying to invoke the 
method org.apache.zeppelin.user.AuthenticationInfo.getUser() of a null object 
loaded from local variable 'authenticationInfo']
at org.quartz.core.JobRunShell.run(JobRunShell.java:213)
at 
org.quartz.simpl.SimpleThreadPool$WorkerThread.run(SimpleThreadPool.java:573)
Caused by: java.lang.NullPointerException: while trying to invoke the 
method org.apache.zeppelin.user.AuthenticationInfo.getUser() of a null object 
loaded from local variable 'authenticationInfo'
at 
org.apache.zeppelin.notebook.Paragraph.setAuthenticationInfo(Paragraph.java:209)
at org.apache.zeppelin.notebook.Paragraph.execute(Paragraph.java:353)
at org.apache.zeppelin.notebook.Note.run(Note.java:678)
at org.apache.zeppelin.notebook.Note.runAll(Note.java:659)
at org.apache.zeppelin.notebook.Note.runAll(Note.java:648)
at 
org.apache.zeppelin.notebook.Notebook$CronJob.execute(Notebook.java:936)
at org.quartz.core.JobRunShell.run(JobRunShell.java:202)
... 1 more


---

[GitHub] zeppelin issue #2914: [ZEPPELIN-3350] Don't allow set cronExecutionUser

2018-04-11 Thread zjffdu 
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2914
  
@weand Do you see any issue when logged out ? 


---

[GitHub] zeppelin issue #2914: [ZEPPELIN-3350] Don't allow set cronExecutionUser

2018-04-11 Thread weand 
Github user weand commented on the issue:

https://github.com/apache/zeppelin/pull/2914
  
@zjffdu are you sure this works when logged out? i followed the call stack 
and I'm wondering if there would happen NPE if no AuthenticationInfo is present:
org.apache.zeppelin.notebook.Note.runAll(AuthenticationInfo, boolean)
> org.apache.zeppelin.notebook.Paragraph.execute(boolean) : Line 353
> 
org.apache.zeppelin.notebook.Paragraph.setAuthenticationInfo(AuthenticationInfo)
 : Line 209 << NPE


---

[GitHub] zeppelin issue #2914: [ZEPPELIN-3350] Don't allow set cronExecutionUser

2018-04-09 Thread zjffdu 
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2914
  
Doc is added


---

[GitHub] zeppelin issue #2914: [ZEPPELIN-3350] Don't allow set cronExecutionUser

2018-04-09 Thread zjffdu 
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2914
  
@prabhjyotsingh @felixcheung Could you help review this ? Thanks


---