GitHub user felizbear opened a pull request: https://github.com/apache/zeppelin/pull/1714
Fe explicit arguments ### What is this PR for? This is `paragraph.controller.js` maintenance PR. It refactors most functions in paragraph controller to accept explicit parameters instead of getting data from `$scope`. It is a first - simple and safe - step in making paragraph controller more maintainable. ### What type of PR is it? Refactoring ### Todos * [x] - Call functions explicitly with parameters when makes sense * [x] - Do minor refactoring when makes sense ### What is the Jira issue? ### How should this be tested? Make sure that paragraph works as expected by interacting with it; You can merge this pull request into a Git repository by running: $ git pull https://github.com/felizbear/zeppelin fe-explicit-arguments Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1714.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1714 ---- commit cc2fd7b3066ae5ee2cfcca2e7970af02fefdf0c4 Author: felizbear <i...@nflabs.com> Date: 2016-12-01T08:04:31Z make arguments explicit in initializeDefault commit f83e97d38eca0d8b9220c6bf1664a5d609b36020 Author: felizbear <i...@nflabs.com> Date: 2016-12-01T08:08:06Z make arguments explicit in isRunning commit 34ad2033425a548d4e74c229b1d77a1a0e4ca93c Author: felizbear <i...@nflabs.com> Date: 2016-12-01T08:09:42Z make arguments explicit in cancelParagraph commit 3a52626c8d56c644a014db85aeabb9c691c361aa Author: felizbear <i...@nflabs.com> Date: 2016-12-01T08:18:03Z make arguments explicit in saveParagraph commit 1bd90a11e3f8d717860927f2742a485e0db23b50 Author: felizbear <i...@nflabs.com> Date: 2016-12-01T08:20:32Z make arguments explicit in toggleEnableDisable commit 6adb2d8258f5dc30d400b8ddaccdc2e33a474194 Author: felizbear <i...@nflabs.com> Date: 2016-12-01T08:29:42Z make arguments explicit in run commit 8eff4db67bf6c12c4a480cd42d9a7547aaae2cb5 Author: felizbear <i...@nflabs.com> Date: 2016-12-01T08:33:29Z make arguments explicit for moveUp and moveDown commit 9ec637b7b8055a4b9f76ab587808ce5d87b72574 Author: felizbear <i...@nflabs.com> Date: 2016-12-01T08:43:40Z make arguments explicit in insertNew commit 6fd7775a784b61f150398a17bb6fd6f1752a0e4d Author: felizbear <i...@nflabs.com> Date: 2016-12-01T08:45:47Z make arguments explicit in removeParagraph commit 9faf2ed1870fd6eac96b8b0c056d53c4e7bd5972 Author: felizbear <i...@nflabs.com> Date: 2016-12-01T08:46:59Z make arguments explicit in clearParagraphOutput commit a9fde256f0315eb2a16eec0a328cb40cf59c3527 Author: felizbear <i...@nflabs.com> Date: 2016-12-01T08:50:38Z make arguments explicit in toggleEditor commit a80e5f242d3504b1cbeecadfac9c409c23afc5e8 Author: felizbear <i...@nflabs.com> Date: 2016-12-01T08:52:02Z make arguments explicit in open / close table commit 5d82be89305e4b39e848cd23ae67cc3e9241078c Author: felizbear <i...@nflabs.com> Date: 2016-12-01T08:54:37Z make arguments explicit in various open / close editor / table nonsense functions commit e8dafbd34474bc66a512d4e99d6f2e863ae42f94 Author: felizbear <i...@nflabs.com> Date: 2016-12-01T09:09:54Z make arguments explicit in show / hide / set title commit 349229ecb38f4716897795fc1c0f02e9c1578639 Author: felizbear <i...@nflabs.com> Date: 2016-12-01T09:11:29Z make arguments explicit in show / hide lineNumbers commit 9157d6c8f2c43d2d1a30182efd77fff3e61e848f Author: felizbear <i...@nflabs.com> Date: 2016-12-01T09:22:31Z make arguments explicit in changeColWidth commit 1b32d7f5c0aad152d3a05f37901ec77a9b60645c Author: felizbear <i...@nflabs.com> Date: 2016-12-01T09:23:17Z remove unused function toggleGraphOption commit 860f8c6109d4ba845f61a33e46781ad4e6a8284a Author: felizbear <i...@nflabs.com> Date: 2016-12-01T09:24:32Z make arguments explicit in toggleOutput commit 192f340043cda41693a0d056e5d579ca4aed95da Author: felizbear <i...@nflabs.com> Date: 2016-12-01T09:28:11Z make arguments explicit in aceChanged commit 8e61c9e1df1cd18babbd2298452d542574a8aac6 Author: felizbear <i...@nflabs.com> Date: 2016-12-01T09:31:24Z make arguments explicit in getEditorSetting commit b7ab3baee7e2c04e854e34111de8f67cbddbff85 Author: felizbear <i...@nflabs.com> Date: 2016-12-01T09:35:58Z make arguments explicit in autoAdjustEditorHeight commit 7f42a884c1e8e3b7b62de5dfe92283184f039596 Author: felizbear <i...@nflabs.com> Date: 2016-12-01T09:44:16Z refactor getProgress commit b97d5cff5c29a7658ef793b78cea64c32fc80d3e Author: felizbear <i...@nflabs.com> Date: 2016-12-01T09:48:27Z make arguments explicit in various util functions commit 404aed5df1a2121823fec653c987febbbcbab4b5 Author: felizbear <i...@nflabs.com> Date: 2016-12-02T01:38:36Z pass whole paragraph to commitParagraph commit 83d53dcdf44fad9f3248b900643802e10819ceb1 Author: felizbear <i...@nflabs.com> Date: 2016-12-02T01:41:37Z remove custom prototype string method startsWith in favor of indexOf modifying prototypes is unreliable and can lead to bugs commit 46712d2152d4349487954a69796dcac8601a1cd5 Author: felizbear <i...@nflabs.com> Date: 2016-12-02T01:45:11Z make arguments explicit in scroll up / down util functions commit be2ecb06440cfe7e8b1e66ef04edf68b453db5cd Author: felizbear <i...@nflabs.com> Date: 2016-12-02T01:59:48Z remove unused event listener runParagraph ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---