ZooKeeper_branch35_jdk7 - Build # 968 - Failure

2017-05-19 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/968/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 65.36 MB...] [junit] at

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018312#comment-16018312 ] Hadoop QA commented on ZOOKEEPER-2784: -- -1 overall. GitHub Pull Request Build +1

Failed: ZOOKEEPER- PreCommit Build #723

2017-05-19 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/723/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 68.01 MB...] [exec]

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018267#comment-16018267 ] ASF GitHub Bot commented on ZOOKEEPER-2784: --- Github user asdf2014 commented on a diff in the

[GitHub] zookeeper pull request #257: ZOOKEEPER-2784: Add same `sid` config problem c...

2017-05-19 Thread asdf2014
Github user asdf2014 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/257#discussion_r117600268 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -620,6 +625,7 @@ public void run() { int

[GitHub] zookeeper pull request #257: ZOOKEEPER-2784: Add same `sid` config problem c...

2017-05-19 Thread asdf2014
Github user asdf2014 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/257#discussion_r117600247 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -18,6 +18,12 @@ package

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018268#comment-16018268 ] ASF GitHub Bot commented on ZOOKEEPER-2784: --- Github user asdf2014 commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018288#comment-16018288 ] ASF GitHub Bot commented on ZOOKEEPER-2784: --- Github user eribeiro commented on a diff in the

[GitHub] zookeeper pull request #257: ZOOKEEPER-2784: Add same `sid` config problem c...

2017-05-19 Thread eribeiro
Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/257#discussion_r117600729 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -310,8 +311,8 @@ public boolean initiateConnection(Socket sock,

[GitHub] zookeeper pull request #257: ZOOKEEPER-2784: Add same `sid` config problem c...

2017-05-19 Thread asdf2014
Github user asdf2014 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/257#discussion_r117599887 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -310,8 +311,8 @@ public boolean initiateConnection(Socket sock,

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018251#comment-16018251 ] ASF GitHub Bot commented on ZOOKEEPER-2784: --- Github user asdf2014 commented on a diff in the

[GitHub] zookeeper pull request #257: ZOOKEEPER-2784: Add same `sid` config problem c...

2017-05-19 Thread eribeiro
Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/257#discussion_r117600572 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -620,6 +625,7 @@ public void run() { int

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018278#comment-16018278 ] ASF GitHub Bot commented on ZOOKEEPER-2784: --- Github user eribeiro commented on a diff in the

[GitHub] zookeeper pull request #257: ZOOKEEPER-2784: Add same `sid` config problem c...

2017-05-19 Thread asdf2014
Github user asdf2014 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/257#discussion_r117600609 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -620,6 +625,7 @@ public void run() { int

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018304#comment-16018304 ] ASF GitHub Bot commented on ZOOKEEPER-2784: --- Github user asdf2014 commented on the issue:

[GitHub] zookeeper issue #257: ZOOKEEPER-2784: Add same `sid` config problem check

2017-05-19 Thread asdf2014
Github user asdf2014 commented on the issue: https://github.com/apache/zookeeper/pull/257 I don't understand why `jenkins` reports `UnknownHostException`. ```java java.net.UnknownHostException: 10.1.1.-113 at

[GitHub] zookeeper pull request #257: ZOOKEEPER-2784: Add same `sid` config problem c...

2017-05-19 Thread asdf2014
Github user asdf2014 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/257#discussion_r117600142 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -545,6 +545,7 @@ public void testInconsistentPeerType() throws

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018263#comment-16018263 ] ASF GitHub Bot commented on ZOOKEEPER-2784: --- Github user asdf2014 commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018270#comment-16018270 ] ASF GitHub Bot commented on ZOOKEEPER-2784: --- Github user asdf2014 commented on a diff in the

[GitHub] zookeeper pull request #257: ZOOKEEPER-2784: Add same `sid` config problem c...

2017-05-19 Thread asdf2014
Github user asdf2014 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/257#discussion_r117600411 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -677,6 +686,7 @@ public void run() {

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018273#comment-16018273 ] ASF GitHub Bot commented on ZOOKEEPER-2784: --- Github user asdf2014 commented on a diff in the

ZooKeeper_branch34_jdk7 - Build # 1518 - Failure

2017-05-19 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch34_jdk7/1518/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 31.15 MB...] [junit] 2017-05-20 02:51:19,487

[GitHub] zookeeper pull request #257: ZOOKEEPER-2784: Add same `sid` config problem c...

2017-05-19 Thread asdf2014
Github user asdf2014 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/257#discussion_r117600362 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -657,9 +663,12 @@ public void run() {

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018291#comment-16018291 ] ASF GitHub Bot commented on ZOOKEEPER-2784: --- Github user asdf2014 commented on a diff in the

[GitHub] zookeeper pull request #257: ZOOKEEPER-2784: Add same `sid` config problem c...

2017-05-19 Thread asdf2014
Github user asdf2014 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/257#discussion_r117600833 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -310,8 +311,8 @@ public boolean initiateConnection(Socket sock,

Failed: ZOOKEEPER- PreCommit Build #721

2017-05-19 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/721/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 67.99 MB...] [exec]

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018319#comment-16018319 ] Hadoop QA commented on ZOOKEEPER-2784: -- -1 overall. GitHub Pull Request Build +1

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018254#comment-16018254 ] ASF GitHub Bot commented on ZOOKEEPER-2784: --- Github user asdf2014 commented on a diff in the

[GitHub] zookeeper pull request #257: ZOOKEEPER-2784: Add same `sid` config problem c...

2017-05-19 Thread asdf2014
Github user asdf2014 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/257#discussion_r117599897 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -371,6 +372,10 @@ public void receiveConnection(Socket sock) {

[GitHub] zookeeper pull request #257: ZOOKEEPER-2784: Add same `sid` config problem c...

2017-05-19 Thread asdf2014
Github user asdf2014 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/257#discussion_r117600449 --- Diff: src/java/test/org/apache/zookeeper/test/CnxManagerTest.java --- @@ -351,15 +351,55 @@ public void testSocketTimeout() throws Exception {

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018275#comment-16018275 ] ASF GitHub Bot commented on ZOOKEEPER-2784: --- Github user asdf2014 commented on a diff in the

Failed: ZOOKEEPER- PreCommit Build #722

2017-05-19 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/722/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 67.69 MB...] [exec]

Failed: ZOOKEEPER- PreCommit Build #725

2017-05-19 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/725/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 68.12 MB...] [exec]

[GitHub] zookeeper pull request #257: ZOOKEEPER-2784: Add same `sid` config problem c...

2017-05-19 Thread asdf2014
Github user asdf2014 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/257#discussion_r117600150 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -371,6 +372,10 @@ public void receiveConnection(Socket sock) {

[GitHub] zookeeper pull request #257: ZOOKEEPER-2784: Add same `sid` config problem c...

2017-05-19 Thread asdf2014
Github user asdf2014 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/257#discussion_r117600228 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -657,9 +663,12 @@ public void run() {

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018266#comment-16018266 ] ASF GitHub Bot commented on ZOOKEEPER-2784: --- Github user asdf2014 commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018264#comment-16018264 ] ASF GitHub Bot commented on ZOOKEEPER-2784: --- Github user asdf2014 commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018284#comment-16018284 ] ASF GitHub Bot commented on ZOOKEEPER-2784: --- Github user asdf2014 commented on a diff in the

FYI - zetcd: running ZooKeeper apps without ZooKeeper

2017-05-19 Thread Jordan Zimmerman
"The zetcd proxy sits in front of an etcd cluster and serves an emulated ZooKeeper client port, letting unmodified ZooKeeper applications run on top of etcd." https://coreos.com/blog/introducing-zetcd

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018276#comment-16018276 ] ASF GitHub Bot commented on ZOOKEEPER-2784: --- Github user asdf2014 commented on a diff in the

[GitHub] zookeeper pull request #257: ZOOKEEPER-2784: Add same `sid` config problem c...

2017-05-19 Thread asdf2014
Github user asdf2014 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/257#discussion_r117600503 --- Diff: src/java/test/org/apache/zookeeper/test/CnxManagerTest.java --- @@ -351,15 +351,55 @@ public void testSocketTimeout() throws Exception {

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018302#comment-16018302 ] Hadoop QA commented on ZOOKEEPER-2784: -- -1 overall. GitHub Pull Request Build +1

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018324#comment-16018324 ] Hadoop QA commented on ZOOKEEPER-2784: -- -1 overall. GitHub Pull Request Build +1

ZooKeeper_branch34_openjdk7 - Build # 1502 - Still Failing

2017-05-19 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1502/ ### ## LAST 60 LINES OF THE CONSOLE ### Started by timer [EnvInject] - Loading node environment

[GitHub] zookeeper issue #167: commitProcessor does not crash when an unseen commit s...

2017-05-19 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/167 noCrashOnCommittedRequestsOfUnSeenRequestTest is failing here, please investigate.

[jira] [Commented] (ZOOKEEPER-2763) Utils.toCsvBuffer() omits leading 0 for bytes < 0x10

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017753#comment-16017753 ] ASF GitHub Bot commented on ZOOKEEPER-2763: --- Github user afine commented on a diff in the

[GitHub] zookeeper pull request #238: ZOOKEEPER-2763: Utils.toCsvBuffer() omits leadi...

2017-05-19 Thread afine
Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/238#discussion_r117538863 --- Diff: src/java/main/org/apache/jute/Utils.java --- @@ -190,19 +190,32 @@ static String fromCSVString(String s) throws IOException { }

[jira] [Updated] (ZOOKEEPER-2786) Flaky test: org.apache.zookeeper.test.ClientTest.testNonExistingOpCode

2017-05-19 Thread Abraham Fine (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Fine updated ZOOKEEPER-2786: Affects Version/s: 3.4.10 > Flaky test:

[jira] [Commented] (ZOOKEEPER-2763) Utils.toCsvBuffer() omits leading 0 for bytes < 0x10

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017833#comment-16017833 ] ASF GitHub Bot commented on ZOOKEEPER-2763: --- Github user eribeiro commented on the issue:

[jira] [Updated] (ZOOKEEPER-2786) Flaky test: org.apache.zookeeper.test.ClientTest.testNonExistingOpCode

2017-05-19 Thread Abraham Fine (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Fine updated ZOOKEEPER-2786: Affects Version/s: 3.5.3 > Flaky test:

[jira] [Created] (ZOOKEEPER-2786) Flaky test: org.apache.zookeeper.test.ClientTest.testNonExistingOpCode

2017-05-19 Thread Abraham Fine (JIRA)
Abraham Fine created ZOOKEEPER-2786: --- Summary: Flaky test: org.apache.zookeeper.test.ClientTest.testNonExistingOpCode Key: ZOOKEEPER-2786 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2786

[jira] [Commented] (ZOOKEEPER-2763) Utils.toCsvBuffer() omits leading 0 for bytes < 0x10

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017823#comment-16017823 ] ASF GitHub Bot commented on ZOOKEEPER-2763: --- Github user eribeiro commented on the issue:

[GitHub] zookeeper issue #238: ZOOKEEPER-2763: Utils.toCsvBuffer() omits leading 0 fo...

2017-05-19 Thread eribeiro
Github user eribeiro commented on the issue: https://github.com/apache/zookeeper/pull/238 @alburthoffman @afine Hey guys, did you notice that the body of `bufEquals` method could be replaced by `return Arrays.equals(onearray, twoarray);`? In fact, the current implementation

[GitHub] zookeeper issue #238: ZOOKEEPER-2763: Utils.toCsvBuffer() omits leading 0 fo...

2017-05-19 Thread eribeiro
Github user eribeiro commented on the issue: https://github.com/apache/zookeeper/pull/238 Also, loops like the one below: ``` for (int idx = 0; idx < s.length(); idx++) { char ch = s.charAt(idx); ``` could be simplified to `for (char ch :

[GitHub] zookeeper pull request #257: ZOOKEEPER-2784: Add same `sid` config problem c...

2017-05-19 Thread eribeiro
Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/257#discussion_r117527100 --- Diff: src/java/test/org/apache/zookeeper/test/CnxManagerTest.java --- @@ -351,15 +351,55 @@ public void testSocketTimeout() throws Exception {

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017725#comment-16017725 ] ASF GitHub Bot commented on ZOOKEEPER-2784: --- Github user eribeiro commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017731#comment-16017731 ] ASF GitHub Bot commented on ZOOKEEPER-2784: --- Github user eribeiro commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017727#comment-16017727 ] ASF GitHub Bot commented on ZOOKEEPER-2784: --- Github user eribeiro commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017726#comment-16017726 ] ASF GitHub Bot commented on ZOOKEEPER-2784: --- Github user eribeiro commented on a diff in the

[GitHub] zookeeper pull request #257: ZOOKEEPER-2784: Add same `sid` config problem c...

2017-05-19 Thread eribeiro
Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/257#discussion_r117529199 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -371,6 +372,10 @@ public void receiveConnection(Socket sock) {

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017728#comment-16017728 ] ASF GitHub Bot commented on ZOOKEEPER-2784: --- Github user eribeiro commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017729#comment-16017729 ] ASF GitHub Bot commented on ZOOKEEPER-2784: --- Github user eribeiro commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017730#comment-16017730 ] ASF GitHub Bot commented on ZOOKEEPER-2784: --- Github user eribeiro commented on a diff in the

[GitHub] zookeeper pull request #257: ZOOKEEPER-2784: Add same `sid` config problem c...

2017-05-19 Thread eribeiro
Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/257#discussion_r117441737 --- Diff: src/java/test/org/apache/zookeeper/test/CnxManagerTest.java --- @@ -351,15 +351,55 @@ public void testSocketTimeout() throws Exception {

[GitHub] zookeeper pull request #257: ZOOKEEPER-2784: Add same `sid` config problem c...

2017-05-19 Thread eribeiro
Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/257#discussion_r117529736 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -545,6 +545,7 @@ public void testInconsistentPeerType() throws

[GitHub] zookeeper pull request #257: ZOOKEEPER-2784: Add same `sid` config problem c...

2017-05-19 Thread eribeiro
Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/257#discussion_r117528337 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -310,8 +311,8 @@ public boolean initiateConnection(Socket sock,

[GitHub] zookeeper pull request #257: ZOOKEEPER-2784: Add same `sid` config problem c...

2017-05-19 Thread eribeiro
Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/257#discussion_r117407300 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -657,9 +663,12 @@ public void run() {

[GitHub] zookeeper pull request #257: ZOOKEEPER-2784: Add same `sid` config problem c...

2017-05-19 Thread eribeiro
Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/257#discussion_r117530984 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -677,6 +686,7 @@ public void run() {

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018003#comment-16018003 ] ASF GitHub Bot commented on ZOOKEEPER-2784: --- Github user eribeiro commented on a diff in the

[GitHub] zookeeper pull request #257: ZOOKEEPER-2784: Add same `sid` config problem c...

2017-05-19 Thread eribeiro
Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/257#discussion_r117574653 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -371,6 +372,10 @@ public void receiveConnection(Socket sock) {

[jira] [Updated] (ZOOKEEPER-2750) Document SSL Support for Atomic Broadcast protocol

2017-05-19 Thread Abraham Fine (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Fine updated ZOOKEEPER-2750: Attachment: ZooKeeperSSLUserGuide.pdf Suggested changes to ZooKeeper wiki > Document

[GitHub] zookeeper pull request #247: ZOOKEEPER-2778: Potential server deadlock betwe...

2017-05-19 Thread afine
Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/247#discussion_r117582004 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java --- @@ -682,27 +682,19 @@ public void setQuorumAddress(InetSocketAddress addr){

[jira] [Commented] (ZOOKEEPER-2778) Potential server deadlock between follower sync with leader and follower receiving external connection requests.

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018073#comment-16018073 ] ASF GitHub Bot commented on ZOOKEEPER-2778: --- Github user afine commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2786) Flaky test: org.apache.zookeeper.test.ClientTest.testNonExistingOpCode

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017880#comment-16017880 ] ASF GitHub Bot commented on ZOOKEEPER-2786: --- GitHub user afine opened a pull request:

[GitHub] zookeeper pull request #260: ZOOKEEPER-2786: Flaky test: org.apache.zookeepe...

2017-05-19 Thread afine
GitHub user afine opened a pull request: https://github.com/apache/zookeeper/pull/260 ZOOKEEPER-2786: Flaky test: org.apache.zookeeper.test.ClientTest.testNonExistingOpCode On branch 3.4 we attempt to check that an invalid opcode in a request causes the server to disconnect the

[jira] [Commented] (ZOOKEEPER-2786) Flaky test: org.apache.zookeeper.test.ClientTest.testNonExistingOpCode

2017-05-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017918#comment-16017918 ] Hadoop QA commented on ZOOKEEPER-2786: -- -1 overall. GitHub Pull Request Build +1

Failed: ZOOKEEPER- PreCommit Build #719

2017-05-19 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/719/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 68.42 MB...] [exec] +1

[jira] [Commented] (ZOOKEEPER-2786) Flaky test: org.apache.zookeeper.test.ClientTest.testNonExistingOpCode

2017-05-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017948#comment-16017948 ] Hadoop QA commented on ZOOKEEPER-2786: -- -1 overall. GitHub Pull Request Build +1

[GitHub] zookeeper issue #167: commitProcessor does not crash when an unseen commit s...

2017-05-19 Thread nerdyyatrice
Github user nerdyyatrice commented on the issue: https://github.com/apache/zookeeper/pull/167 Thanks Han, will do. so do I still need to re-kick the Jenkins job? > On May 19, 2017, at 9:44 AM, Michael Han wrote: > >

[GitHub] zookeeper pull request #257: ZOOKEEPER-2784: Add same `sid` config problem c...

2017-05-19 Thread afine
Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/257#discussion_r117560586 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -18,6 +18,12 @@ package

[GitHub] zookeeper pull request #257: ZOOKEEPER-2784: Add same `sid` config problem c...

2017-05-19 Thread afine
Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/257#discussion_r117565984 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -677,6 +686,7 @@ public void run() {

[GitHub] zookeeper pull request #257: ZOOKEEPER-2784: Add same `sid` config problem c...

2017-05-19 Thread afine
Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/257#discussion_r117565417 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -620,6 +625,7 @@ public void run() { int

[GitHub] zookeeper pull request #257: ZOOKEEPER-2784: Add same `sid` config problem c...

2017-05-19 Thread afine
Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/257#discussion_r117565584 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -657,9 +663,12 @@ public void run() {

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017969#comment-16017969 ] ASF GitHub Bot commented on ZOOKEEPER-2784: --- Github user afine commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017971#comment-16017971 ] ASF GitHub Bot commented on ZOOKEEPER-2784: --- Github user afine commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017967#comment-16017967 ] ASF GitHub Bot commented on ZOOKEEPER-2784: --- Github user afine commented on a diff in the

[GitHub] zookeeper pull request #257: ZOOKEEPER-2784: Add same `sid` config problem c...

2017-05-19 Thread afine
Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/257#discussion_r117566584 --- Diff: src/java/test/org/apache/zookeeper/test/CnxManagerTest.java --- @@ -351,15 +351,55 @@ public void testSocketTimeout() throws Exception {

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017968#comment-16017968 ] ASF GitHub Bot commented on ZOOKEEPER-2784: --- Github user afine commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2784) Add some limitations on code level for `SID` to avoid configuration problem

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017970#comment-16017970 ] ASF GitHub Bot commented on ZOOKEEPER-2784: --- Github user afine commented on a diff in the

[jira] [Updated] (ZOOKEEPER-2786) Flaky test: org.apache.zookeeper.test.ClientTest.testNonExistingOpCode

2017-05-19 Thread Abraham Fine (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Fine updated ZOOKEEPER-2786: Description: This test is broken on 3.4 and 3.5, but is broken in "different" ways.

[jira] [Commented] (ZOOKEEPER-2786) Flaky test: org.apache.zookeeper.test.ClientTest.testNonExistingOpCode

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017867#comment-16017867 ] ASF GitHub Bot commented on ZOOKEEPER-2786: --- GitHub user afine opened a pull request:

[GitHub] zookeeper pull request #259: ZOOKEEPER-2786: Flaky test: org.apache.zookeepe...

2017-05-19 Thread afine
GitHub user afine opened a pull request: https://github.com/apache/zookeeper/pull/259 ZOOKEEPER-2786: Flaky test: org.apache.zookeeper.test.ClientTest.testNonExistingOpCode On branch 3.5, testNonExistingOpCode appears to always take 30 seconds to execute (far too long):

Failed: ZOOKEEPER- PreCommit Build #720

2017-05-19 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/720/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 34.32 MB...] [exec] +1

[jira] [Commented] (ZOOKEEPER-2763) Utils.toCsvBuffer() omits leading 0 for bytes < 0x10

2017-05-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017019#comment-16017019 ] ASF GitHub Bot commented on ZOOKEEPER-2763: --- Github user alburthoffman commented on a diff

[GitHub] zookeeper pull request #238: ZOOKEEPER-2763: Utils.toCsvBuffer() omits leadi...

2017-05-19 Thread alburthoffman
Github user alburthoffman commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/238#discussion_r117419956 --- Diff: src/java/main/org/apache/jute/Utils.java --- @@ -190,19 +190,32 @@ static String fromCSVString(String s) throws IOException { }