[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

2017-08-18 Thread Jordan Zimmerman (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133267#comment-16133267 ] Jordan Zimmerman commented on ZOOKEEPER-1416: - I ran a new benchmark (FYI - I'll make my

[GitHub] zookeeper issue #330: ZOOKEEPER-2471: ZK Java client should not count sleep ...

2017-08-18 Thread nicktrav
Github user nicktrav commented on the issue: https://github.com/apache/zookeeper/pull/330 Feels a little awkward to have a non-trivial change without any tests :/ > I'm still going to be stuck depending on the behavior of that randomly-generated sleep time, which is going to

Failed: ZOOKEEPER- PreCommit Build #948

2017-08-18 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/948/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 71.44 MB...] [exec]

[jira] [Commented] (ZOOKEEPER-2804) Node creation fails with NPE if ACLs are null

2017-08-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133520#comment-16133520 ] Hadoop QA commented on ZOOKEEPER-2804: -- -1 overall. GitHub Pull Request Build +1

[jira] [Commented] (ZOOKEEPER-2471) Java Zookeeper Client incorrectly considers time spent sleeping as time spent connecting, potentially resulting in infinite reconnect loop

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133300#comment-16133300 ] ASF GitHub Bot commented on ZOOKEEPER-2471: --- Github user nicktrav commented on the issue:

[jira] [Commented] (ZOOKEEPER-2804) Node creation fails with NPE if ACLs are null

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133651#comment-16133651 ] ASF GitHub Bot commented on ZOOKEEPER-2804: --- Github user asfgit closed the pull request at:

[GitHub] zookeeper pull request #279: ZOOKEEPER-2804:Node creation fails with NPE if ...

2017-08-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/279 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zookeeper pull request #323: ZOOKEEPER-2861: Main-Class JAR manifest attribu...

2017-08-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/323 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (ZOOKEEPER-2861) Main-Class JAR manifest attribute is incorrect

2017-08-18 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133785#comment-16133785 ] Hudson commented on ZOOKEEPER-2861: --- FAILURE: Integrated in Jenkins build ZooKeeper-trunk #3504 (See

[jira] [Commented] (ZOOKEEPER-2804) Node creation fails with NPE if ACLs are null

2017-08-18 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133784#comment-16133784 ] Hudson commented on ZOOKEEPER-2804: --- FAILURE: Integrated in Jenkins build ZooKeeper-trunk #3504 (See

[GitHub] zookeeper issue #279: ZOOKEEPER-2804:Node creation fails with NPE if ACLs ar...

2017-08-18 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/279 @jainbhupendra24 merged to master: d7c192c1829cc657d3312f47ecb5b97519d1b30d Do you mind create separate pull requests targeting branch-3.5, and branch-3.4 respectively? The current pull

[jira] [Commented] (ZOOKEEPER-2804) Node creation fails with NPE if ACLs are null

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133654#comment-16133654 ] ASF GitHub Bot commented on ZOOKEEPER-2804: --- Github user hanm commented on the issue:

ZooKeeper_branch35_jdk8 - Build # 641 - Failure

2017-08-18 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/641/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 70.36 MB...] [junit] at

[jira] [Commented] (ZOOKEEPER-2471) Java Zookeeper Client incorrectly considers time spent sleeping as time spent connecting, potentially resulting in infinite reconnect loop

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133639#comment-16133639 ] ASF GitHub Bot commented on ZOOKEEPER-2471: --- Github user hanm commented on the issue:

[GitHub] zookeeper issue #330: ZOOKEEPER-2471: ZK Java client should not count sleep ...

2017-08-18 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/330 The `now` variable was there when this project starts, and `updateNow` was introduced in ZOOKEEPER-909 which was just a refactoring so it's irrelevant to the core logic. I had a chat with @phunt who

[jira] [Resolved] (ZOOKEEPER-2861) Main-Class JAR manifest attribute is incorrect

2017-08-18 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han resolved ZOOKEEPER-2861. Resolution: Fixed Fix Version/s: 3.5.4 3.6.0

[jira] [Commented] (ZOOKEEPER-2861) Main-Class JAR manifest attribute is incorrect

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133717#comment-16133717 ] ASF GitHub Bot commented on ZOOKEEPER-2861: --- Github user asfgit closed the pull request at:

[jira] [Assigned] (ZOOKEEPER-2861) Main-Class JAR manifest attribute is incorrect

2017-08-18 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han reassigned ZOOKEEPER-2861: -- Assignee: Yaniv Kunda > Main-Class JAR manifest attribute is incorrect >

[GitHub] zookeeper issue #323: ZOOKEEPER-2861: Main-Class JAR manifest attribute is i...

2017-08-18 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/323 Thank you for your contribution, @ykunda. Committed to master: 09742f2d050105689592ffb5f5240ebde6f79dee branch-3.5: 2f9cba5694c6b89b93959acfe1c4c7b3c3e91b7d branch-3.4:

[jira] [Commented] (ZOOKEEPER-2861) Main-Class JAR manifest attribute is incorrect

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133722#comment-16133722 ] ASF GitHub Bot commented on ZOOKEEPER-2861: --- Github user hanm commented on the issue:

[jira] [Resolved] (ZOOKEEPER-2804) Node creation fails with NPE if ACLs are null

2017-08-18 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han resolved ZOOKEEPER-2804. Resolution: Fixed Fix Version/s: 3.6.0 > Node creation fails with NPE if ACLs

[jira] [Assigned] (ZOOKEEPER-2804) Node creation fails with NPE if ACLs are null

2017-08-18 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han reassigned ZOOKEEPER-2804: -- Assignee: Bhupendra Kumar Jain > Node creation fails with NPE if ACLs are null >

ZooKeeper-trunk-jdk8 - Build # 1170 - Failure

2017-08-18 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/1170/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 65.52 MB...] [junit] at

ZooKeeper-trunk-WinVS2008 - Build # 2479 - Still Failing

2017-08-18 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008/2479/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 8.37 KB...] [ivy:retrieve] found

ZooKeeper-trunk-WinVS2008 - Build # 2478 - Still Failing

2017-08-18 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008/2478/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 9.00 KB...] [ivy:retrieve] . (19kB)

[jira] [Commented] (ZOOKEEPER-2836) QuorumCnxManager.Listener Thread Better handling of SocketTimeoutException

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131777#comment-16131777 ] ASF GitHub Bot commented on ZOOKEEPER-2836: --- Github user bitgaoshu commented on a diff in

[GitHub] zookeeper pull request #336: ZOOKEEPER-2836: fix SocketTimeoutException

2017-08-18 Thread bitgaoshu
Github user bitgaoshu commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/336#discussion_r133885327 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -647,11 +648,10 @@ public void run() {

Failed: ZOOKEEPER- PreCommit Build #945

2017-08-18 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/945/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 72.04 MB...] [exec]

[jira] [Commented] (ZOOKEEPER-2770) ZooKeeper slow operation log

2017-08-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131873#comment-16131873 ] Hadoop QA commented on ZOOKEEPER-2770: -- -1 overall. GitHub Pull Request Build +1

[jira] [Commented] (ZOOKEEPER-2770) ZooKeeper slow operation log

2017-08-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131884#comment-16131884 ] Hadoop QA commented on ZOOKEEPER-2770: -- -1 overall. GitHub Pull Request Build +1

Failed: ZOOKEEPER- PreCommit Build #947

2017-08-18 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/947/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 70.39 MB...] [exec] +1

[jira] [Commented] (ZOOKEEPER-2770) ZooKeeper slow operation log

2017-08-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131874#comment-16131874 ] Hadoop QA commented on ZOOKEEPER-2770: -- -1 overall. GitHub Pull Request Build +1

Failed: ZOOKEEPER- PreCommit Build #946

2017-08-18 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/946/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 71.49 MB...] [exec] +1

ZooKeeper_branch35_jdk7 - Build # 1081 - Failure

2017-08-18 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/1081/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 63.08 MB...] [junit] 2017-08-18 08:49:39,334

[GitHub] zookeeper issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2017-08-18 Thread skamille
Github user skamille commented on the issue: https://github.com/apache/zookeeper/pull/136 I want to make it clear that I'm not arguing against the feature, I just want us to make sure that we're implementing it in a way that makes sense absent the TreeSet use case, and that we at

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133039#comment-16133039 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user skamille commented on the issue:

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133046#comment-16133046 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user skamille commented on the issue:

[GitHub] zookeeper issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2017-08-18 Thread skamille
Github user skamille commented on the issue: https://github.com/apache/zookeeper/pull/136 > Per 3. This PR does not guarantee that you will see all events. I'll double check the doc to make sure that that's clear. These watches behave exactly as other watches in ZK other than they

[jira] [Commented] (ZOOKEEPER-2836) QuorumCnxManager.Listener Thread Better handling of SocketTimeoutException

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131788#comment-16131788 ] ASF GitHub Bot commented on ZOOKEEPER-2836: --- Github user bitgaoshu commented on a diff in

[GitHub] zookeeper pull request #336: ZOOKEEPER-2836: fix SocketTimeoutException

2017-08-18 Thread bitgaoshu
Github user bitgaoshu commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/336#discussion_r133886561 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -647,11 +648,10 @@ public void run() {

[jira] [Commented] (ZOOKEEPER-2836) QuorumCnxManager.Listener Thread Better handling of SocketTimeoutException

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133137#comment-16133137 ] ASF GitHub Bot commented on ZOOKEEPER-2836: --- Github user skamille commented on a diff in the

[GitHub] zookeeper pull request #336: ZOOKEEPER-2836: fix SocketTimeoutException

2017-08-18 Thread skamille
Github user skamille commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/336#discussion_r133989279 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -638,13 +639,22 @@ public void run() {

[GitHub] zookeeper issue #307: ZOOKEEPER-2770 ZooKeeper slow operation log

2017-08-18 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/307 There are -1 on findbugs, release audits, and test failures reported by Jekins. Please investigate. --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (ZOOKEEPER-2836) QuorumCnxManager.Listener Thread Better handling of SocketTimeoutException

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133178#comment-16133178 ] ASF GitHub Bot commented on ZOOKEEPER-2836: --- Github user skamille commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2770) ZooKeeper slow operation log

2017-08-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133177#comment-16133177 ] ASF GitHub Bot commented on ZOOKEEPER-2770: --- Github user hanm commented on the issue:

[GitHub] zookeeper pull request #336: ZOOKEEPER-2836: fix SocketTimeoutException

2017-08-18 Thread skamille
Github user skamille commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/336#discussion_r133994057 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -638,13 +639,22 @@ public void run() {