[jira] [Commented] (ZOOKEEPER-2953) Flaky Test: testNoLogBeforeLeaderEstablishment

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293479#comment-16293479 ] ASF GitHub Bot commented on ZOOKEEPER-2953: --- Github user asfgit closed the pull request at:

[jira] [Commented] (ZOOKEEPER-2953) Flaky Test: testNoLogBeforeLeaderEstablishment

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293489#comment-16293489 ] ASF GitHub Bot commented on ZOOKEEPER-2953: --- Github user phunt commented on the issue:

[jira] [Resolved] (ZOOKEEPER-2953) Flaky Test: testNoLogBeforeLeaderEstablishment

2017-12-15 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt resolved ZOOKEEPER-2953. - Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.4.12

[GitHub] zookeeper pull request #432: ZOOKEEPER-2953: Flaky Test: testNoLogBeforeLead...

2017-12-15 Thread phunt
Github user phunt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/432#discussion_r157326074 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -335,6 +336,100 @@ public void testHighestZxidJoinLate() throws

[jira] [Commented] (ZOOKEEPER-2953) Flaky Test: testNoLogBeforeLeaderEstablishment

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293475#comment-16293475 ] ASF GitHub Bot commented on ZOOKEEPER-2953: --- Github user phunt commented on a diff in the

[GitHub] zookeeper issue #415: ZOOKEEPER-2939: Added last/min/max proposal size JMX b...

2017-12-15 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/415 > Do you think it's worth merging this PR and refactor it in a separate one to use that lib? I'd say, let's consider it separately. There's probably some work to do to identify what we

[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293506#comment-16293506 ] ASF GitHub Bot commented on ZOOKEEPER-2939: --- Github user phunt commented on the issue:

[jira] [Commented] (ZOOKEEPER-2338) c bindings should create socket's with SOCK_CLOEXEC to avoid fd leaks on fork/exec

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293461#comment-16293461 ] ASF GitHub Bot commented on ZOOKEEPER-2338: --- Github user phunt commented on a diff in the

[GitHub] zookeeper pull request #427: [ZOOKEEPER-2338] - set SOCK_CLOEXEC on socket i...

2017-12-15 Thread phunt
Github user phunt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/427#discussion_r157325096 --- Diff: src/c/configure.ac --- @@ -130,18 +130,66 @@ main() else exit(0); } -], AC_MSG_RESULT(yes) - ipv6=yes, -

[jira] [Commented] (ZOOKEEPER-2953) Flaky Test: testNoLogBeforeLeaderEstablishment

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293481#comment-16293481 ] ASF GitHub Bot commented on ZOOKEEPER-2953: --- Github user phunt commented on the issue:

[GitHub] zookeeper issue #432: ZOOKEEPER-2953: Flaky Test: testNoLogBeforeLeaderEstab...

2017-12-15 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/432 lgtm, +1 thanks @afine ---

[GitHub] zookeeper issue #433: ZOOKEEPER-2953: Flaky Test: testNoLogBeforeLeaderEstab...

2017-12-15 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/433 lgtm. +1 thanks @afine please close this as it's not the default branch won't be closed automatically. ---

[jira] [Commented] (ZOOKEEPER-2953) Flaky Test: testNoLogBeforeLeaderEstablishment

2017-12-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293562#comment-16293562 ] Hudson commented on ZOOKEEPER-2953: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #3661 (See

[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293511#comment-16293511 ] ASF GitHub Bot commented on ZOOKEEPER-2939: --- Github user phunt commented on the issue:

[GitHub] zookeeper pull request #432: ZOOKEEPER-2953: Flaky Test: testNoLogBeforeLead...

2017-12-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/432 ---

[GitHub] zookeeper issue #415: ZOOKEEPER-2939: Added last/min/max proposal size JMX b...

2017-12-15 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/415 > One approach (which this PR tries to follow) is to expose basic values which can be sampled by a more sophisticated monitoring tool. Average, sliding window, etc. can be implemented in there.

[GitHub] zookeeper issue #434: ZOOKEEPER-2953: Flaky Test: testNoLogBeforeLeaderEstab...

2017-12-15 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/434 lgtm +1 thanks @afine Please close this one as well. ---

ZooKeeper_branch34_jdk7 - Build # 1761 - Failure

2017-12-15 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch34_jdk7/1761/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 38.33 KB...] [junit] Running

Re: Documentation improvements proposal for ZK

2017-12-15 Thread Patrick Hunt
Any other comments? I haven't seen any negative feedback so I'm going to move ahead with this unless someone speaks up soon. :-) Regards, Patrick On Tue, Dec 12, 2017 at 1:40 PM, Michael Han wrote: > +1, this looks great, thanks for doing this Pat! > > On Wed, Dec 6, 2017 at

[jira] [Commented] (ZOOKEEPER-2953) Flaky Test: testNoLogBeforeLeaderEstablishment

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293485#comment-16293485 ] ASF GitHub Bot commented on ZOOKEEPER-2953: --- Github user phunt commented on the issue:

[GitHub] zookeeper pull request #434: ZOOKEEPER-2953: Flaky Test: testNoLogBeforeLead...

2017-12-15 Thread afine
Github user afine closed the pull request at: https://github.com/apache/zookeeper/pull/434 ---

[jira] [Commented] (ZOOKEEPER-2953) Flaky Test: testNoLogBeforeLeaderEstablishment

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293516#comment-16293516 ] ASF GitHub Bot commented on ZOOKEEPER-2953: --- Github user afine closed the pull request at:

ZooKeeper-trunk-openjdk7 - Build # 1736 - Still Failing

2017-12-15 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/1736/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 60.70 KB...] [junit] Running

[GitHub] zookeeper pull request #433: ZOOKEEPER-2953: Flaky Test: testNoLogBeforeLead...

2017-12-15 Thread afine
Github user afine closed the pull request at: https://github.com/apache/zookeeper/pull/433 ---

[jira] [Commented] (ZOOKEEPER-2953) Flaky Test: testNoLogBeforeLeaderEstablishment

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293517#comment-16293517 ] ASF GitHub Bot commented on ZOOKEEPER-2953: --- Github user afine closed the pull request at:

ZooKeeper-trunk - Build # 3659 - Failure

2017-12-15 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk/3659/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 140.22 KB...] [junit] Running

[jira] [Updated] (ZOOKEEPER-2956) Cannot delete znode that owns too many child znodes by `rmr` command

2017-12-15 Thread Benedict Jin (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedict Jin updated ZOOKEEPER-2956: Attachment: 172MB_child_znodes_list.png > Cannot delete znode that owns too many child

[jira] [Updated] (ZOOKEEPER-2956) Cannot delete znode that owns too many child znodes by `rmr` command

2017-12-15 Thread Benedict Jin (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedict Jin updated ZOOKEEPER-2956: Description: We cannot delete znode that owns too many child znodes by `rmr` command,

[jira] [Updated] (ZOOKEEPER-2956) Cannot delete znode that owns too many child znodes by `rmr` command

2017-12-15 Thread Benedict Jin (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedict Jin updated ZOOKEEPER-2956: Attachment: rmr_failed.png > Cannot delete znode that owns too many child znodes by

[jira] [Created] (ZOOKEEPER-2956) Cannot delete znode that owns too many child znodes by `rmr` command

2017-12-15 Thread Benedict Jin (JIRA)
Benedict Jin created ZOOKEEPER-2956: --- Summary: Cannot delete znode that owns too many child znodes by `rmr` command Key: ZOOKEEPER-2956 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2956

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292545#comment-16292545 ] Hadoop QA commented on ZOOKEEPER-2893: -- +1 overall. GitHub Pull Request Build +1

Success: ZOOKEEPER- PreCommit Build #1375

2017-12-15 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1375/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 72.00 MB...] [exec]

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-15 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292522#comment-16292522 ] Andor Molnar commented on ZOOKEEPER-2893: - [~paulmillar] Done. Let's move this review to

[GitHub] zookeeper pull request #430: ZOOKEEPER-2893. very poor choice of logging if ...

2017-12-15 Thread paulmillar
Github user paulmillar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/430#discussion_r157201054 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -1231,14 +1231,14 @@ public void run() {

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292541#comment-16292541 ] ASF GitHub Bot commented on ZOOKEEPER-2893: --- Github user paulmillar commented on a diff in

[jira] [Created] (ZOOKEEPER-2957) Whether zookeeper client-server nio or netty communication can use socket proxies

2017-12-15 Thread mugulong (JIRA)
mugulong created ZOOKEEPER-2957: --- Summary: Whether zookeeper client-server nio or netty communication can use socket proxies Key: ZOOKEEPER-2957 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2957

[jira] [Updated] (ZOOKEEPER-2956) Cannot delete znode that owns too many child znodes by `rmr` command

2017-12-15 Thread Benedict Jin (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedict Jin updated ZOOKEEPER-2956: Description: We cannot delete znode that owns too many child znodes by `rmr` command,

ZooKeeper-trunk-openjdk7 - Build # 1734 - Still Failing

2017-12-15 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/1734/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 61.68 KB...] [junit] Tests run: 1, Failures:

[jira] [Commented] (ZOOKEEPER-2249) CRC check failed when preAllocSize smaller than node data

2017-12-15 Thread Esteban Gutierrez (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292784#comment-16292784 ] Esteban Gutierrez commented on ZOOKEEPER-2249: -- There is something wrong on the

[GitHub] zookeeper pull request #430: ZOOKEEPER-2893. very poor choice of logging if ...

2017-12-15 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/430#discussion_r157266599 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -1231,14 +1231,14 @@ public void run() {

[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals

2017-12-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292983#comment-16292983 ] Hadoop QA commented on ZOOKEEPER-2939: -- -1 overall. GitHub Pull Request Build +1

Failed: ZOOKEEPER- PreCommit Build #1376

2017-12-15 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1376/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 68.65 MB...] [exec] +1

[GitHub] zookeeper issue #415: ZOOKEEPER-2939: Added last/min/max proposal size JMX b...

2017-12-15 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/415 @phunt I added proposal stats to 'mntr' command output as requested. In the meantime I found the following metrics lib which could be useful and easily integrated into Zookeeper:

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292967#comment-16292967 ] ASF GitHub Bot commented on ZOOKEEPER-2893: --- Github user anmolnar commented on a diff in the

[jira] [Assigned] (ZOOKEEPER-2249) CRC check failed when preAllocSize smaller than node data

2017-12-15 Thread Abraham Fine (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Fine reassigned ZOOKEEPER-2249: --- Assignee: Abraham Fine > CRC check failed when preAllocSize smaller than node

[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292961#comment-16292961 ] ASF GitHub Bot commented on ZOOKEEPER-2939: --- Github user anmolnar commented on the issue:

ZooKeeper-trunk-openjdk7 - Build # 1735 - Still Failing

2017-12-15 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/1735/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 61.06 KB...] [junit] Tests run: 1, Failures: