Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/415
@phunt @afine Do you think this PR is ready to committed before the
Dropwizard one?
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348355#comment-16348355
]
ASF GitHub Bot commented on ZOOKEEPER-2939:
---
Github user anmolnar commented on the issue:
See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/1360/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 59.11 KB...]
[junit] Running
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/451
@phunt @afine Did you have a chance to take a look?
I think we've addressed all issues that were mentioned in the original PR.
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348358#comment-16348358
]
ASF GitHub Bot commented on ZOOKEEPER-2184:
---
Github user anmolnar commented on the issue:
congrats Abe!
-rgs
On Wed, Jan 31, 2018 at 8:47 PM, Mohammad arshad wrote:
> Congratulations and Welcome Abe!
>
> -Arshad
>
> -Original Message-
> From: Michael Han [mailto:h...@apache.org]
> Sent: Wednesday, January 31, 2018 12:09 PM
> To:
Github user afine commented on the issue:
https://github.com/apache/zookeeper/pull/296
Merged. Thanks @asdf2014!
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349490#comment-16349490
]
ASF GitHub Bot commented on ZOOKEEPER-2824:
---
Github user afine commented on the issue:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abraham Fine resolved ZOOKEEPER-2824.
-
Resolution: Fixed
Issue resolved by pull request 296
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/296
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349488#comment-16349488
]
ASF GitHub Bot commented on ZOOKEEPER-2824:
---
Github user asfgit closed the pull request at:
Github user jeffwidman commented on the issue:
https://github.com/apache/zookeeper/pull/451
Should this PR be targeting `branch-3.4` or target `trunk` and then
backport to the 3.4 series?
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349381#comment-16349381
]
ASF GitHub Bot commented on ZOOKEEPER-2184:
---
Github user jeffwidman commented on the issue:
Github user mfenes commented on the issue:
https://github.com/apache/zookeeper/pull/450
@afine I've made the following changes:
Replaced "log" and "snapshot" strings with constants
FileTxnLog.LOG_FILE_PREFIX and FileSnap.SNAPSHOT_FILE_PREFIX.
Used Util.makeLogName when
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349595#comment-16349595
]
ASF GitHub Bot commented on ZOOKEEPER-2184:
---
Github user afine commented on a diff in the
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r165529085
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -91,15 +79,106 @@ public
StaticHostProvider(Collection serverAddresses)
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r165524377
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -25,6 +25,8 @@
import java.util.Collection;
import
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349592#comment-16349592
]
ASF GitHub Bot commented on ZOOKEEPER-2184:
---
Github user afine commented on a diff in the
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r165525652
--- Diff: src/java/test/org/apache/zookeeper/test/ReadOnlyModeTest.java ---
@@ -239,13 +243,13 @@ public void testSessionEstablishment() throws
Exception {
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r165527366
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -57,29 +62,12 @@
*/
public
Ethan Wang created ZOOKEEPER-2974:
-
Summary: Link invalid, please update
http://zookeeper.apache.org/doc/trunk/zookeeperStarted.html
Key: ZOOKEEPER-2974
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2974
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349612#comment-16349612
]
ASF GitHub Bot commented on ZOOKEEPER-2824:
---
Github user asdf2014 commented on the issue:
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/296
@afine You are welcome :-)
---
Github user afine commented on the issue:
https://github.com/apache/zookeeper/pull/415
@phunt I think this is ready to merge. Just waiting on your +1.
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349509#comment-16349509
]
ASF GitHub Bot commented on ZOOKEEPER-2939:
---
Github user afine commented on the issue:
Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/450#discussion_r165525848
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java ---
@@ -136,13 +136,51 @@ public FileTxnSnapLog(File dataDir, File
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349544#comment-16349544
]
ASF GitHub Bot commented on ZOOKEEPER-2967:
---
Github user mfenes commented on a diff in the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349541#comment-16349541
]
ASF GitHub Bot commented on ZOOKEEPER-2967:
---
Github user mfenes commented on the issue:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349584#comment-16349584
]
Hudson commented on ZOOKEEPER-2824:
---
SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #3714 (See
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349593#comment-16349593
]
ASF GitHub Bot commented on ZOOKEEPER-2184:
---
Github user afine commented on a diff in the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349596#comment-16349596
]
ASF GitHub Bot commented on ZOOKEEPER-2184:
---
Github user afine commented on a diff in the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349594#comment-16349594
]
ASF GitHub Bot commented on ZOOKEEPER-2184:
---
Github user afine commented on a diff in the
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1442/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 75.72 MB...]
[exec] +1
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r165525113
--- Diff:
src/java/test/org/apache/zookeeper/client/StaticHostProviderTest.java ---
@@ -16,7 +16,7 @@
* limitations under the License.
*/
See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/1361/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 59.82 KB...]
[junit] Running
See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/1789/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 65.00 KB...]
[junit] Tests run: 6, Failures:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349882#comment-16349882
]
caixiaofeng commented on ZOOKEEPER-1467:
Mark
> Server principal on client side is derived
See https://builds.apache.org/job/ZooKeeper_branch35_openjdk7/832/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 59.81 KB...]
[junit] Tests run: 1,
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349900#comment-16349900
]
caixiaofeng commented on ZOOKEEPER-2973:
I met OutOfMemory error cause zookeeper shutdown.
See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/1275/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 3.51 KB...]
at
See https://builds.apache.org/job/ZooKeeper_branch35_openjdk7/831/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 59.54 KB...]
[junit] Tests run: 1,
41 matches
Mail list logo