Criticism on ZK

Hello community, I came across this blog post: https://banzaicloud.com/blog/kafka-on-etcd/ And I thought it would be a good idea to discuss the criticism as a community. Let me copy the points here and add some notes: • Unlike Kafka it does not have a vibrant and huge community

ZooKeeper_branch35_jdk8 - Build # 844 - Still Failing

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/844/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 16.83 KB...] [ivy:retrieve] found

ZooKeeper-trunk-jdk8 - Build # 1374 - Failure

See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/1374/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 104.55 KB...] [junit] Tests run: 1, Failures: 0,

[GitHub] zookeeper pull request #453: ZOOKEEPER-2845: Send a SNAP if transactions can...

Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/453#discussion_r167838309 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/LearnerHandlerTest.java --- @@ -462,6 +469,8 @@ public void testNewEpochZxid() throws

[GitHub] zookeeper pull request #453: ZOOKEEPER-2845: Send a SNAP if transactions can...

Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/453#discussion_r167838605 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/LearnerHandlerTest.java --- @@ -498,31 +507,20 @@ public void

[jira] [Commented] (ZOOKEEPER-2845) Data inconsistency issue due to retain database in leader election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362233#comment-16362233 ] ASF GitHub Bot commented on ZOOKEEPER-2845: --- Github user revans2 commented on the issue:

[GitHub] zookeeper issue #453: ZOOKEEPER-2845: Apply commit log when restarting serve...

Github user revans2 commented on the issue: https://github.com/apache/zookeeper/pull/453 Thank you to everyone who reviewed the patch, but with the help of Fangmin Lv I found one case that the original patch didn't cover. I have reworked the patch to cover that case, but to do so I

Failed: ZOOKEEPER- PreCommit Build #1474

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1474/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 794.39 KB...] [exec]

Failed: ZOOKEEPER- PreCommit Build #1473

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1473/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 40.35 MB...] [exec] +1

[jira] [Commented] (ZOOKEEPER-2845) Data inconsistency issue due to retain database in leader election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1636#comment-1636 ] ASF GitHub Bot commented on ZOOKEEPER-2845: --- Github user anmolnar commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2845) Data inconsistency issue due to retain database in leader election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362223#comment-16362223 ] ASF GitHub Bot commented on ZOOKEEPER-2845: --- Github user anmolnar commented on a diff in the

Failed: ZOOKEEPER- PreCommit Build #1476

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1476/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 6.52 KB...] [exec] % Total

Failed: ZOOKEEPER- PreCommit Build #1475

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1475/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 35.13 KB...] [exec]

[jira] [Commented] (ZOOKEEPER-2845) Data inconsistency issue due to retain database in leader election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362234#comment-16362234 ] Robert Joseph Evans commented on ZOOKEEPER-2845: [~lvfangmin], Thanks for pushing on

Success: ZOOKEEPER- PreCommit Build #1477

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1477/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 77.91 MB...] [exec]

[jira] [Commented] (ZOOKEEPER-2845) Data inconsistency issue due to retain database in leader election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362164#comment-16362164 ] ASF GitHub Bot commented on ZOOKEEPER-2845: --- Github user mfenes commented on a diff in the

Success: ZOOKEEPER- PreCommit Build #1472

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1472/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 39.78 MB...] [exec]

[GitHub] zookeeper pull request #453: ZOOKEEPER-2845: Send a SNAP if transactions can...

Github user mfenes commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/453#discussion_r167835407 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java --- @@ -758,6 +760,11 @@ public boolean syncFollower(long peerLastZxid,

Re: Review request for ZOOKEEPER-2845

Give me some time to catch up with the discussion thread in the issue, please. -Flavio > On 5 Feb 2018, at 15:43, Bobby Evans wrote: > > I was really hoping to get a review for ZOOKEEPER-2845 > > https://github.com/apache/zookeeper/pull/453 (master) >

ZooKeeper_branch35_jdk7 - Build # 1289 - Still Failing

See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/1289/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 16.28 KB...] [ivy:retrieve] found

Failed: ZOOKEEPER- PreCommit Build #1470

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1470/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 77.75 MB...] [exec] +1

Failed: ZOOKEEPER- PreCommit Build #1471

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1471/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 65.97 MB...] [exec] +1

ZooKeeper_branch35_openjdk7 - Build # 845 - Still Failing

See https://builds.apache.org/job/ZooKeeper_branch35_openjdk7/845/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 16.84 KB...] [ivy:retrieve] found

[jira] [Commented] (ZOOKEEPER-2845) Data inconsistency issue due to retain database in leader election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362412#comment-16362412 ] ASF GitHub Bot commented on ZOOKEEPER-2845: --- Github user anmolnar commented on the issue:

[GitHub] zookeeper issue #453: ZOOKEEPER-2845: Apply commit log when restarting serve...

Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/453 @revans2 Your latest change looks good to me and a bit safer than the previous one. Would you please consider adding some unit tests to validate the functionality? What do you think of

[jira] [Commented] (ZOOKEEPER-2845) Data inconsistency issue due to retain database in leader election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362423#comment-16362423 ] ASF GitHub Bot commented on ZOOKEEPER-2845: --- Github user anmolnar commented on a diff in the

[GitHub] zookeeper issue #453: ZOOKEEPER-2845: Apply commit log when restarting serve...

Github user revans2 commented on the issue: https://github.com/apache/zookeeper/pull/453 @anmolnar I will add some kind of a test. I ran into a lot of issues with `testTxnAheadSnapInRetainDB`. I could not get it to run correctly against master as it would always end up electing the

[jira] [Commented] (ZOOKEEPER-2845) Data inconsistency issue due to retain database in leader election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362505#comment-16362505 ] ASF GitHub Bot commented on ZOOKEEPER-2845: --- Github user revans2 commented on the issue:

[jira] [Commented] (ZOOKEEPER-2845) Data inconsistency issue due to retain database in leader election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362425#comment-16362425 ] ASF GitHub Bot commented on ZOOKEEPER-2845: --- Github user revans2 commented on a diff in the

Re: Criticism on ZK

> • Unlike Kafka it does not have a vibrant and huge community (merge those > PR’s please, anyone?) This is clearly true. The community was active 5 or so years ago but in the past few years it's almost non-existent. Patrick is the only active committer. It can take years (!!) and numerous

[GitHub] zookeeper pull request #453: ZOOKEEPER-2845: Apply commit log when restartin...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/453#discussion_r167885280 --- Diff: src/java/main/org/apache/zookeeper/server/ZKDatabase.java --- @@ -233,14 +233,32 @@ public long getDataTreeLastProcessedZxid() { *

[jira] [Commented] (ZOOKEEPER-2845) Data inconsistency issue due to retain database in leader election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362576#comment-16362576 ] ASF GitHub Bot commented on ZOOKEEPER-2845: --- Github user anmolnar commented on the issue:

[GitHub] zookeeper pull request #453: ZOOKEEPER-2845: Apply commit log when restartin...

Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/453#discussion_r167884587 --- Diff: src/java/main/org/apache/zookeeper/server/ZKDatabase.java --- @@ -233,14 +233,32 @@ public long getDataTreeLastProcessedZxid() { *

Re: Criticism on ZK

On Tue, Feb 13, 2018 at 6:47 AM, Jordan Zimmerman < jor...@jordanzimmerman.com> wrote: > > • Unlike Kafka it does not have a vibrant and huge community (merge > those PR’s please, anyone?) > > This is clearly true. The community was active 5 or so years ago but in > the past few years it's almost

[GitHub] zookeeper issue #453: ZOOKEEPER-2845: Apply commit log when restarting serve...

Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/453 @revans2 Take a look at `testElectionFraud()` in the same file. Maybe I'm wrong, but it seems to me trying to achieve something similar. ---

Failed: ZOOKEEPER- PreCommit Build #1479

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1479/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 6.52 KB...] [exec] Pull

Success: ZOOKEEPER- PreCommit Build #1478

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1478/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 38.86 MB...] [exec]

[GitHub] zookeeper issue #453: ZOOKEEPER-2845: Apply commit log when restarting serve...

Github user revans2 commented on the issue: https://github.com/apache/zookeeper/pull/453 @anmolnar I added in an updated version of the test in #310. The issue turned out to be a race condition where the original leader would time out clients and then would join the new quorum too

[jira] [Commented] (ZOOKEEPER-2845) Data inconsistency issue due to retain database in leader election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362939#comment-16362939 ] ASF GitHub Bot commented on ZOOKEEPER-2845: --- Github user revans2 commented on the issue:

[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363152#comment-16363152 ] ASF GitHub Bot commented on ZOOKEEPER-2939: --- Github user afine commented on the issue:

[GitHub] zookeeper issue #463: ZOOKEEPER-2939 Deal with maxbuffer as it relates to pr...

Github user afine commented on the issue: https://github.com/apache/zookeeper/pull/463 @anmolnar Thank you for fixing this so quickly. Please create a new JIRA for this (as things get complicated when we have many commits for the same JIRA ticket) and I will merge this. ---

[jira] [Commented] (ZOOKEEPER-645) Bug in WriteLock recipe implementation?

[ https://issues.apache.org/jira/browse/ZOOKEEPER-645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363174#comment-16363174 ] Kathryn Hogg commented on ZOOKEEPER-645: I'm getting WriteLocks never being granted on 3.4.11

Success: ZOOKEEPER- PreCommit Build #1480

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1480/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 78.26 MB...] [exec]

[jira] [Comment Edited] (ZOOKEEPER-645) Bug in WriteLock recipe implementation?

[ https://issues.apache.org/jira/browse/ZOOKEEPER-645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363174#comment-16363174 ] Kathryn Hogg edited comment on ZOOKEEPER-645 at 2/13/18 10:47 PM: -- I'm

[jira] [Comment Edited] (ZOOKEEPER-645) Bug in WriteLock recipe implementation?

[ https://issues.apache.org/jira/browse/ZOOKEEPER-645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363174#comment-16363174 ] Kathryn Hogg edited comment on ZOOKEEPER-645 at 2/13/18 10:46 PM: -- I'm

[jira] [Updated] (ZOOKEEPER-2963) standalone

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] maoling updated ZOOKEEPER-2963: --- Summary: standalone (was: 1) > standalone > -- > > Key: ZOOKEEPER-2963 >

Re: Criticism on ZK

Some quick feedbacks: > We also don't have conferences and large meetups compared to other communities. Are those really necessary, though? I think regular meetups would definitely help, it's always good to meet with people and do knowledge sharing. > What can we do to be a better community? I

[jira] [Assigned] (ZOOKEEPER-2963) standalone

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] maoling reassigned ZOOKEEPER-2963: -- Assignee: maoling > standalone > -- > > Key: ZOOKEEPER-2963 >

[jira] [Updated] (ZOOKEEPER-2963) standalone

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] maoling updated ZOOKEEPER-2963: --- Description: Today is Valentine's Day.I am still a single dog. When reading this line code

[jira] [Commented] (ZOOKEEPER-2963) standalone

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363473#comment-16363473 ] ASF GitHub Bot commented on ZOOKEEPER-2963: --- GitHub user maoling opened a pull request:

[GitHub] zookeeper pull request #464: ZOOKEEPER-2963:standalone

GitHub user maoling opened a pull request: https://github.com/apache/zookeeper/pull/464 ZOOKEEPER-2963:standalone more details in [JIRA:ZOOKEEPER-2963](https://issues.apache.org/jira/browse/ZOOKEEPER-2963) You can merge this pull request into a Git repository by running: $

Success: ZOOKEEPER- PreCommit Build #1481

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1481/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 78.49 MB...] [exec]