[jira] [Commented] (ZOOKEEPER-3007) Potential NPE in ReferenceCountedACLCache#deserialize

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415231#comment-16415231 ] ASF GitHub Bot commented on ZOOKEEPER-3007: --- Github user LJ1043041006 commented on the

[GitHub] zookeeper pull request #495: ZOOKEEPER-3007:Potential NPE in ReferenceCounte...

Github user LJ1043041006 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/495#discussion_r177351128 --- Diff: src/java/main/org/apache/zookeeper/server/ReferenceCountedACLCache.java --- @@ -109,16 +109,18 @@ public synchronized void

[GitHub] zookeeper pull request #495: ZOOKEEPER-3007:Potential NPE in ReferenceCounte...

Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/495#discussion_r177343134 --- Diff: src/java/main/org/apache/zookeeper/server/ReferenceCountedACLCache.java --- @@ -109,16 +109,18 @@ public synchronized void

[jira] [Commented] (ZOOKEEPER-3007) Potential NPE in ReferenceCountedACLCache#deserialize

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415210#comment-16415210 ] ASF GitHub Bot commented on ZOOKEEPER-3007: --- Github user anmolnar commented on a diff in the

[GitHub] zookeeper issue #495: ZOOKEEPER-3007:Potential NPE in ReferenceCountedACLCac...

Github user LJ1043041006 commented on the issue: https://github.com/apache/zookeeper/pull/495 @brettKK so if we change code like this : `Index j = ia.startVector("acls"); if (j == null){ throw new IOException("errmessage"); } while (!j.done) ..

[jira] [Commented] (ZOOKEEPER-3007) Potential NPE in ReferenceCountedACLCache#deserialize

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415248#comment-16415248 ] ASF GitHub Bot commented on ZOOKEEPER-3007: --- Github user LJ1043041006 commented on a diff in

[GitHub] zookeeper issue #495: ZOOKEEPER-3007:Potential NPE in ReferenceCountedACLCac...

Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/495 @brettKK Thanks for the fix. It'd be nice to add at least a unit test to cover the issue. I think adding the check alone is not enough here. Looking at the `serialize()` method, if

[jira] [Commented] (ZOOKEEPER-3007) Potential NPE in ReferenceCountedACLCache#deserialize

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415220#comment-16415220 ] ASF GitHub Bot commented on ZOOKEEPER-3007: --- Github user anmolnar commented on the issue:

[GitHub] zookeeper issue #495: ZOOKEEPER-3007:Potential NPE in ReferenceCountedACLCac...

Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/495 @LJ1043041006 Looking good. RuntimeException might suit better, but I'm not sure. ---

[jira] [Commented] (ZOOKEEPER-3007) Potential NPE in ReferenceCountedACLCache#deserialize

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415411#comment-16415411 ] ASF GitHub Bot commented on ZOOKEEPER-3007: --- Github user brettKK commented on the issue:

[GitHub] zookeeper issue #495: ZOOKEEPER-3007:Potential NPE in ReferenceCountedACLCac...

Github user brettKK commented on the issue: https://github.com/apache/zookeeper/pull/495 yeah， I will fix it @anmolnar @maoling @LJ1043041006 ---

[jira] [Commented] (ZOOKEEPER-3007) Potential NPE in ReferenceCountedACLCache#deserialize

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415452#comment-16415452 ] ASF GitHub Bot commented on ZOOKEEPER-3007: --- Github user anmolnar commented on the issue:

ZooKeeper_branch34_openjdk7 - Build # 1862 - Still Failing

See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1862/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 39.59 KB...] [junit] Tests run: 1,

[jira] [Created] (ZOOKEEPER-3012) Fix unit test: testDataDirAndDataLogDir should not use hardcode test folders

Andor Molnar created ZOOKEEPER-3012: --- Summary: Fix unit test: testDataDirAndDataLogDir should not use hardcode test folders Key: ZOOKEEPER-3012 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3012

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

+1 for candidate 1 - verified signatures - unit test passed on Mac and Ubuntu 16.04 (including c++) - verified 3 node cluster Andor On Tue, Mar 27, 2018 at 7:05 AM, Abraham Fine wrote: > This is a bugfix release candidate for 3.4.12. It fixes 22 issues, > including issues

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

+1 checked signatures unit tests passed on Linux

[GitHub] zookeeper issue #488: ZOOKEEPER-2993 - Removed 'generated' line from .gitign...

Github user jason95 commented on the issue: https://github.com/apache/zookeeper/pull/488 Thanks everyone!! @afine @asutosh936 @anmolnar @tamaashu ---

[jira] [Commented] (ZOOKEEPER-2993) .ignore file prevents adding src/java/main/org/apache/jute/compiler/generated dir to git repo

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415734#comment-16415734 ] ASF GitHub Bot commented on ZOOKEEPER-2993: --- Github user jason95 commented on the issue:

Success: ZOOKEEPER- PreCommit Build #1555

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1555/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 78.93 MB...] [exec]

[jira] [Updated] (ZOOKEEPER-3013) Fix Typo in doc

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sanjay Pillai updated ZOOKEEPER-3013: - Description: Fix a minor typo in zookeeperProgrammers.html doc > Fix Typo in doc >

[jira] [Created] (ZOOKEEPER-3013) Fix Typo in doc

Sanjay Pillai created ZOOKEEPER-3013: Summary: Fix Typo in doc Key: ZOOKEEPER-3013 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3013 Project: ZooKeeper Issue Type: Bug

[jira] [Resolved] (ZOOKEEPER-3013) Fix Typo in doc

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sanjay Pillai resolved ZOOKEEPER-3013. -- Resolution: Invalid > Fix Typo in doc > --- > > Key: