[jira] [Commented] (ZOOKEEPER-3017) Link libm in CMake on FreeBSD

2018-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427581#comment-16427581 ] ASF GitHub Bot commented on ZOOKEEPER-3017: --- Github user andschwa commented on the issue:

[jira] [Commented] (ZOOKEEPER-3018) Ephemeral node not deleted after session is gone

2018-04-05 Thread Daniel C (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427576#comment-16427576 ] Daniel C commented on ZOOKEEPER-3018: - No, we haven't tried those versions yet. We got two more

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 0

2018-04-05 Thread Flavio Junqueira
We should consider not using md5 for the next RC as per the ASF policy: https://www.apache.org/dev/release-distribution.html#sigs-and-sums -Flavio > On 26 Mar 2018, at 21:37, Abraham Fine wrote: > > Thank you everyone for your votes to far. Due to the issues that

ZooKeeper_branch34_jdk8 - Build # 1348 - Failure

2018-04-05 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch34_jdk8/1348/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 38.37 KB...] [junit] Running

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

2018-04-05 Thread Andor Molnar
Got that. I still believe it's a completely valid issue which has to be addressed, but it's not a showstopper. I'm afraid we're not going to convince each other, so it's probably Abe's call if he want to create another release candidate for the fix. I reviewed the code on github and I think it

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

2018-04-05 Thread Alexander Shraer
Btw we actually observed the described issue (data loss), thankfully in a test environment. So I thought this is important to share with the community. Unfortunately I don’t have time to run a new ZK release for this, so I’m not going to -1 your candidate, but we are actively working on a fix (ie

[GitHub] zookeeper issue #499: ZOOKEEPER-3017: Link libm in CMake on FreeBSD.

2018-04-05 Thread andschwa
Github user andschwa commented on the issue: https://github.com/apache/zookeeper/pull/499 LGTM. @hanm the build failure was spurious as this was a change to the CMake build. ---

[jira] [Commented] (ZOOKEEPER-3006) Potential NPE in ZKDatabase#calculateTxnLogSizeLimit

2018-04-05 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427958#comment-16427958 ] Hudson commented on ZOOKEEPER-3006: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #3790 (See

[jira] [Commented] (ZOOKEEPER-3006) Potential NPE in ZKDatabase#calculateTxnLogSizeLimit

2018-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427931#comment-16427931 ] ASF GitHub Bot commented on ZOOKEEPER-3006: --- Github user hanm commented on the issue:

[jira] [Commented] (ZOOKEEPER-3018) Ephemeral node not deleted after session is gone

2018-04-05 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426516#comment-16426516 ] Andor Molnar commented on ZOOKEEPER-3018: - [~danielchan] Thanks for opening this jira. It's

Success: ZOOKEEPER- PreCommit Build #1567

2018-04-05 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1567/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 78.47 MB...] [exec] +1

[jira] [Commented] (ZOOKEEPER-2983) Print the classpath when running compile and test ant targets

2018-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426729#comment-16426729 ] ASF GitHub Bot commented on ZOOKEEPER-2983: --- Github user mfenes commented on a diff in the

[GitHub] zookeeper pull request #469: ZOOKEEPER-2983: Print the classpath when runnin...

2018-04-05 Thread mfenes
Github user mfenes commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/469#discussion_r179420191 --- Diff: build.xml --- @@ -1861,4 +1861,18 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant"> + --- End

ZooKeeper_branch35_jdk8 - Build # 907 - Failure

2018-04-05 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/907/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 60.61 KB...] [junit] Running

[jira] [Commented] (ZOOKEEPER-2959) ignore accepted epoch and LEADERINFO ack from observers when a newly elected leader computes new epoch

2018-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426533#comment-16426533 ] ASF GitHub Bot commented on ZOOKEEPER-2959: --- Github user shralex commented on a diff in the

[jira] [Updated] (ZOOKEEPER-2959) ignore accepted epoch and LEADERINFO ack from observers when a newly elected leader computes new epoch

2018-04-05 Thread Alexander Shraer (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Shraer updated ZOOKEEPER-2959: Priority: Blocker (was: Major) > ignore accepted epoch and LEADERINFO ack from

[GitHub] zookeeper pull request #438: ZOOKEEPER-2959: ignore accepted epoch and LEADE...

2018-04-05 Thread shralex
Github user shralex commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/438#discussion_r179363930 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java --- @@ -1183,8 +1183,10 @@ public long getEpochToPropose(long sid, long

[jira] [Assigned] (ZOOKEEPER-2959) ignore accepted epoch and LEADERINFO ack from observers when a newly elected leader computes new epoch

2018-04-05 Thread Alexander Shraer (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Shraer reassigned ZOOKEEPER-2959: --- Assignee: Bogdan Kanivets > ignore accepted epoch and LEADERINFO ack

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

2018-04-05 Thread Ted Yu
Can the vote be closed ? It seems we have enough +1's Thanks

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

2018-04-05 Thread Alexander Shraer
Sorry for coming in at the last moment. I'm not sure when the next 3.4 release is scheduled, so just wanted to mention this bug, which I believe is a blocker for either this or next release: https://issues.apache.org/jira/browse/ZOOKEEPER-2959 Best, Alex On Thu, Apr 5, 2018 at 9:09 AM, Ted Yu

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

2018-04-05 Thread Alexander Shraer
To clarify - in a deployment with observers this bug can potentially cause data loss. A server could be elected leader based just on the support of observers, even if this servers data is stale wrt other followers. It is certainly a blocker, just not sure if for 3.4.11 or 3.4.12. Alex On Thu,

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

2018-04-05 Thread Andor Molnar
I don't think it's a blocker. The jira and PR has been open since last December and 3.4.11 has released without it. Although this bug is also important to fix, I believe it's more important to release a fix for the regression we've found in 3.4.11 asap. Abe, any thoughts? Regards, Andor On

[jira] [Resolved] (ZOOKEEPER-3006) Potential NPE in ZKDatabase#calculateTxnLogSizeLimit

2018-04-05 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han resolved ZOOKEEPER-3006. Resolution: Fixed Fix Version/s: 3.5.4 3.6.0 Issue resolved

[jira] [Commented] (ZOOKEEPER-3006) Potential NPE in ZKDatabase#calculateTxnLogSizeLimit

2018-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427912#comment-16427912 ] ASF GitHub Bot commented on ZOOKEEPER-3006: --- Github user asfgit closed the pull request at:

[GitHub] zookeeper pull request #493: ZOOKEEPER-3006: Potential NPE in ZKDatabase#cal...

2018-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/493 ---

[GitHub] zookeeper issue #493: ZOOKEEPER-3006: Potential NPE in ZKDatabase#calculateT...

2018-04-05 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/493 @edwardoliveira that's fine, I did not know that's you :-). Patch committed. ---

[jira] [Commented] (ZOOKEEPER-2959) ignore accepted epoch and LEADERINFO ack from observers when a newly elected leader computes new epoch

2018-04-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427413#comment-16427413 ] ASF GitHub Bot commented on ZOOKEEPER-2959: --- Github user anmolnar commented on a diff in the

[GitHub] zookeeper pull request #438: ZOOKEEPER-2959: ignore accepted epoch and LEADE...

2018-04-05 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/438#discussion_r179558826 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java --- @@ -1183,8 +1183,10 @@ public long getEpochToPropose(long sid, long

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

2018-04-05 Thread Andor Molnar
Maybe I'm missing something here, but this looks like a rare edge case to me. Participants must finish the leader election successfully and right after enough followers should fail to send epoch to the leader, so observers can take it over. Is that description accurate? Andor On Thu, Apr 5,

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

2018-04-05 Thread Alexander Shraer
Yes sort of, FLE is finished, then enough observer's messages reach the leader before participant's messages do. Whether its rare depends on the number of observers and participants. For example with very few participants and many observers your chance of hitting this are quite high. Alex On