Github user lavacat commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/500#discussion_r181001854
--- Diff: src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java
---
@@ -245,6 +245,180 @@ public void testLastAcceptedEpoch() throws Exception
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435149#comment-16435149
]
ASF GitHub Bot commented on ZOOKEEPER-2959:
---
Github user lavacat commented o
Github user lavacat commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/500#discussion_r181002193
--- Diff: src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java
---
@@ -245,6 +245,180 @@ public void testLastAcceptedEpoch() throws Exception
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435153#comment-16435153
]
ASF GitHub Bot commented on ZOOKEEPER-2959:
---
Github user lavacat commented o
Github user lavacat commented on the issue:
https://github.com/apache/zookeeper/pull/500
Moved these 3 new tests into new class - LeaderWithObserverTest. Had to
make createLeader and createQuorumPeer 'public static' in Zab1_0Test. Happy to
refactor into common base class
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435154#comment-16435154
]
ASF GitHub Bot commented on ZOOKEEPER-2959:
---
Github user lavacat commented o
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/500
@lavacat I think either moving these methods/classes to a base class or
creating a separate `ZabUtils` makes sense in this case to get cleaner code.
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435177#comment-16435177
]
ASF GitHub Bot commented on ZOOKEEPER-2959:
---
Github user anmolnar commented
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1571/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 39.74 MB...]
[exec] +1 java
GitHub user nkalmar opened a pull request:
https://github.com/apache/zookeeper/pull/501
ZOOKEEPER-3019 add metric for slow fsyncs count
Added metric to count fsyncWarningThresholdMS exceed in
FileTxnLog.commit(). Both jmx bean and Command can be used to get the stat.
Also u
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435275#comment-16435275
]
ASF GitHub Bot commented on ZOOKEEPER-3019:
---
GitHub user nkalmar opened a pu
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1572/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 79.28 MB...]
[exec] +1 java
See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/1439/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 60.23 KB...]
[junit] Tests run: 1, Failures: 0, Er
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435465#comment-16435465
]
ASF GitHub Bot commented on ZOOKEEPER-3019:
---
Github user anmolnar commented
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/501#discussion_r181060856
--- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
@@ -32,6 +32,7 @@
private long minLatency = Long.MAX_VALUE;
pri
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/501#discussion_r181059907
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -146,6 +149,16 @@ public FileTxnLog(File logDir) {
th
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435466#comment-16435466
]
ASF GitHub Bot commented on ZOOKEEPER-3019:
---
Github user anmolnar commented
Github user nkalmar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/501#discussion_r181063500
--- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
@@ -32,6 +32,7 @@
private long minLatency = Long.MAX_VALUE;
priv
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435474#comment-16435474
]
ASF GitHub Bot commented on ZOOKEEPER-3019:
---
Github user nkalmar commented o
Github user edwardoliveira commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/501#discussion_r181126991
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java ---
@@ -30,10 +30,8 @@
import org.apache.zookeeper.KeeperE
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435790#comment-16435790
]
ASF GitHub Bot commented on ZOOKEEPER-3019:
---
Github user edwardoliveira comm
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435787#comment-16435787
]
ASF GitHub Bot commented on ZOOKEEPER-3019:
---
Github user edwardoliveira comm
Github user edwardoliveira commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/501#discussion_r181129644
--- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
@@ -148,9 +150,23 @@ synchronized public void resetRequestCounters(){
Github user edwardoliveira commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/501#discussion_r181127170
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -135,6 +136,8 @@
long currentSize;
File lo
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435806#comment-16435806
]
ASF GitHub Bot commented on ZOOKEEPER-3019:
---
Github user edwardoliveira comm
Github user edwardoliveira commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/501#discussion_r181127430
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java ---
@@ -55,6 +53,7 @@
private final File snapDir;
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435791#comment-16435791
]
ASF GitHub Bot commented on ZOOKEEPER-3019:
---
Github user edwardoliveira comm
Github user edwardoliveira commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/501#discussion_r181134958
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java ---
@@ -55,6 +53,7 @@
private final File snapDir;
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435832#comment-16435832
]
ASF GitHub Bot commented on ZOOKEEPER-3019:
---
Github user edwardoliveira comm
Github user andschwa commented on the issue:
https://github.com/apache/zookeeper/pull/499
Yay @anmolnar the tests were flaky, last CI run was clean.
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435877#comment-16435877
]
ASF GitHub Bot commented on ZOOKEEPER-3017:
---
Github user andschwa commented
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1878/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 39.67 KB...]
[junit] Running org.apache.zoo
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435902#comment-16435902
]
ASF GitHub Bot commented on ZOOKEEPER-3017:
---
Github user anmolnar commented
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/499
@andschwa yeah, I've managed to run it locally fine.
---
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1573/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 77.84 MB...]
[exec] +1 java
Github user andschwa commented on the issue:
https://github.com/apache/zookeeper/pull/486
@anmolnar Yay! Flaky tests passed CI.
---
Github user nkalmar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/501#discussion_r181150889
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java ---
@@ -55,6 +53,7 @@
private final File snapDir;
pr
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435920#comment-16435920
]
ASF GitHub Bot commented on ZOOKEEPER-3019:
---
Github user nkalmar commented o
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435919#comment-16435919
]
ASF GitHub Bot commented on ZOOKEEPER-2999:
---
Github user andschwa commented
See https://builds.apache.org/job/ZooKeeper-trunk/3797/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 141.93 KB...]
[junit] Running org.apache.zookeeper.test
Github user lavacat commented on the issue:
https://github.com/apache/zookeeper/pull/500
@anmolnar added ZabUtils
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436644#comment-16436644
]
ASF GitHub Bot commented on ZOOKEEPER-2959:
---
Github user lavacat commented o
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1574/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 40.43 MB...]
[exec] +1 java
See https://builds.apache.org/job/ZooKeeper_branch34_jdk7/1881/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 38.40 KB...]
[junit] Running org.apache.zookeep
44 matches
Mail list logo