Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

2018-04-13 Thread Patrick Hunt
Hey folks. I've been on vacation. My 0.02 - given the release candidate is well underway, has sufficient votes/time to finalize, this is not a regression in 3.4.12 and it's not yet committed I would think we finalize/push 3.4.12 then quickly followup with a 3.4.13 that addresses this. Alex could

ZooKeeper_branch34_openjdk7 - Build # 1879 - Still Failing

2018-04-13 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1879/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 39.92 KB...] [junit] Running

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

2018-04-13 Thread Abraham Fine
Let's wait until the next release to include this fix. On Mon, Apr 9, 2018, at 15:14, Alexander Shraer wrote: > Hi, > > Please take a look on the new PR for ZK-2959: > https://github.com/apache/zookeeper/pull/500 > If there are no further comments, I can commit it. > > Thanks, > Alex > > On

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

2018-04-13 Thread Alexander Shraer
Now that we have the fix, why delay it to next release? On Fri, Apr 13, 2018 at 11:09 AM Abraham Fine wrote: > Let's wait until the next release to include this fix. > > On Mon, Apr 9, 2018, at 15:14, Alexander Shraer wrote: > > Hi, > > > > Please take a look on the new PR for

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

2018-04-13 Thread Abraham Fine
Given that the primary driver of this release is to fix an issue with the misuse of dataDir and dataLogDir I would rather see this release make it out the door with minimal additional changes to core functionality so people can more confidently upgrade. What do you think Pat? Abe On Fri,

ZooKeeper-trunk-openjdk7 - Build # 1864 - Failure

2018-04-13 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/1864/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 62.06 KB...] [junit] Tests run: 1, Failures:

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

2018-04-13 Thread Alexander Shraer
We discussed with Pat offline and agreed to go without this patch, especially since we need to patch 3 branches: 3.4, 3.5 and master. We'll prepare 3.5 and master and then commit all 3 together in time for the next release. So Abe, please go ahead with your release. Alex On Fri, Apr 13, 2018 at

[jira] [Commented] (ZOOKEEPER-3018) Ephemeral node not deleted after session is gone

2018-04-13 Thread Daniel C (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438140#comment-16438140 ] Daniel C commented on ZOOKEEPER-3018: - We have another incident of same issue reported. This

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

2018-04-13 Thread Abraham Fine
Thanks for following up Alex. On Fri, Apr 13, 2018, at 14:48, Alexander Shraer wrote: > We discussed with Pat offline and agreed to go without this patch, > especially since we need to patch 3 branches: 3.4, 3.5 and master.> We'll > prepare 3.5 and master and then commit all 3 together in time

[GitHub] zookeeper pull request #497: ZOOKEEPER-2415. SessionTest is using Thread dep...

2018-04-13 Thread phunt
Github user phunt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/497#discussion_r181525743 --- Diff: src/java/test/org/apache/zookeeper/test/SessionTimeoutTest.java --- @@ -0,0 +1,188 @@ +/** + * Licensed to the Apache Software Foundation

[jira] [Commented] (ZOOKEEPER-2415) SessionTest is using Thread deprecated API.

2018-04-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438034#comment-16438034 ] ASF GitHub Bot commented on ZOOKEEPER-2415: --- Github user phunt commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2415) SessionTest is using Thread deprecated API.

2018-04-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438036#comment-16438036 ] ASF GitHub Bot commented on ZOOKEEPER-2415: --- Github user phunt commented on a diff in the

[GitHub] zookeeper pull request #497: ZOOKEEPER-2415. SessionTest is using Thread dep...

2018-04-13 Thread phunt
Github user phunt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/497#discussion_r181526076 --- Diff: src/java/test/org/apache/zookeeper/test/SessionTimeoutTest.java --- @@ -0,0 +1,188 @@ +/** + * Licensed to the Apache Software Foundation

[jira] [Updated] (ZOOKEEPER-2994) Tool required to recover log and snapshot entries with CRC errors

2018-04-13 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-2994: Fix Version/s: 3.4.13 > Tool required to recover log and snapshot entries with CRC

[GitHub] zookeeper issue #487: ZOOKEEPER-2994 Tool required to recover log and snapsh...

2018-04-13 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/487 Looks promising - doesn't seem very useful (and potentially dangerous) without docs - perhaps add a troubleshooting or recovery section here?

[GitHub] zookeeper issue #476: ZOOKEEPER-2988: NPE triggered if server receives a vot...

2018-04-13 Thread enixon
Github user enixon commented on the issue: https://github.com/apache/zookeeper/pull/476 Made all changes requested in comments, I can alter the pull requests for the other ZooKeeper branches once we reach agreement on this one. ---

[jira] [Commented] (ZOOKEEPER-2988) NPE triggered if server receives a vote for a server id not in their voting view

2018-04-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436930#comment-16436930 ] ASF GitHub Bot commented on ZOOKEEPER-2988: --- Github user enixon commented on the issue:

Failed: ZOOKEEPER- PreCommit Build #1575

2018-04-13 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1575/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 74.32 MB...] [exec]

ZooKeeper_branch35_jdk7 - Build # 1355 - Failure

2018-04-13 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/1355/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 60.23 KB...] [junit] Tests run: 1, Failures:

Failed: ZOOKEEPER- PreCommit Build #1576

2018-04-13 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1576/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 77.04 MB...] [exec]

Failed: ZOOKEEPER- PreCommit Build #1577

2018-04-13 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1577/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 75.94 MB...] [exec]

Failed: ZOOKEEPER- PreCommit Build #1578

2018-04-13 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1578/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 77.28 MB...] [exec]

ZooKeeper_branch35_openjdk7 - Build # 910 - Failure

2018-04-13 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_openjdk7/910/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 61.29 KB...] [junit] Tests run: 1,