[jira] [Commented] (ZOOKEEPER-2959) ignore accepted epoch and LEADERINFO ack from observers when a newly elected leader computes new epoch

2018-04-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16447661#comment-16447661 ] Hadoop QA commented on ZOOKEEPER-2959: -- -1 overall. GitHub Pull Request Build +1

[jira] [Created] (ZOOKEEPER-3024) C++ Client return sub paths in String_vector illegal after zoo_get_children completed with ZOK

2018-04-23 Thread yijie (JIRA)
yijie created ZOOKEEPER-3024: Summary: C++ Client return sub paths in String_vector illegal after zoo_get_children completed with ZOK Key: ZOOKEEPER-3024 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3024

Failed: ZOOKEEPER- PreCommit Build #1619

2018-04-23 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1619/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 79.02 MB...] [exec]

[jira] [Updated] (ZOOKEEPER-3024) C++ Client return sub paths in String_vector illegal after zoo_get_children completed with ZOK

2018-04-23 Thread yijie (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yijie updated ZOOKEEPER-3024: - Description: we use  c++ client api: int zoo_get_children(zhandle_t *zh, const char *path, int

RE: [VOTE] Migrate ZK to Maven build

2018-04-23 Thread Mohammad arshad
+1 -Original Message- From: Andor Molnar [mailto:an...@cloudera.com] Sent: Monday, April 23, 2018 4:43 PM To: dev@zookeeper.apache.org Subject: Re: [VOTE] Migrate ZK to Maven build +1 (non-binding) On Mon, Apr 23, 2018 at 10:30 AM, Tamas Penzes wrote: > +1

Re: [VOTE] Migrate ZK to Maven build

2018-04-23 Thread Tamas Penzes
+1 (non-binding) On Fri, Apr 20, 2018 at 4:06 PM, Norbert Kalmar wrote: > Hi, > > Let's start a vote on migrating to maven instead of ant. > https://issues.apache.org/jira/browse/ZOOKEEPER-3021 > > *Shall we migrate ZooKeeper build from ant to Maven?* > > Please reply with

Re: [VOTE] Migrate ZK to Maven build

2018-04-23 Thread Andor Molnar
+1 (non-binding) On Mon, Apr 23, 2018 at 10:30 AM, Tamas Penzes wrote: > +1 (non-binding) > > On Fri, Apr 20, 2018 at 4:06 PM, Norbert Kalmar > wrote: > > > Hi, > > > > Let's start a vote on migrating to maven instead of ant. > >

Re: [VOTE] Migrate ZK to Maven build

2018-04-23 Thread Jordan Zimmerman
+1 (non binding) > On Apr 23, 2018, at 6:21 PM, Mohammad arshad > wrote: > > +1 > > -Original Message- > From: Andor Molnar [mailto:an...@cloudera.com] > Sent: Monday, April 23, 2018 4:43 PM > To: dev@zookeeper.apache.org > Subject: Re: [VOTE] Migrate ZK

Success: ZOOKEEPER- PreCommit Build #1620

2018-04-23 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1620/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 79.40 MB...] [exec] +1

ZooKeeper_branch35_jdk8 - Build # 928 - Still Failing

2018-04-23 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/928/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 3.51 KB...] at

[GitHub] zookeeper issue #466: ZOOKEEPER-2940. Deal with maxbuffer as it relates to l...

2018-04-23 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/466 @rakeshadr thanks, this is done. ---

[jira] [Updated] (ZOOKEEPER-3021) Umbrella: Migrate project structure to Maven build

2018-04-23 Thread Norbert Kalmar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar updated ZOOKEEPER-3021: -- Description: In multiple steps, Maven should replace current ant build in

[jira] [Updated] (ZOOKEEPER-3021) Umbrella: Migrate project structure to Maven build

2018-04-23 Thread Norbert Kalmar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar updated ZOOKEEPER-3021: -- Description: In multiple steps, Maven should replace current ant build in

Re: [SUGGESTION] Migrate project structure to Maven build

2018-04-23 Thread Norbert Kalmar
Hi @maoling To answer your questions: 1. Yes, we should strive to keep the current end artifact structure. The end jar for example shouldn't change. 2. I think nothing really changes in this matter. If there are uncommitted changes after some refactor, it will have to be rebased or resolved some

[jira] [Commented] (ZOOKEEPER-2940) Deal with maxbuffer as it relates to large requests from clients

2018-04-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448008#comment-16448008 ] Hadoop QA commented on ZOOKEEPER-2940: -- +1 overall. GitHub Pull Request Build +1

[jira] [Commented] (ZOOKEEPER-1260) Audit logging in ZooKeeper servers.

2018-04-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448028#comment-16448028 ] Hadoop QA commented on ZOOKEEPER-1260: -- -1 overall. Here are the results of testing the latest

[GitHub] zookeeper issue #338: ZOOKEEPER-1260:Audit logging in ZooKeeper servers.

2018-04-23 Thread pmoust
Github user pmoust commented on the issue: https://github.com/apache/zookeeper/pull/338 @arshadmohammad I'd also be curious as to the perf implications of this, have you run a load test-suite against this? ---

[jira] [Commented] (ZOOKEEPER-1260) Audit logging in ZooKeeper servers.

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448022#comment-16448022 ] ASF GitHub Bot commented on ZOOKEEPER-1260: --- Github user pmoust commented on the issue:

Failed: ZOOKEEPER-1260 PreCommit Build #3665

2018-04-23 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1260 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3665/ ### ## LAST 60 LINES OF THE CONSOLE ###

[jira] [Commented] (ZOOKEEPER-2940) Deal with maxbuffer as it relates to large requests from clients

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448023#comment-16448023 ] ASF GitHub Bot commented on ZOOKEEPER-2940: --- Github user anmolnar commented on the issue:

[jira] [Updated] (ZOOKEEPER-3022) Step 1 to maven - Separate project structure

2018-04-23 Thread Norbert Kalmar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar updated ZOOKEEPER-3022: -- Description: Create a project structure that separates the different parts of

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

2018-04-23 Thread Flavio Junqueira
+1, verified the following: - checksums and signature - build passes - rat tool output does not indicate any problem - LICENSE and NOTICE look both ok - local simple smoke tests work -Flavio > On 2 Apr 2018, at 02:01, Michael Han wrote: > > +1 > > - verified xsum/sig. > -

Re: [VOTE] Migrate ZK to Maven build

2018-04-23 Thread Karan Mehta
+1 (non binding) Thanks Karan Mehta On Mon, Apr 23, 2018 at 4:06 AM Jordan Zimmerman wrote: > +1 (non binding) > > > On Apr 23, 2018, at 6:21 PM, Mohammad arshad > wrote: > > > > +1 > > > > -Original Message- > > From: Andor

[GitHub] zookeeper pull request #338: ZOOKEEPER-1260:Audit logging in ZooKeeper serve...

2018-04-23 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/338#discussion_r183433194 --- Diff: src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java --- @@ -250,30 +267,36 @@ public void processRequest(Request request) {

[GitHub] zookeeper pull request #338: ZOOKEEPER-1260:Audit logging in ZooKeeper serve...

2018-04-23 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/338#discussion_r183435384 --- Diff: src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java --- @@ -465,6 +488,127 @@ public void processRequest(Request request) {

[jira] [Commented] (ZOOKEEPER-1260) Audit logging in ZooKeeper servers.

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448307#comment-16448307 ] ASF GitHub Bot commented on ZOOKEEPER-1260: --- Github user anmolnar commented on a diff in the

[jira] [Commented] (ZOOKEEPER-1260) Audit logging in ZooKeeper servers.

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448308#comment-16448308 ] ASF GitHub Bot commented on ZOOKEEPER-1260: --- Github user anmolnar commented on a diff in the

[jira] [Commented] (ZOOKEEPER-1260) Audit logging in ZooKeeper servers.

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448309#comment-16448309 ] ASF GitHub Bot commented on ZOOKEEPER-1260: --- Github user anmolnar commented on a diff in the

[jira] [Commented] (ZOOKEEPER-1260) Audit logging in ZooKeeper servers.

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448310#comment-16448310 ] ASF GitHub Bot commented on ZOOKEEPER-1260: --- Github user anmolnar commented on a diff in the

[jira] [Commented] (ZOOKEEPER-1260) Audit logging in ZooKeeper servers.

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448311#comment-16448311 ] ASF GitHub Bot commented on ZOOKEEPER-1260: --- Github user anmolnar commented on a diff in the

[GitHub] zookeeper pull request #338: ZOOKEEPER-1260:Audit logging in ZooKeeper serve...

2018-04-23 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/338#discussion_r183432327 --- Diff: src/java/main/org/apache/zookeeper/audit/ZKAuditLogger.java --- @@ -0,0 +1,117 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #338: ZOOKEEPER-1260:Audit logging in ZooKeeper serve...

2018-04-23 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/338#discussion_r183430034 --- Diff: src/java/main/org/apache/zookeeper/ZKUtil.java --- @@ -168,4 +169,41 @@ private static void visitSubTreeDFSHelper(ZooKeeper zk, final String

[GitHub] zookeeper pull request #338: ZOOKEEPER-1260:Audit logging in ZooKeeper serve...

2018-04-23 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/338#discussion_r183434909 --- Diff: src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java --- @@ -465,6 +488,127 @@ public void processRequest(Request request) {

Apache ZooKeeper meetup May 9th in Palo Alto?

2018-04-23 Thread Patrick Hunt
Hi folks. I am interested in hosting a ZooKeeper meetup May 9th in Cloudera's Palo Alto offices. It's been a while since we last got together, lots of recent changes and some big plans, new additions to the PMC and committer lists, new contributors. I was hoping to use the mailing lists to gauge

Move github discussions from JIRA comments to the JIRA worklog?

2018-04-23 Thread Patrick Hunt
Hey devs, I noticed this recently filed by the Apache Arrow team: "Change GitHub Bot to post to Work Log instead of Comments" https://issues.apache.org/jira/browse/INFRA-16426 which really resonates with me - I'm finding that the JIRA comments are being lost amongst the github updates related to

[jira] [Commented] (ZOOKEEPER-2940) Deal with maxbuffer as it relates to large requests from clients

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449033#comment-16449033 ] ASF GitHub Bot commented on ZOOKEEPER-2940: --- Github user phunt commented on a diff in the

[jira] [Commented] (ZOOKEEPER-3025) cmake windows build is broken on jenkins

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449086#comment-16449086 ] ASF GitHub Bot commented on ZOOKEEPER-3025: --- Github user asfgit closed the pull request at:

[jira] [Created] (ZOOKEEPER-3025) cmake windows build is broken on jenkins

2018-04-23 Thread Patrick Hunt (JIRA)
Patrick Hunt created ZOOKEEPER-3025: --- Summary: cmake windows build is broken on jenkins Key: ZOOKEEPER-3025 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3025 Project: ZooKeeper

ZooKeeper-trunk-windows-cmake - Build # 2726 - Still Failing

2018-04-23 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-windows-cmake/2726/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 18.44 KB...] Creating

[GitHub] zookeeper pull request #487: ZOOKEEPER-2994 Tool required to recover log and...

2018-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/487 ---

[jira] [Assigned] (ZOOKEEPER-3025) cmake windows build is broken on jenkins

2018-04-23 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt reassigned ZOOKEEPER-3025: --- Assignee: Michael Han [~hanm] - could you take a look at this issue? Seems to be

[jira] [Commented] (ZOOKEEPER-2994) Tool required to recover log and snapshot entries with CRC errors

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448961#comment-16448961 ] ASF GitHub Bot commented on ZOOKEEPER-2994: --- Github user asfgit closed the pull request at:

[jira] [Resolved] (ZOOKEEPER-2994) Tool required to recover log and snapshot entries with CRC errors

2018-04-23 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt resolved ZOOKEEPER-2994. - Resolution: Fixed Fix Version/s: (was: 3.4.13) Issue resolved by pull

[jira] [Updated] (ZOOKEEPER-2994) Tool required to recover log and snapshot entries with CRC errors

2018-04-23 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-2994: Affects Version/s: 3.6.0 3.5.4 > Tool required to recover log

[jira] [Commented] (ZOOKEEPER-2994) Tool required to recover log and snapshot entries with CRC errors

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448975#comment-16448975 ] ASF GitHub Bot commented on ZOOKEEPER-2994: --- Github user phunt commented on the issue:

[GitHub] zookeeper pull request #501: ZOOKEEPER-3019 add metric for slow fsyncs count

2018-04-23 Thread phunt
Github user phunt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/501#discussion_r183571986 --- Diff: docs/zookeeperAdmin.html --- @@ -2213,6 +2213,7 @@ The Four Letter Words zk_min_latency 0

[jira] [Commented] (ZOOKEEPER-3019) Add a metric to track number of slow fsyncs

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449062#comment-16449062 ] ASF GitHub Bot commented on ZOOKEEPER-3019: --- Github user phunt commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2979) Use dropwizard library histogram for proposal-related metrics

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449004#comment-16449004 ] ASF GitHub Bot commented on ZOOKEEPER-2979: --- Github user phunt commented on the issue:

[GitHub] zookeeper pull request #466: ZOOKEEPER-2940. Deal with maxbuffer as it relat...

2018-04-23 Thread phunt
Github user phunt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/466#discussion_r183565978 --- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml --- @@ -1897,6 +1896,12 @@ server.3=zoo3:2888:3888 zk_pending_syncs

[jira] [Commented] (ZOOKEEPER-2940) Deal with maxbuffer as it relates to large requests from clients

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449031#comment-16449031 ] ASF GitHub Bot commented on ZOOKEEPER-2940: --- Github user phunt commented on a diff in the

[GitHub] zookeeper pull request #466: ZOOKEEPER-2940. Deal with maxbuffer as it relat...

2018-04-23 Thread phunt
Github user phunt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/466#discussion_r183565848 --- Diff: src/contrib/monitoring/ganglia/zookeeper_ganglia.py --- @@ -213,7 +213,13 @@ def metric_init(params=None):

[jira] [Assigned] (ZOOKEEPER-3000) Use error-prone compiler

2018-04-23 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt reassigned ZOOKEEPER-3000: --- Assignee: Roman Leventov > Use error-prone compiler > >

[GitHub] zookeeper pull request #505: ZOOKEEPER-3025: Make `hashtable` search `includ...

2018-04-23 Thread andschwa
GitHub user andschwa opened a pull request: https://github.com/apache/zookeeper/pull/505 ZOOKEEPER-3025: Make `hashtable` search `include` When ZOOKEEPER-2999 removed the directory side-effect of `include_directories(include)`, and added it as a target-level include to the

[jira] [Commented] (ZOOKEEPER-2983) Print the classpath when running compile and test ant targets

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449077#comment-16449077 ] ASF GitHub Bot commented on ZOOKEEPER-2983: --- Github user phunt commented on the issue:

[jira] [Updated] (ZOOKEEPER-2415) SessionTest is using Thread deprecated API.

2018-04-23 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-2415: Fix Version/s: 3.4.13 3.6.0 3.5.4 > SessionTest

[GitHub] zookeeper issue #497: ZOOKEEPER-2415. SessionTest is using Thread deprecated...

2018-04-23 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/497 +1. Looks reasonable however: 1) this problem also exists in src/java/test/org/apache/zookeeper/test/ReadOnlyModeTest.java - do you want to fix it as part of this change or handle as a

[jira] [Commented] (ZOOKEEPER-2415) SessionTest is using Thread deprecated API.

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448991#comment-16448991 ] ASF GitHub Bot commented on ZOOKEEPER-2415: --- Github user phunt commented on the issue:

ZooKeeper-trunk-windows-cmake - Build # 2727 - Still Failing

2018-04-23 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-windows-cmake/2727/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 18.50 KB...] Creating

[jira] [Commented] (ZOOKEEPER-3025) cmake windows build is broken on jenkins

2018-04-23 Thread Andrew Schwartzmeyer (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449039#comment-16449039 ] Andrew Schwartzmeyer commented on ZOOKEEPER-3025: - Ah, my bad. Turns out to be caused

[jira] [Commented] (ZOOKEEPER-3000) Use error-prone compiler

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449059#comment-16449059 ] ASF GitHub Bot commented on ZOOKEEPER-3000: --- Github user phunt commented on the issue:

[GitHub] zookeeper issue #490: ZOOKEEPER-3000: Use error-prone compiler

2018-04-23 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/490 This is a good addition, thanks for bringing to our attention @leventov . Unfortunately however we can't replace the std javac compiler with error_prone in the toolchain outright - we can

[jira] [Updated] (ZOOKEEPER-3019) Add a metric to track number of slow fsyncs

2018-04-23 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-3019: Affects Version/s: 3.6.0 > Add a metric to track number of slow fsyncs >

[jira] [Updated] (ZOOKEEPER-3019) Add a metric to track number of slow fsyncs

2018-04-23 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-3019: Fix Version/s: 3.4.13 3.6.0 3.5.4 > Add a metric

[GitHub] zookeeper pull request #501: ZOOKEEPER-3019 add metric for slow fsyncs count

2018-04-23 Thread phunt
Github user phunt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/501#discussion_r183573019 --- Diff: src/java/test/org/apache/zookeeper/test/FourLetterWordsTest.java --- @@ -167,6 +167,8 @@ public void testValidateStatOutput() throws Exception {

[jira] [Commented] (ZOOKEEPER-3019) Add a metric to track number of slow fsyncs

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449066#comment-16449066 ] ASF GitHub Bot commented on ZOOKEEPER-3019: --- Github user phunt commented on a diff in the

[GitHub] zookeeper issue #501: ZOOKEEPER-3019 add metric for slow fsyncs count

2018-04-23 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/501 Can we get this into 3.4 as well? ---

[jira] [Commented] (ZOOKEEPER-3025) cmake windows build is broken on jenkins

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449068#comment-16449068 ] ASF GitHub Bot commented on ZOOKEEPER-3025: --- Github user andschwa commented on the issue:

[GitHub] zookeeper issue #505: ZOOKEEPER-3025: Make `hashtable` search `include`

2018-04-23 Thread andschwa
Github user andschwa commented on the issue: https://github.com/apache/zookeeper/pull/505 Built successfully both in-tree and out-of-tree on Windows using the VS generator, also successfully built with the Ninja generator 😉 ---

[jira] [Commented] (ZOOKEEPER-3019) Add a metric to track number of slow fsyncs

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449069#comment-16449069 ] ASF GitHub Bot commented on ZOOKEEPER-3019: --- Github user phunt commented on the issue:

[jira] [Assigned] (ZOOKEEPER-3025) cmake windows build is broken on jenkins

2018-04-23 Thread Andrew Schwartzmeyer (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schwartzmeyer reassigned ZOOKEEPER-3025: --- Assignee: Andrew Schwartzmeyer (was: Michael Han) > cmake

[GitHub] zookeeper issue #469: ZOOKEEPER-2983: Print the classpath when running compi...

2018-04-23 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/469 @mfenes @anmolnar @afine - ant already has a -d and a -v option, why do we need to add additional? Is it really necessary that all the builds include this information? Why is -d/-v not

[GitHub] zookeeper issue #505: ZOOKEEPER-3025: Make `hashtable` search `include`

2018-04-23 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/505 +1. Thanks @andschwa ---

[jira] [Updated] (ZOOKEEPER-2999) CMake build should use target-level commands

2018-04-23 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-2999: Affects Version/s: 3.5.4 > CMake build should use target-level commands >

[jira] [Resolved] (ZOOKEEPER-3025) cmake windows build is broken on jenkins

2018-04-23 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt resolved ZOOKEEPER-3025. - Resolution: Fixed Hadoop Flags: Reviewed The patch fixed it, jenkins is green

[jira] [Commented] (ZOOKEEPER-3025) cmake windows build is broken on jenkins

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449090#comment-16449090 ] ASF GitHub Bot commented on ZOOKEEPER-3025: --- Github user phunt commented on the issue:

ZooKeeper-trunk - Build # 3812 - Still Failing

2018-04-23 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk/3812/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 146.00 KB...] at

[jira] [Updated] (ZOOKEEPER-3000) Use error-prone compiler

2018-04-23 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-3000: Affects Version/s: 3.6.0 3.5.4 > Use error-prone compiler >

ZooKeeper-trunk - Build # 3811 - Still Failing

2018-04-23 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk/3811/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 143.60 KB...] [junit] Running

ZooKeeper_branch35_jdk8 - Build # 930 - Failure

2018-04-23 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/930/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 60.24 KB...] [junit] Tests run: 1, Failures: 0,

[jira] [Updated] (ZOOKEEPER-3000) Use error-prone compiler

2018-04-23 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-3000: Fix Version/s: 3.6.0 3.5.4 > Use error-prone compiler >

[jira] [Commented] (ZOOKEEPER-2994) Tool required to recover log and snapshot entries with CRC errors

2018-04-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449043#comment-16449043 ] Hudson commented on ZOOKEEPER-2994: --- FAILURE: Integrated in Jenkins build ZooKeeper-trunk #3810 (See

[jira] [Commented] (ZOOKEEPER-3025) cmake windows build is broken on jenkins

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449064#comment-16449064 ] ASF GitHub Bot commented on ZOOKEEPER-3025: --- GitHub user andschwa opened a pull request:

Failed: ZOOKEEPER- PreCommit Build #1621

2018-04-23 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1621/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 79.48 MB...] [exec]

[jira] [Commented] (ZOOKEEPER-3025) cmake windows build is broken on jenkins

2018-04-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449082#comment-16449082 ] Hadoop QA commented on ZOOKEEPER-3025: -- -1 overall. GitHub Pull Request Build +1

[GitHub] zookeeper pull request #505: ZOOKEEPER-3025: Make `hashtable` search `includ...

2018-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/505 ---

[jira] [Commented] (ZOOKEEPER-2982) Re-try DNS hostname -> IP resolution

2018-04-23 Thread Eron Wright (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448996#comment-16448996 ] Eron Wright commented on ZOOKEEPER-2982: - [~fpj] would you please assign this issue to

[GitHub] zookeeper issue #487: ZOOKEEPER-2994 Tool required to recover log and snapsh...

2018-04-23 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/487 +1 Thanks @anmolnar this looks good. Please consider backporting to 3.4 (separate jira). Also in future please don't include any changed files from the toplevel docs directory (html/pdf

[GitHub] zookeeper issue #440: ZOOKEEPER-2979 Use dropwizard library histogram for pr...

2018-04-23 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/440 @anmolnar I believe you misunderstood my comment above: > likely this change will go into master (3.6.0+) - impact on backports. I'm assuming we would want to take advantage of this library

[GitHub] zookeeper issue #466: ZOOKEEPER-2940. Deal with maxbuffer as it relates to l...

2018-04-23 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/466 is this intended for 3.4 or just 3.5+ ? The jira says 3.5+, is that right? ---

[jira] [Commented] (ZOOKEEPER-2940) Deal with maxbuffer as it relates to large requests from clients

2018-04-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449020#comment-16449020 ] ASF GitHub Bot commented on ZOOKEEPER-2940: --- Github user phunt commented on the issue:

[jira] [Commented] (ZOOKEEPER-3025) cmake windows build is broken on jenkins

2018-04-23 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449084#comment-16449084 ] Patrick Hunt commented on ZOOKEEPER-3025: - No worries at all [~andschwa] - I'll take a look at

[jira] [Commented] (ZOOKEEPER-3025) cmake windows build is broken on jenkins

2018-04-23 Thread Andrew Schwartzmeyer (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449109#comment-16449109 ] Andrew Schwartzmeyer commented on ZOOKEEPER-3025: - No problem [~phunt]! I am very glad

ZooKeeper_branch35_jdk8 - Build # 931 - Still Failing

2018-04-23 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/931/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 60.28 KB...] [junit] Tests run: 1, Failures: 0,

ZooKeeper-trunk - Build # 3813 - Still Failing

2018-04-23 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk/3813/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 11.24 KB...] at

ZooKeeper-trunk - Build # 3815 - Still Failing

2018-04-23 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk/3815/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 258.26 KB...] [exec] Log Message Received:

[jira] [Commented] (ZOOKEEPER-3025) cmake windows build is broken on jenkins

2018-04-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449270#comment-16449270 ] Hudson commented on ZOOKEEPER-3025: --- FAILURE: Integrated in Jenkins build ZooKeeper-trunk #3815 (See

ZooKeeper-trunk - Build # 3814 - Still Failing

2018-04-23 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk/3814/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 11.24 KB...] at