[GitHub] zookeeper pull request #561: ZOOKEEPER-3083: Remove some redundant and noisy...

2018-07-18 Thread enixon
Github user enixon commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/561#discussion_r203522048 --- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java --- @@ -754,7 +754,7 @@ public void finishSessionInit(ServerCnxn cnxn, boolean

[GitHub] zookeeper pull request #561: ZOOKEEPER-3083: Remove some redundant and noisy...

2018-07-18 Thread enixon
Github user enixon commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/561#discussion_r203522485 --- Diff: src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java --- @@ -817,10 +817,12 @@ protected void pRequest(Request request) throws

ZooKeeper_branch35_jdk8 - Build # 1044 - Still Failing

2018-07-18 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1044/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 11.09 KB...] at

Success: ZOOKEEPER- PreCommit Build #1960

2018-07-18 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1960/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 72.21 MB...] [exec] +1

Trying to find pattern in Flaky Tests

2018-07-18 Thread Andor Molnar
Hi, *branch-3.4* I've taken a quick look at our Jenkins builds and in terms of flaky tests, it looks like branch-3.4 is in a pretty good shape. The build hasn't failed for 5-6 days on all JDKs which I think is pretty awesome. *branch-3.5* This branch is in very bad condition. Which is quite

ZK ACL question

2018-07-18 Thread William Jardine
Hey guys, I'm using ZooKeeper and am curious about how it stores its ACL identities created with the digest scheme, and am a bit confused by the website. Hoping you can help me. For example, if I do:# - addauth digest testuser1:password1 - setAcl /testnode auth:testuser1:password1:w This

[jira] [Updated] (ZOOKEEPER-3037) Add JvmPauseMonitor to ZooKeeper

2018-07-18 Thread Norbert Kalmar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar updated ZOOKEEPER-3037: -- Description: After a ZK crash, or client timeout sometimes it's hard to determine

can we deprecated myid file?

2018-07-18 Thread 岭秀
Hi zk guys: maoling Beijing,China When use zk in distributional model,we need to touch a myid file in dataDir.then write a unique number to it.It is inconvenient and not user-friendly, it has a special usage which I don't know?Look at an example from other distribution system such as kafka:it

[GitHub] zookeeper issue #547: ZOOKEEPER-3068: Improve C client logging of IPv6 hosts

2018-07-18 Thread enixon
Github user enixon commented on the issue: https://github.com/apache/zookeeper/pull/547 Fixed the merge conflict - this is gtg ---

Re: Trying to find pattern in Flaky Tests

2018-07-18 Thread Patrick Hunt
FYI, created this: https://issues.apache.org/jira/browse/INFRA-16785 for the security warnings, not sure if that's causing the issue. Likely it's the recent jenkins upgrade, looking into it a bit... Patrick On Wed, Jul 18, 2018 at 9:48 AM Michael Han wrote: > Hi Andor, > > >> I suspect it

[jira] [Commented] (ZOOKEEPER-3092) Pluggable metrics system for ZooKeeper

2018-07-18 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548168#comment-16548168 ] Michael Han commented on ZOOKEEPER-3092: [~revans2] Thank you for your feedback.  >

[GitHub] zookeeper pull request #560: ZOOKEEPER-3082: Fix server snapshot behavior wh...

2018-07-18 Thread enixon
Github user enixon commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/560#discussion_r203474532 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java --- @@ -399,8 +399,30 @@ public void save(DataTree dataTree,

[GitHub] zookeeper pull request #572: ZOOKEEPER-3085 define exit codes in enum

2018-07-18 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/572#discussion_r203477408 --- Diff: src/java/main/org/apache/zookeeper/server/ExitCode.java --- @@ -20,8 +20,35 @@ /** * Exit code used to exit server */

[GitHub] zookeeper pull request #572: ZOOKEEPER-3085 define exit codes in enum

2018-07-18 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/572#discussion_r203478133 --- Diff: src/java/main/org/apache/zookeeper/server/ExitCode.java --- @@ -20,8 +20,35 @@ /** * Exit code used to exit server */

ZooKeeper-trunk - Build # 108 - Still Failing

2018-07-18 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk/108/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 142.92 KB...] [junit] Tests run: 1, Failures: 0,

[jira] [Commented] (ZOOKEEPER-3074) Flaky test:org.apache.zookeeper.server.ServerStatsTest.testLatencyMetrics

2018-07-18 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548195#comment-16548195 ] Hudson commented on ZOOKEEPER-3074: --- FAILURE: Integrated in Jenkins build ZooKeeper-trunk #108 (See

[jira] [Commented] (ZOOKEEPER-3068) Improve C client logging of IPv6 hosts

2018-07-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548189#comment-16548189 ] Hadoop QA commented on ZOOKEEPER-3068: -- +1 overall. GitHub Pull Request Build +1

[jira] [Commented] (ZOOKEEPER-3092) Pluggable metrics system for ZooKeeper

2018-07-18 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548197#comment-16548197 ] Michael Han commented on ZOOKEEPER-3092: [~eolivelli] I think this work does not depend on

[GitHub] zookeeper issue #572: ZOOKEEPER-3085 define exit codes in enum

2018-07-18 Thread lvfangmin
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/572 @nkalmar the [TxnLogToolkit](https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/persistence/TxnLogToolkit.java) also has some hard-coded exit code, if

Success: ZOOKEEPER- PreCommit Build #1963

2018-07-18 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1963/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 84.62 MB...] [exec] +1

Re: Trying to find pattern in Flaky Tests

2018-07-18 Thread Patrick Hunt
Ok, I committed a change that seems to address the main failure: https://github.com/apache/zookeeper/commit/06b9507ab78a1a055b8f467846c15791600b72ee https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-Find-Flaky-Tests/lastSuccessfulBuild/artifact/report.html However I do notice some

[jira] [Commented] (ZOOKEEPER-3092) Pluggable metrics system for ZooKeeper

2018-07-18 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548243#comment-16548243 ] Enrico Olivelli commented on ZOOKEEPER-3092: For me it is okay to have a zookkeeper

[jira] [Commented] (ZOOKEEPER-3085) Define constant exit code and add documents

2018-07-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547616#comment-16547616 ] Hadoop QA commented on ZOOKEEPER-3085: -- -1 overall. GitHub Pull Request Build +1

Re: Trying to find pattern in Flaky Tests

2018-07-18 Thread Michael Han
Hi Andor, >> I suspect it should succeed eventually if we were to increase the timeout even more. But is that correct? Bug or infrastructure issue? You could set up a dedicated git branch with all patches (e.g. the one in ZOOKEEPER-2251) you want to apply and I can set up a dedicated Jenkins job

[GitHub] zookeeper issue #563: ZOOKEEPER-3072: Throttle race condition fix

2018-07-18 Thread bothejjms
Github user bothejjms commented on the issue: https://github.com/apache/zookeeper/pull/563 I have removed the test for now as I don't have a good way to test this race condition. I can be reproduced easily by starting a server where the globalOutstandingLimit is 1 and sending a lot

[jira] [Commented] (ZOOKEEPER-3072) Race condition in throttling

2018-07-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548115#comment-16548115 ] Hadoop QA commented on ZOOKEEPER-3072: -- -1 overall. GitHub Pull Request Build +1

Failed: ZOOKEEPER- PreCommit Build #1962

2018-07-18 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1962/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 84.13 MB...] [exec]

ZooKeeper_branch35_jdk8 - Build # 1045 - Still Failing

2018-07-18 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1045/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 62.08 KB...] [junit] Running

[GitHub] zookeeper issue #557: ZOOKEEPER-3077: build outside of source directory

2018-07-18 Thread lvfangmin
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/557 +1 this looks good to me. ---

[jira] [Updated] (ZOOKEEPER-3093) sync zerror(int rc) with newest error definitions

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3093: -- Labels: pull-request-available (was: ) > sync zerror(int rc) with newest error

[GitHub] zookeeper issue #575: Zookeeper 3093

2018-07-18 Thread lvfangmin
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/575 +1 If you have ZOOKEEPER-3093 in title, the pull request will auto linked to the jira. ---

Re: can we deprecated myid file?

2018-07-18 Thread Michael Han
I don't think myid has any special usage aside from providing a stable identifier - see some history here: https://markmail.org/message/cvzz3tq3gievicqe I suggest create a JIRA to make a proposal if there are better approaches. On Wed, Jul 18, 2018 at 12:02 AM, 岭秀 wrote: > Hi zk guys: >

[jira] [Commented] (ZOOKEEPER-3083) Remove some redundant and noisy log lines

2018-07-18 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548793#comment-16548793 ] Hudson commented on ZOOKEEPER-3083: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #110 (See

[jira] [Resolved] (ZOOKEEPER-3083) Remove some redundant and noisy log lines

2018-07-18 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han resolved ZOOKEEPER-3083. Resolution: Fixed Fix Version/s: 3.5.5 3.6.0 Issue resolved

[GitHub] zookeeper pull request #561: ZOOKEEPER-3083: Remove some redundant and noisy...

2018-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/561 ---

[GitHub] zookeeper issue #561: ZOOKEEPER-3083: Remove some redundant and noisy log li...

2018-07-18 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/561 Jenkins complained about a flaky test. LGTM overall. Committed. ---

Re: Trying to find pattern in Flaky Tests

2018-07-18 Thread Michael Han
Thanks Pat for promptly fixing this! I have no idea of the "failed to get" symptoms. Probably we could give it more days and see if the pattern recurs? If not might be a transient infra issue... On Wed, Jul 18, 2018 at 11:16 AM, Patrick Hunt wrote: > Ok, I committed a change that seems to

Failed: ZOOKEEPER- PreCommit Build #1965

2018-07-18 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1965/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 77.80 MB...] [exec]

[jira] [Commented] (ZOOKEEPER-3083) Remove some redundant and noisy log lines

2018-07-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548395#comment-16548395 ] Hadoop QA commented on ZOOKEEPER-3083: -- -1 overall. GitHub Pull Request Build +1

[GitHub] zookeeper pull request #575: Zookeeper 3093

2018-07-18 Thread sl4mmy
GitHub user sl4mmy opened a pull request: https://github.com/apache/zookeeper/pull/575 Zookeeper 3093 I noticed that zerror(ZNOWATCHER) returns "unknown error" and when I went to investigate why I realized that actually three new values were added to ZOO_ERRORS enum without

[jira] [Commented] (ZOOKEEPER-3093) sync zerror(int rc) with newest error definitions

2018-07-18 Thread Kent R. Spillner (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548353#comment-16548353 ] Kent R. Spillner commented on ZOOKEEPER-3093: - Created GitHub PR 

Success: ZOOKEEPER- PreCommit Build #1964

2018-07-18 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1964/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 78.08 MB...] [exec]

[jira] [Created] (ZOOKEEPER-3093) sync zerror(int rc) with newest error definitions

2018-07-18 Thread Kent R. Spillner (JIRA)
Kent R. Spillner created ZOOKEEPER-3093: --- Summary: sync zerror(int rc) with newest error definitions Key: ZOOKEEPER-3093 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3093 Project:

[GitHub] zookeeper issue #557: ZOOKEEPER-3077: build outside of source directory

2018-07-18 Thread sl4mmy
Github user sl4mmy commented on the issue: https://github.com/apache/zookeeper/pull/557 No takers? :) I know this touches nasty autoconf stuff, but in my opinion it's actually simple & straight-forward: * At present you cannot build the native client in a separate

Failed: ZOOKEEPER- PreCommit Build #1959

2018-07-18 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1959/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 73.52 MB...] [exec]

[jira] [Commented] (ZOOKEEPER-3085) Define constant exit code and add documents

2018-07-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547829#comment-16547829 ] Hadoop QA commented on ZOOKEEPER-3085: -- +1 overall. GitHub Pull Request Build +1

[jira] [Commented] (ZOOKEEPER-3092) Pluggable metrics system for ZooKeeper

2018-07-18 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547844#comment-16547844 ] Robert Joseph Evans commented on ZOOKEEPER-3092: +1 This is something that I had a

[jira] [Commented] (ZOOKEEPER-3092) Pluggable metrics system for ZooKeeper

2018-07-18 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547850#comment-16547850 ] Enrico Olivelli commented on ZOOKEEPER-3092: It would be great to have the new mavenized

Failed: ZOOKEEPER- PreCommit Build #1961

2018-07-18 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1961/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 6.54 KB...] [exec]

[GitHub] zookeeper pull request #556: ZOOKEEPER-3074:Flaky test:org.apache.zookeeper....

2018-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/556 ---

[jira] [Resolved] (ZOOKEEPER-3074) Flaky test:org.apache.zookeeper.server.ServerStatsTest.testLatencyMetrics

2018-07-18 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-3074. - Resolution: Fixed Fix Version/s: 3.5.5 3.6.0 Issue

[GitHub] zookeeper issue #556: ZOOKEEPER-3074:Flaky test:org.apache.zookeeper.server....

2018-07-18 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/556 Merged to 3.5 and master branches. Thanks @maoling ! ---