Re: ZooKeeper 3.5 blocker issues

2018-09-13 Thread Fangmin Lv
And to be clear, ZOOKEEPER-2418 is actually just one case of inconsistency which could caused by on disk txn sync, as I mentioned in a newer JIRA ZOOKEEPER-2846 , the snap sync or txn sync could also leave txns gap in the txn file, which is a

Re: Java version (Oracle - OpenJDK) support

2018-09-13 Thread Enrico Olivelli
Il gio 13 set 2018, 01:00 Patrick Hunt ha scritto: > Historically we've always defined a minimum version and let users decide. > That seems to have worked pretty well. It provides the most flexibility and > hasn't really bothered us too much. It limits our use of new language > features of Java,

Re: Java version (Oracle - OpenJDK) support

2018-09-13 Thread Andor Molnar
Hi team, Let me quickly summarise what we’re trying to resolve on this thread. Problem #1: due to Oracle licensing changes people are expected to move away from Oracle Java and support of other “open” Java implementations will become important for ZooKeeper. Problem #2: Java 8 support will

Re: ZooKeeper 3.5 blocker issues

2018-09-13 Thread Andor Molnar
What’s needed to turn it off? Do we need a PR or it’s just a config option? Shall we implement a feature switch for that and turn it off by default? Sorry I don’t have too much insight on disk txn sync. Andor > On 2018. Sep 13., at 9:16, Fangmin Lv wrote: > > And to be clear, ZOOKEEPER-2418

[jira] [Issue Comment Deleted] (ZOOKEEPER-2122) Impplement SSL support in the Zookeeper C client library

2018-09-13 Thread shuoshi (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shuoshi updated ZOOKEEPER-2122: --- Comment: was deleted (was: Connected with ECDHE-RSA-AES256-SHA encryption x509 cert information:

[jira] [Commented] (ZOOKEEPER-2122) Impplement SSL support in the Zookeeper C client library

2018-09-13 Thread shuoshi (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16613342#comment-16613342 ] shuoshi commented on ZOOKEEPER-2122: Connected with ECDHE-RSA-AES256-SHA encryption x509 cert

[jira] [Commented] (ZOOKEEPER-2122) Impplement SSL support in the Zookeeper C client library

2018-09-13 Thread shuoshi (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16613343#comment-16613343 ] shuoshi commented on ZOOKEEPER-2122: Connected with ECDHE-RSA-AES256-SHA encryption x509 cert

[jira] [Commented] (ZOOKEEPER-2122) Impplement SSL support in the Zookeeper C client library

2018-09-13 Thread shuoshi (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16613341#comment-16613341 ] shuoshi commented on ZOOKEEPER-2122: Connected with ECDHE-RSA-AES256-SHA encryption x509 cert

[jira] [Issue Comment Deleted] (ZOOKEEPER-2122) Impplement SSL support in the Zookeeper C client library

2018-09-13 Thread shuoshi (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shuoshi updated ZOOKEEPER-2122: --- Comment: was deleted (was: Connected with ECDHE-RSA-AES256-SHA encryption x509 cert information:

ZooKeeper_branch34_openjdk8 - Build # 54 - Failure

2018-09-13 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk8/54/ ### ## LAST 60 LINES OF THE CONSOLE ### Started by timer [EnvInject] - Loading node environment

[jira] [Issue Comment Deleted] (ZOOKEEPER-2122) Impplement SSL support in the Zookeeper C client library

2018-09-13 Thread shuoshi (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shuoshi updated ZOOKEEPER-2122: --- Comment: was deleted (was: already successfully connect to server in ssl double side

[jira] [Comment Edited] (ZOOKEEPER-2122) Impplement SSL support in the Zookeeper C client library

2018-09-13 Thread shuoshi (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16613343#comment-16613343 ] shuoshi edited comment on ZOOKEEPER-2122 at 9/13/18 11:30 AM: -- already

[jira] [Comment Edited] (ZOOKEEPER-2122) Impplement SSL support in the Zookeeper C client library

2018-09-13 Thread shuoshi (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16613343#comment-16613343 ] shuoshi edited comment on ZOOKEEPER-2122 at 9/13/18 11:30 AM: -- already

[jira] [Comment Edited] (ZOOKEEPER-2122) Impplement SSL support in the Zookeeper C client library

2018-09-13 Thread shuoshi (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612974#comment-16612974 ] shuoshi edited comment on ZOOKEEPER-2122 at 9/13/18 11:39 AM: -- I'd like

ZooKeeper_branch35_jdk8 - Build # 1117 - Still Failing

2018-09-13 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1117/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 62.79 KB...] [junit] Running

[jira] [Updated] (ZOOKEEPER-3032) Step 1.6 - Create zk-server maven structure

2018-09-13 Thread Norbert Kalmar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar updated ZOOKEEPER-3032: -- Description: Create a project structure that separates the different parts of

[GitHub] zookeeper issue #611: ZOOKEEPER-3131

2018-09-13 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/611 @wangchaod can we move on? ---

Re: MetricsProvider Plan

2018-09-13 Thread Enrico Olivelli
Il gio 13 set 2018, 07:13 Michael Han ha scritto: > Sounds a good plan to me. Thanks Enrico. > > Regarding 4lw - my opinion is we could just leave it as is and don't expose > any of the newly added metrics through 4lw endpoints. Instead, advocating > admin server end points which will be

[GitHub] zookeeper pull request #622: [ZOOKEEPER-3145] Fix potential watch missing is...

2018-09-13 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/622#discussion_r217545459 --- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java --- @@ -1057,22 +1065,49 @@ void killSession(long session, long zxid) {

[GitHub] zookeeper pull request #622: [ZOOKEEPER-3145] Fix potential watch missing is...

2018-09-13 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/622#discussion_r217546649 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/FuzzySnapshotRelatedTest.java --- @@ -60,14 +60,17 @@ MainThread[] mt =

[GitHub] zookeeper issue #615: ZOOKEEPER-3137: add a utility to truncate logs to a zx...

2018-09-13 Thread enixon
Github user enixon commented on the issue: https://github.com/apache/zookeeper/pull/615 @hanm it sounds like @anmolnar was okay with the form of my TxnLogToolkit patch. I'll add it on top of this pull request and then will consider it ready to merge. ---

Please Register: ZooKeeper Meetup @ Facebook, Nov 8th 2018

2018-09-13 Thread Mohamed Jeelani
Your ZooKeeper friends @ Facebook would like to invite you to share and learn what’s new with ZooKeeper. We will not only share what we at Facebook have been up to, but we have exciting talks from speakers from the ZooKeeper community lined up who are eager to share what they've been working

[GitHub] zookeeper pull request #622: [ZOOKEEPER-3145] Fix potential watch missing is...

2018-09-13 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/622#discussion_r217546112 --- Diff: src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java --- @@ -116,6 +120,10 @@ public static Record deserializeTxn(byte

[GitHub] zookeeper issue #622: [ZOOKEEPER-3145] Fix potential watch missing issue due...

2018-09-13 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/622 @lvfangmin Give me a chance. :) I'll review this tomorrow. ;) ---

[GitHub] zookeeper pull request #622: [ZOOKEEPER-3145] Fix potential watch missing is...

2018-09-13 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/622#discussion_r217555258 --- Diff: src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java --- @@ -116,6 +120,10 @@ public static Record deserializeTxn(byte

[GitHub] zookeeper pull request #622: [ZOOKEEPER-3145] Fix potential watch missing is...

2018-09-13 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/622#discussion_r21785 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/FuzzySnapshotRelatedTest.java --- @@ -60,14 +60,17 @@ MainThread[] mt =

[GitHub] zookeeper issue #611: ZOOKEEPER-3131

2018-09-13 Thread lvfangmin
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/611 @wangchaod it would be great if you can confirm this is fixed, so that we can abandon the PR. ---

[GitHub] zookeeper pull request #622: [ZOOKEEPER-3145] Fix potential watch missing is...

2018-09-13 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/622#discussion_r217554958 --- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java --- @@ -1057,22 +1065,49 @@ void killSession(long session, long zxid) {

[GitHub] zookeeper pull request #619: ZOOKEEPER-3142: Extend SnapshotFormatter to dum...

2018-09-13 Thread enixon
Github user enixon commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/619#discussion_r217561012 --- Diff: src/java/main/org/apache/zookeeper/server/SnapshotFormatter.java --- @@ -34,79 +36,133 @@ import

[GitHub] zookeeper pull request #619: ZOOKEEPER-3142: Extend SnapshotFormatter to dum...

2018-09-13 Thread enixon
Github user enixon commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/619#discussion_r217561003 --- Diff: src/java/main/org/apache/zookeeper/server/SnapshotFormatter.java --- @@ -34,79 +36,133 @@ import

Success: ZOOKEEPER- PreCommit Build #2166

2018-09-13 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2166/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 81.04 MB...] [exec] +1

Failed: ZOOKEEPER- PreCommit Build #2163

2018-09-13 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2163/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 73.10 MB...] [exec]

[jira] [Commented] (ZOOKEEPER-3137) add a utility to truncate logs to a zxid

2018-09-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614153#comment-16614153 ] Hadoop QA commented on ZOOKEEPER-3137: -- -1 overall. GitHub Pull Request Build +1

ZooKeeper-trunk - Build # 190 - Still Failing

2018-09-13 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk/190/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 145.72 KB...] [junit] Tests run: 1, Failures: 0,

[jira] [Updated] (ZOOKEEPER-3108) use a new property server.id in the zoo.cfg to substitute for myid file

2018-09-13 Thread maoling (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] maoling updated ZOOKEEPER-3108: --- Summary: use a new property server.id in the zoo.cfg to substitute for myid file (was:

[jira] [Commented] (ZOOKEEPER-3108) use a new property server.id in the zoo.cfg to substitute for myid file

2018-09-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614332#comment-16614332 ] Hadoop QA commented on ZOOKEEPER-3108: -- +1 overall. GitHub Pull Request Build +1

Failed: ZOOKEEPER- PreCommit Build #2167

2018-09-13 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2167/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 79.21 MB...] [exec]

[jira] [Comment Edited] (ZOOKEEPER-2845) Data inconsistency issue due to retain database in leader election

2018-09-13 Thread Fangmin Lv (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614183#comment-16614183 ] Fangmin Lv edited comment on ZOOKEEPER-2845 at 9/14/18 12:18 AM: -

[GitHub] zookeeper issue #310: [ZOOKEEPER-2845][Test] Test used to reproduce the data...

2018-09-13 Thread lvfangmin
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/310 Problem solved by @revans2. Close this test PR. ---

[jira] [Updated] (ZOOKEEPER-2845) Data inconsistency issue due to retain database in leader election

2018-09-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2845: -- Labels: pull-request-available (was: ) > Data inconsistency issue due to retain

[jira] [Commented] (ZOOKEEPER-2845) Data inconsistency issue due to retain database in leader election

2018-09-13 Thread Fangmin Lv (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614183#comment-16614183 ] Fangmin Lv commented on ZOOKEEPER-2845: --- [~revans2] sorry to get back to this lately, I was in

[GitHub] zookeeper pull request #310: [ZOOKEEPER-2845][Test] Test used to reproduce t...

2018-09-13 Thread lvfangmin
Github user lvfangmin closed the pull request at: https://github.com/apache/zookeeper/pull/310 ---

[GitHub] zookeeper pull request #624: ZOOKEEPER-3108:use a new property server.id in ...

2018-09-13 Thread maoling
GitHub user maoling opened a pull request: https://github.com/apache/zookeeper/pull/624 ZOOKEEPER-3108:use a new property server.id in the zoo.cfg to substitute for myid file - use a new property `server.id` in the `zoo.cfg` to substitute for `myid `file,If the unique id is both

[jira] [Updated] (ZOOKEEPER-3108) use a new property server.id in the zoo.cfg to substitute for myid file

2018-09-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3108: -- Labels: pull-request-available (was: ) > use a new property server.id in the

Failed: ZOOKEEPER- PreCommit Build #2164

2018-09-13 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2164/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 80.71 MB...] [exec]

[jira] [Commented] (ZOOKEEPER-3142) Extend SnapshotFormatter to dump data in json format

2018-09-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614171#comment-16614171 ] Hadoop QA commented on ZOOKEEPER-3142: -- -1 overall. GitHub Pull Request Build +1

[jira] [Commented] (ZOOKEEPER-3137) add a utility to truncate logs to a zxid

2018-09-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614174#comment-16614174 ] Hadoop QA commented on ZOOKEEPER-3137: -- -1 overall. GitHub Pull Request Build +1

Failed: ZOOKEEPER- PreCommit Build #2165

2018-09-13 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2165/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 80.05 MB...] [exec]

[GitHub] zookeeper pull request #623: [ZOOKEEPER-3146] Limit the maximum client conne...

2018-09-13 Thread hanm
Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/623#discussion_r217585326 --- Diff: src/java/test/org/apache/zookeeper/test/ClientTest.java --- @@ -506,7 +506,7 @@ private void performClientTest(boolean withWatcherObj)

Success: ZOOKEEPER- PreCommit Build #2168

2018-09-13 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2168/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 81.11 MB...] [exec] +1

[GitHub] zookeeper pull request #623: [ZOOKEEPER-3146] Limit the maximum client conne...

2018-09-13 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/623#discussion_r217450443 --- Diff: src/java/test/org/apache/zookeeper/test/ClientTest.java --- @@ -506,7 +506,7 @@ private void performClientTest(boolean withWatcherObj)

[GitHub] zookeeper issue #611: ZOOKEEPER-3131

2018-09-13 Thread lvfangmin
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/611 @hanm based on @wangchaod's description in the JIRA, #612 should fix the exact issue. @anmolnar as I commented in the JIRA, not removing the empty map is optimized from performance

[GitHub] zookeeper issue #622: [ZOOKEEPER-3145] Fix potential watch missing issue due...

2018-09-13 Thread lvfangmin
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/622 Can I have some to help review this one as well, this is a new issue found recently, it would be great to have the community review here as well before we land it internally. ---

[jira] [Commented] (ZOOKEEPER-3144) Potential ephemeral nodes inconsistent due to global session inconsistent with fuzzy snapshot

2018-09-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16613826#comment-16613826 ] Hadoop QA commented on ZOOKEEPER-3144: -- +1 overall. GitHub Pull Request Build +1

Success: ZOOKEEPER- PreCommit Build #2162

2018-09-13 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2162/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 80.35 MB...] [exec] +1

Re: Java version (Oracle - OpenJDK) support

2018-09-13 Thread Enrico Olivelli
Il gio 13 set 2018, 10:52 Andor Molnar ha scritto: > Hi team, > > Let me quickly summarise what we’re trying to resolve on this thread. > > Problem #1: due to Oracle licensing changes people are expected to move > away from Oracle Java and support of other “open” Java implementations will >

[jira] [Commented] (ZOOKEEPER-3146) Limit the maximum client connections per IP in NettyServerCnxnFactory

2018-09-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16613753#comment-16613753 ] Hadoop QA commented on ZOOKEEPER-3146: -- -1 overall. GitHub Pull Request Build +1

ZooKeeper-trunk-windows-cmake - Build # 2934 - Still Failing

2018-09-13 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-windows-cmake/2934/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 9.71 KB...] [ivy:retrieve] confs: [javacc]

[jira] [Assigned] (ZOOKEEPER-3131) org.apache.zookeeper.server.WatchManager resource leak

2018-09-13 Thread Fangmin Lv (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fangmin Lv reassigned ZOOKEEPER-3131: - Assignee: Fangmin Lv > org.apache.zookeeper.server.WatchManager resource leak >

Re: Java version (Oracle - OpenJDK) support

2018-09-13 Thread Patrick Hunt
On Thu, Sep 13, 2018 at 1:52 AM Andor Molnar wrote: > Hi team, > > Let me quickly summarise what we’re trying to resolve on this thread. > > Problem #1: due to Oracle licensing changes people are expected to move > away from Oracle Java and support of other “open” Java implementations will >

[GitHub] zookeeper issue #621: [ZOOKEEPER-3144] Fix potential ephemeral nodes inconsi...

2018-09-13 Thread lvfangmin
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/621 @hanm rebased onto latest. ---

Failed: ZOOKEEPER- PreCommit Build #2161

2018-09-13 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2161/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 79.34 MB...] [exec]