Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/628
@enixon If that was the free(): invalid pointer issue in
testRemoveWatchers, I have a patch for that, but needs to be reviewed. #660
(and it's still failing to pass all tests)
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/666
@Reidd You're probably facing with the Maven migration monster. Please
check the conflicts.
---
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2404/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 68.47 MB...]
[exec]
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/666
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2404/
---
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2406/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 84.86 MB...]
[exec]
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/651
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2406/
---
Github user nkalmar commented on the issue:
https://github.com/apache/zookeeper/pull/665
retest this please
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/651
@hanm do you accept this patch with my recent changes?
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/653
@hanm Are u happy with simplifying this test?
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/651
retest this please
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/653
retest this please
---
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2405/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 77.42 MB...]
[exec]
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/653
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2405/
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/659
Thanks guys for reviewing. I need an approval for at least one committer.
@hanm are u happy with this refactor?
---
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2407/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 8.47 KB...]
[exec]
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/661
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2407/
---
Github user nkalmar commented on the issue:
https://github.com/apache/zookeeper/pull/662
Looks good, thanks @andreareale
The C test fail looks like it's the flaky one:
*** Error in `./zktest-mt': free(): invalid pointer: 0x2b913dcd5000 ***
I think there's already a fix
GitHub user maoling opened a pull request:
https://github.com/apache/zookeeper/pull/667
ZOOKEEPER-3158:firstConnect.countDown() will not be executed where
sendThread.primeConnection() has thrown an exception
more details in
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-3158:
--
Labels: pull-request-available (was: )
> firstConnect.countDown() will not be
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2408/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 81.31 MB...]
[exec]
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/667
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2409/
---
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2409/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 76.37 MB...]
[exec]
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/665
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2408/
---
maoling created ZOOKEEPER-3164:
--
Summary: Backport ZOOKEEPER-3057 to branch3.4
Key: ZOOKEEPER-3164
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3164
Project: ZooKeeper
Issue Type: Bug
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/658
Merged to branch-3.4. Thanks @nkalmar !
Please close this PR.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/651
retest this please
---
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2412/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 77.06 MB...]
[exec]
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/661
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2412/
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/664
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2418/
---
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2416/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 60.42 MB...]
[exec]
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/665
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2416/
---
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2418/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 33.28 KB...]
[exec]
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/662
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2417/
---
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2415/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 72.08 MB...]
[exec]
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/655
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2415/
---
Github user nkalmar commented on the issue:
https://github.com/apache/zookeeper/pull/665
retest this please
---
Github user nkalmar commented on the issue:
https://github.com/apache/zookeeper/pull/662
retest this please
---
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2419/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 81.75 MB...]
[exec]
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/661
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2419/
---
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2420/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 33.32 KB...]
[exec]
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/664
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2420/
---
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2417/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 69.41 MB...]
[exec]
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2413/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 77.39 MB...]
[exec]
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/456
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2413/
---
Github user tamaashu commented on the issue:
https://github.com/apache/zookeeper/pull/664
retest this please
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/667
Good.
What about adding a test case to demonstrate the problem and prevent
regressions in the future?
---
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk8/83/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 44.55 KB...]
[junit] Running
Github user tamaashu commented on the issue:
https://github.com/apache/zookeeper/pull/661
retest this please
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/663
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2414/
---
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2414/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 81.77 MB...]
[exec]
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/653
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2421/
---
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2421/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 76.50 MB...]
[exec]
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/655
retest this please
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/653
retest this please
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645913#comment-16645913
]
Aishwarya Soni commented on ZOOKEEPER-3036:
---
We got the same issue a couple of days back.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645913#comment-16645913
]
Aishwarya Soni edited comment on ZOOKEEPER-3036 at 10/11/18 3:41 AM:
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/628
@enixon It is.
---
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2411/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 77.08 MB...]
[exec]
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/651
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2411/
---
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2410/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 42.31 MB...]
[exec]
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/540
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2410/
---
Github user nkalmar closed the pull request at:
https://github.com/apache/zookeeper/pull/658
---
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/632#discussion_r224210799
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NodeHashMapImpl.java
---
@@ -0,0 +1,116 @@
+/**
+ * Licensed to the Apache
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/632#discussion_r224209494
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/util/AdHash.java ---
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/632#discussion_r224206681
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java ---
@@ -1521,4 +1566,179 @@ public boolean removeWatch(String path,
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/632#discussion_r224206365
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java ---
@@ -1521,4 +1566,179 @@ public boolean removeWatch(String path,
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/632#discussion_r224208545
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java ---
@@ -154,6 +160,26 @@
private final
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/632#discussion_r224212868
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/DataNode.java ---
@@ -37,6 +37,14 @@
*
*/
public class DataNode
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/632#discussion_r224213395
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/DataNode.java ---
@@ -37,6 +37,14 @@
*
*/
public class DataNode
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/659#discussion_r224197413
--- Diff:
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java
---
@@ -402,4 +421,129 @@ public File getConfFile()
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/628
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2422/
---
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2422/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 77.36 MB...]
[exec]
Github user enixon commented on the issue:
https://github.com/apache/zookeeper/pull/628
@anmolnar the error in the C-client tests is:
*** Error in `./zktest-mt': free(): invalid pointer: 0x2b971c71e000 ***
Not sure if its the same issue as you're seeking to
See https://builds.apache.org/job/ZooKeeper-trunk/226/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 195.72 KB...]
[junit] Running
74 matches
Mail list logo
