Re: Decrease number of threads in Jenkins builds to reduce flakyness

2018-10-22 Thread Andor Molnár
Thanks Bogdan, so far so good. testNodeDataChanged is an old beast, I've a possible fix for that from @afine: https://github.com/apache/zookeeper/pull/300 Would be great if we could review it and get rid of this flaky. Andor On 10/20/18 06:41, Bogdan Kanivets wrote: > I think the argument

ZooKeeper_branch34_openjdk8 - Build # 96 - Failure

2018-10-22 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk8/96/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 71.60 KB...] [junit] Running

improving tolerance to network failures

2018-10-22 Thread Ted Dunning
I am starting work on a project to improve the tolerance of Zookeeper to network failures and would like feedback on the idea. The problem is that with environments where link bonding is forbidden (they exist, trust me), Zookeeper is sensitive to the loss of a single switch or a few network

ZooKeeper-trunk - Build # 244 - Failure

2018-10-22 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk/244/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 198.38 KB...] [junit] Running

[GitHub] zookeeper issue #665: [ZOOKEEPER-3163] Use session map in the Netty to impro...

2018-10-22 Thread maoling
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/665 @lvfangmin look at the branch3.4 is not consistency with master.Could we create a separate jira to backport this refactor to branch3.4 to keep them consistency? ---

ZooKeeper_branch34_jdk8 - Build # 1571 - Still Failing

2018-10-22 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch34_jdk8/1571/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 43.69 KB...] [junit] Running

ZooKeeper_branch35_jdk8 - Build # 1165 - Still Failing

2018-10-22 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1165/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 108.05 KB...] [junit] Tests run: 1, Failures:

Re:ZooKeeper two issues review

2018-10-22 Thread 毛蛤丝
About the ZOOKEEPER-3167:good feature,just go ahead.follow the guideline I had provided,then we can start from there.look at the patch you had attached,some quick comments:0.if(key.contains(path)). contains???1.don't use Chinese annotations.2.notice the order of import and don't import

[GitHub] zookeeper issue #647: [ZOOKEEPER-3125] Fixing pzxid consistent issue when re...

2018-10-22 Thread lvfangmin
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/647 @anmolnar what's your opinion with @hanm 's reply? ---

[GitHub] zookeeper issue #665: [ZOOKEEPER-3163] Use session map in the Netty to impro...

2018-10-22 Thread lvfangmin
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/665 Yes, it's similar to ZOOKEEPER-1669, which uses sessionMap to reduce the cost of close session, most of the code are identical as well. In 3.4, it has the removeCnxn method defined in

[jira] [Updated] (ZOOKEEPER-3029) Create pom.xml for jute and server

2018-10-22 Thread Norbert Kalmar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar updated ZOOKEEPER-3029: -- Summary: Create pom.xml for jute and server (was: Create pom.xml for jute,

[jira] [Updated] (ZOOKEEPER-3029) Create pom.xml for jute and server

2018-10-22 Thread Norbert Kalmar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar updated ZOOKEEPER-3029: -- Description: After the directory structures has been created, it is time to create

[GitHub] zookeeper issue #669: ZOOKEEPER-3152: Port ZK netty stack to netty4

2018-10-22 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/669 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2482/ ---

[GitHub] zookeeper issue #669: ZOOKEEPER-3152: Port ZK netty stack to netty4

2018-10-22 Thread ivmaykov
Github user ivmaykov commented on the issue: https://github.com/apache/zookeeper/pull/669 @eolivelli use `voidPromise()` to avoid allocations when writing to channel ---

[GitHub] zookeeper issue #669: ZOOKEEPER-3152: Port ZK netty stack to netty4

2018-10-22 Thread ivmaykov
Github user ivmaykov commented on the issue: https://github.com/apache/zookeeper/pull/669 Cleaner Epoll/Nio selection code ---

[GitHub] zookeeper issue #669: ZOOKEEPER-3152: Port ZK netty stack to netty4

2018-10-22 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/669 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2484/ ---

[GitHub] zookeeper issue #669: ZOOKEEPER-3152: Port ZK netty stack to netty4

2018-10-22 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/669 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2485/ ---

[GitHub] zookeeper issue #669: ZOOKEEPER-3152: Port ZK netty stack to netty4

2018-10-22 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/669 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2483/ ---

[GitHub] zookeeper issue #669: ZOOKEEPER-3152: Port ZK netty stack to netty4

2018-10-22 Thread ivmaykov
Github user ivmaykov commented on the issue: https://github.com/apache/zookeeper/pull/669 @eolivelli changes you requested: - use Epoll if available - if (LOG.isDebugEnabled()) around complex LOG.debug() statements - use netty-all artifact Haven't looked into

ZooKeeper_branch34_openjdk7 - Build # 2095 - Failure

2018-10-22 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/2095/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 43.42 KB...] [junit] Running

[GitHub] zookeeper issue #628: ZOOKEEPER-3140: Allow Followers to host Observers

2018-10-22 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/628 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2486/ ---

Failed: ZOOKEEPER- PreCommit Build #2486

2018-10-22 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2486/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 85.60 MB...] [exec]