Re: Zookeeper at Twitter by Micheal

2018-10-23 Thread Edward Ribeiro
Congrats, Michael, Really cool blog post. :) Em seg, 15 de out de 2018 05:26, Norbert Kalmar escreveu: > Good blog post! > Can't wait for the PRs ;) > I'm very positive about ZooKeeper's future (heard lot of talks lately about > etcd overthrowing ZooKeeper - no chance :) ) > > Norbert > > On

Re: improving tolerance to network failures

2018-10-23 Thread Ted Dunning
There have been several comments on the document. I will be porting discussions from the document back to the mailing list each day. Alex Shraer makes a good point that with the design as stated, there is no provision for dealing with the rebalancing of client connections during dynamic

Re: improving tolerance to network failures

2018-10-23 Thread Michael Han
>> Will there be a code effect? There will be - the current rebalancing algorithm will be broken if no code is done to StaticHostProvider.updateServerList to teach it aware of multiple server addresses belong to the same server. For example, currently if we add a new server through reconfig, the

Re: improving tolerance to network failures

2018-10-23 Thread Ted Dunning
Michael, I wouldn't characterize the current proposal as broken so much as it talks about connection balancing rather than server balancing. Other than that, I think I agree with what you are saying. So we have two folks with a feeling that server balancing from the client side is significantly

[GitHub] zookeeper issue #665: [ZOOKEEPER-3163] Use session map in the Netty to impro...

2018-10-23 Thread lvfangmin
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/665 @maoling, we can port this back to 3.4 in the same Jira, I'll send out a PR separately for that. ---

[GitHub] zookeeper pull request #673: [ZOOKEEPER-3177] Refactor request throttle logi...

2018-10-23 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/673#discussion_r227532671 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java --- @@ -1107,6 +1102,19 @@ public void

[GitHub] zookeeper pull request #632: [ZOOKEEPER-3150] Add tree digest check and veri...

2018-10-23 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/632#discussion_r227532976 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/command/HashCommand.java --- @@ -0,0 +1,49 @@ +/** + * Licensed to the

[GitHub] zookeeper pull request #632: [ZOOKEEPER-3150] Add tree digest check and veri...

2018-10-23 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/632#discussion_r227533265 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/util/AdHash.java --- @@ -0,0 +1,84 @@ +/** + * Licensed to the Apache

Re: [VOTE] Maven migration - separation of java files to server and client project?

2018-10-23 Thread Michael Han
+1 (for keep server, client and common together). We can do client / server split separately. Interestingly, there was an outstanding JIRA about the split, which we could use after maven build is live: https://issues.apache.org/jira/browse/ZOOKEEPER-233 On Tue, Oct 16, 2018 at 3:30 AM Andor

[GitHub] zookeeper issue #300: ZOOKEEPER-2807: Flaky test: org.apache.zookeeper.test....

2018-10-23 Thread lavacat
Github user lavacat commented on the issue: https://github.com/apache/zookeeper/pull/300 @anmolnar applied the patch to latest master and run tests 10 times with 8 threads. Original error in testNodeDataChanged is gone, but it failed 4 times with 2018-10-23 09:37:31,566 [myid:] -

[GitHub] zookeeper pull request #673: [ZOOKEEPER-3177] Refactor request throttle logi...

2018-10-23 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/673#discussion_r227557275 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java --- @@ -1107,6 +1102,19 @@ public void

[GitHub] zookeeper issue #628: ZOOKEEPER-3140: Allow Followers to host Observers

2018-10-23 Thread enixon
Github user enixon commented on the issue: https://github.com/apache/zookeeper/pull/628 @anmolnar : I see that you closed #660 without merging. Given that we're guessing it is the cause for the remaining test failures of this PR, is there something that I can do to to help address

[GitHub] zookeeper issue #628: ZOOKEEPER-3140: Allow Followers to host Observers

2018-10-23 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/628 I am looking at https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2486/console, it was not clear to me which C test failed, aside from the ``./zktest-mt': free(): invalid pointer:

[GitHub] zookeeper issue #628: ZOOKEEPER-3140: Allow Followers to host Observers

2018-10-23 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/628 >> This patch does not touch the c client or the default configurations for those tests so I'm unsure how to proceed. My feeling is the failure is a flaky test, and has nothing to do with

[jira] [Commented] (ZOOKEEPER-3179) Add snapshot compression to reduce the disk IO

2018-10-23 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16661432#comment-16661432 ] Michael Han commented on ZOOKEEPER-3179: Good feature.  We can also consider provide the

[jira] [Commented] (ZOOKEEPER-3180) Add response cache to improve the throughput of read heavy traffic

2018-10-23 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16661452#comment-16661452 ] Michael Han commented on ZOOKEEPER-3180: What will be we caching here? Is it the byte buffers

[GitHub] zookeeper pull request #665: [ZOOKEEPER-3163] Use session map in the Netty t...

2018-10-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/665 ---

[jira] [Resolved] (ZOOKEEPER-3163) Use session map to improve the performance when closing session in Netty

2018-10-23 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han resolved ZOOKEEPER-3163. Resolution: Fixed Issue resolved by pull request 665

[GitHub] zookeeper pull request #642: ZOOKEEPER-3151: test Jenkins. Don't merge.

2018-10-23 Thread hanm
Github user hanm closed the pull request at: https://github.com/apache/zookeeper/pull/642 ---

ZooKeeper-trunk - Build # 245 - Still Failing

2018-10-23 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk/245/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 334.69 KB...] [exec] : elapsed 1001 : OK [exec]

[GitHub] zookeeper issue #628: ZOOKEEPER-3140: Allow Followers to host Observers

2018-10-23 Thread enixon
Github user enixon commented on the issue: https://github.com/apache/zookeeper/pull/628 The tests that fail are not entirely consistent. I've tried disabling TestLogClientEnv.cc, TestReadOnlyClient.cc, TestReconfigServer.cc, and TestWatchers.cc and this seems to work some of the

[jira] [Commented] (ZOOKEEPER-3181) ZOOKEEPER-2355 broke Curator TestingQuorumPeerMain

2018-10-23 Thread Akira Ajisaka (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16661697#comment-16661697 ] Akira Ajisaka commented on ZOOKEEPER-3181: -- Recently Apache Hadoop upgraded ZooKeeper from

[jira] [Commented] (ZOOKEEPER-3163) Use session map to improve the performance when closing session in Netty

2018-10-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16661701#comment-16661701 ] Hudson commented on ZOOKEEPER-3163: --- FAILURE: Integrated in Jenkins build

[jira] [Created] (ZOOKEEPER-3181) ZOOKEEPER-2355 broke Curator TestingQuorumPeerMain

2018-10-23 Thread Akira Ajisaka (JIRA)
Akira Ajisaka created ZOOKEEPER-3181: Summary: ZOOKEEPER-2355 broke Curator TestingQuorumPeerMain Key: ZOOKEEPER-3181 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3181 Project: ZooKeeper

[jira] [Commented] (ZOOKEEPER-3163) Use session map to improve the performance when closing session in Netty

2018-10-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16661753#comment-16661753 ] Hudson commented on ZOOKEEPER-3163: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #246 (See