[GitHub] zookeeper pull request #684: ZOOKEEPER-3180: Add response cache to improve t...

Github user tumativ commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/684#discussion_r231194896 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/ResponseCache.java --- @@ -0,0 +1,84 @@ +/** + * Licensed to the Apache

[GitHub] zookeeper pull request #684: ZOOKEEPER-3180: Add response cache to improve t...

Github user tumativ commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/684#discussion_r231199414 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/ResponseCache.java --- @@ -0,0 +1,84 @@ +/** + * Licensed to the Apache

Failed: ZOOKEEPER- PreCommit Build #2596

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2596/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 86.68 MB...] [exec]

[GitHub] zookeeper issue #681: ZOOKEEPER-3176: Quorum TLS - add SSL config options

Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/681 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2596/ ---

[GitHub] zookeeper pull request #679: ZOOKEEPER-3172: Quorum TLS - fix port unificati...

Github user ivmaykov closed the pull request at: https://github.com/apache/zookeeper/pull/679 ---

[GitHub] zookeeper pull request #679: ZOOKEEPER-3172: Quorum TLS - fix port unificati...

GitHub user ivmaykov reopened a pull request: https://github.com/apache/zookeeper/pull/679 ZOOKEEPER-3172: Quorum TLS - fix port unification to allow rolling upgrades Fix numerous problems with UnifiedServerSocket, such as hanging the accept() thread when the client doesn't send

[GitHub] zookeeper issue #685: [ZOOKEEPER-3104] Fix potential data inconsistency due ...

Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/685 This is merged. Thanks @lvfangmin ! Please close this PR. ---

[GitHub] zookeeper issue #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/key sto...

Github user ivmaykov commented on the issue: https://github.com/apache/zookeeper/pull/678 @anmolnar is there a way to reproduce the exact same steps that jenkins runs on my macbook? ---

[GitHub] zookeeper issue #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/key sto...

Github user ivmaykov commented on the issue: https://github.com/apache/zookeeper/pull/678 @anmolnar it works for me as far as I can tell, I think the contbuild is flaky? The contbuild on #681, which includes the same commit, passes. ---

[jira] [Commented] (ZOOKEEPER-3155) Remove Forrest XMLs and their build process from the project

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677219#comment-16677219 ] Hudson commented on ZOOKEEPER-3155: --- SUCCESS: Integrated in Jenkins build

[GitHub] zookeeper issue #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/key sto...

Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/678 Maybe you should use docker. As soon as possible I will copy the command line we are using in Jenkins job. Maybe it is already available on the job log ---

[GitHub] zookeeper pull request #671: ZOOKEEPER-3155: Remove Forrest XMLs and their b...

Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/671 ---

[GitHub] zookeeper issue #671: ZOOKEEPER-3155: Remove Forrest XMLs and their build pr...

Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/671 Committed to master branch. Thanks @tamaashu ! ---

[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...

Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/680 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2595/ ---

Failed: ZOOKEEPER- PreCommit Build #2595

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2595/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 38.14 KB...] [exec]

Failed: ZOOKEEPER- PreCommit Build #2594

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2594/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 37.83 KB...] [exec]

[GitHub] zookeeper issue #679: ZOOKEEPER-3172: Quorum TLS - fix port unification to a...

Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/679 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2594/ ---

[GitHub] zookeeper issue #679: ZOOKEEPER-3172: Quorum TLS - fix port unification to a...

Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/679 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2597/ ---

Failed: ZOOKEEPER- PreCommit Build #2597

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2597/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 86.66 MB...] [exec]

[GitHub] zookeeper issue #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/key sto...

Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/678 @ivmaykov It's in: `zookeeper-server/src/test/resources/test-github-pr.sh` ---

[GitHub] zookeeper pull request #680: ZOOKEEPER-3174: Quorum TLS - support reloading ...

Github user ivmaykov closed the pull request at: https://github.com/apache/zookeeper/pull/680 ---

[GitHub] zookeeper pull request #680: ZOOKEEPER-3174: Quorum TLS - support reloading ...

GitHub user ivmaykov reopened a pull request: https://github.com/apache/zookeeper/pull/680 ZOOKEEPER-3174: Quorum TLS - support reloading trust/key store Allow reloading SSL trust stores and key stores from disk when the files on disk change. Note that this is stacked on

Success: ZOOKEEPER- PreCommit Build #2593

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2593/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 86.03 MB...] [exec]

[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...

Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/680 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2593/ ---

[GitHub] zookeeper issue #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/key sto...

Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/678 Now it's green. I'll merge it. Previously the findbugs subprocess has been killed for some reason. ---

[jira] [Assigned] (ZOOKEEPER-3179) Add snapshot compression to reduce the disk IO

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yisong Yue reassigned ZOOKEEPER-3179: - Assignee: Yisong Yue > Add snapshot compression to reduce the disk IO >

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/678 ---

Failed: ZOOKEEPER- PreCommit Build #2600

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2600/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 85.67 MB...] [exec]

[GitHub] zookeeper issue #679: ZOOKEEPER-3172: Quorum TLS - fix port unification to a...

Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/679 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2600/ ---

[GitHub] zookeeper issue #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/key sto...

Github user ivmaykov commented on the issue: https://github.com/apache/zookeeper/pull/678 I don't understand why this PR started failing Jenkins builds all of a sudden. The next 2 PRs stacked on this one (#678 and #680) also fail, but the last one (#681) passes. ---

ZooKeeper_branch35_jdk8 - Build # 1183 - Failure

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1183/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 64.69 KB...] [junit] Running

[GitHub] zookeeper issue #679: ZOOKEEPER-3172: Quorum TLS - fix port unification to a...

Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/679 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2598/ ---

Success: ZOOKEEPER- PreCommit Build #2598

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2598/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 86.43 MB...] [exec]

[GitHub] zookeeper issue #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/key sto...

Github user ivmaykov commented on the issue: https://github.com/apache/zookeeper/pull/678 Jenkins claims there is a findbugs failure, but there is no actual output of findbugs failures, and findbugs passes on my machine. ¯\_(ツ)_/¯ ---

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

Github user enixon commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r231359694 --- Diff: zookeeper-docs/src/documentation/content/xdocs/zookeeperAdmin.xml --- @@ -764,6 +764,18 @@ server.3=zoo3:2888:3888

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

Github user enixon commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r231364616 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/ObserverMaster.java --- @@ -0,0 +1,514 @@ +/** + * Licensed to the

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

Github user enixon commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r231364697 --- Diff: zookeeper-docs/src/documentation/content/xdocs/zookeeperObservers.xml --- @@ -111,7 +111,41 @@ the ZooKeeper service.

[GitHub] zookeeper issue #628: ZOOKEEPER-3140: Allow Followers to host Observers

Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/628 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2605/ ---

Failed: ZOOKEEPER- PreCommit Build #2605

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2605/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 87.74 MB...] [exec]

[jira] [Resolved] (ZOOKEEPER-3173) Quorum TLS - support PEM trust/key stores

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-3173. - Resolution: Fixed Fix Version/s: 3.5.5 3.6.0 Issue

[GitHub] zookeeper issue #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/key sto...

Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/678 Merged to 3.5 and master branches. Thanks @ivmaykov ! ---

[jira] [Commented] (ZOOKEEPER-3173) Quorum TLS - support PEM trust/key stores

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677753#comment-16677753 ] Hudson commented on ZOOKEEPER-3173: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #259 (See

[GitHub] zookeeper pull request #690: ZOOKEEPER-3179: Add snapshot compression to red...

GitHub user yisong-yue opened a pull request: https://github.com/apache/zookeeper/pull/690 ZOOKEEPER-3179: Add snapshot compression to reduce the disk IO You can merge this pull request into a Git repository by running: $ git pull https://github.com/yisong-yue/zookeeper

[jira] [Updated] (ZOOKEEPER-3179) Add snapshot compression to reduce the disk IO

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3179: -- Labels: pull-request-available (was: ) > Add snapshot compression to reduce the

[jira] [Commented] (ZOOKEEPER-3173) Quorum TLS - support PEM trust/key stores

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677700#comment-16677700 ] Hudson commented on ZOOKEEPER-3173: --- SUCCESS: Integrated in Jenkins build

Failed: ZOOKEEPER- PreCommit Build #2606

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2606/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 86.48 MB...] [exec]

[GitHub] zookeeper issue #690: ZOOKEEPER-3179: Add snapshot compression to reduce the...

Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/690 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2606/ ---

[GitHub] zookeeper issue #676: ZOOKEEPER-3181: ZOOKEEPER-2355 broke Curator TestingQu...

Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/676 >> I'm not familiar with Apache Curator project, so I'm not sure how actually hard it is. @lvfangmin is a Curator committer and could probably help here to push out a new release. ---

[GitHub] zookeeper issue #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/key sto...

Github user enixon commented on the issue: https://github.com/apache/zookeeper/pull/678 Yeah, there aren't findbugs reports in the artifacts as I would expect https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2599/artifact/patchprocess/ , it's unclear what went wrong

[GitHub] zookeeper pull request #679: ZOOKEEPER-3172: Quorum TLS - fix port unificati...

GitHub user ivmaykov reopened a pull request: https://github.com/apache/zookeeper/pull/679 ZOOKEEPER-3172: Quorum TLS - fix port unification to allow rolling upgrades Fix numerous problems with UnifiedServerSocket, such as hanging the accept() thread when the client doesn't send

Failed: ZOOKEEPER- PreCommit Build #2601

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2601/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 78.04 MB...] [exec]

[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...

Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/680 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2601/ ---

Success: ZOOKEEPER- PreCommit Build #2603

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2603/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 80.54 MB...] [exec]

[GitHub] zookeeper issue #669: ZOOKEEPER-3152: Port ZK netty stack to netty4

Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/669 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2603/ ---

[GitHub] zookeeper pull request #679: ZOOKEEPER-3172: Quorum TLS - fix port unificati...

Github user ivmaykov closed the pull request at: https://github.com/apache/zookeeper/pull/679 ---

Re: Re: asfgit commenting on PRs

+1 on the idea of silencing the comments from asfgit bot. Hi Enrico - I am still seeing the bot commenting on builds triggered by new commits after you making the change. An example just a second ago: https://github.com/apache/zookeeper/pull/679 On Tue, Nov 6, 2018 at 4:02 AM Enrico Olivelli

[GitHub] zookeeper issue #681: ZOOKEEPER-3176: Quorum TLS - add SSL config options

Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/681 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2602/ ---

Success: ZOOKEEPER- PreCommit Build #2602

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2602/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 86.11 MB...] [exec]

Success: ZOOKEEPER- PreCommit Build #2604

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2604/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 77.99 MB...] [exec]

[GitHub] zookeeper issue #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/key sto...

Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/678 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2604/ ---

[GitHub] zookeeper issue #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/key sto...

Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/678 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2599/ ---

Failed: ZOOKEEPER- PreCommit Build #2599

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2599/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 77.05 MB...] [exec]

[GitHub] zookeeper issue #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/key sto...

Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/678 It's not findbugs, core and contrib tests are failing, but I cannot see why: ``` [exec] -1 core tests. The patch failed core unit tests. [exec] -1 contrib

Re: Re: asfgit commenting on PRs

I am not sure what is adding that comment. I will dig Enrico Il mar 6 nov 2018, 21:04 Michael Han ha scritto: > +1 on the idea of silencing the comments from asfgit bot. > > Hi Enrico - I am still seeing the bot commenting on builds triggered by new > commits after you making the change. > An

ZooKeeper-trunk - Build # 257 - Failure

See https://builds.apache.org/job/ZooKeeper-trunk/257/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 174.09 KB...] [junit] Running

[jira] [Commented] (ZOOKEEPER-3155) Remove Forrest XMLs and their build process from the project

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677273#comment-16677273 ] Hudson commented on ZOOKEEPER-3155: --- FAILURE: Integrated in Jenkins build ZooKeeper-trunk #257 (See

[GitHub] zookeeper issue #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/key sto...

Github user ivmaykov commented on the issue: https://github.com/apache/zookeeper/pull/678 @anmolnar the latest attempt does not have test failures, but claims a findbugs failure. >[exec] -1 overall. GitHub Pull Request Build >[exec] >[exec] >

Build failed in Jenkins: ZooKeeper-trunk-owasp #163

See Changes: [andor] ZOOKEEPER-3156: Add in option to canonicalize host name -- [...truncated 15.99 KB...]

ZooKeeper_branch34_openjdk8 - Build # 112 - Failure

See https://builds.apache.org/job/ZooKeeper_branch34_openjdk8/112/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 43.43 KB...] [junit] Running

Re: Re: asfgit commenting on PRs

I have unchecked the "Add test result one liner" flag in the PR builder Job https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/ let's see how it feels now Enrico Il giorno mar 6 nov 2018 alle ore 03:44 毛蛤丝 ha scritto: > > +1,for removing the asfgit successful build comments. >

[GitHub] zookeeper pull request #684: ZOOKEEPER-3180: Add response cache to improve t...

Github user tumativ commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/684#discussion_r231110582 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/ResponseCache.java --- @@ -0,0 +1,84 @@ +/** + * Licensed to the Apache

[GitHub] zookeeper issue #648: ZOOKEEPER-3156: Add in option to canonicalize host nam...

Github user revans2 commented on the issue: https://github.com/apache/zookeeper/pull/648 Thanks ---

[GitHub] zookeeper pull request #648: ZOOKEEPER-3156: Add in option to canonicalize h...

Github user revans2 closed the pull request at: https://github.com/apache/zookeeper/pull/648 ---

[GitHub] zookeeper issue #671: ZOOKEEPER-3155: Remove Forrest XMLs and their build pr...

Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/671 Sorry @tamaashu , I missed your comment. I'm @anmolnar btw, somebody has already stolen "andor". :) ---

[GitHub] zookeeper pull request #684: ZOOKEEPER-3180: Add response cache to improve t...

Github user tumativ commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/684#discussion_r231189992 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/ResponseCache.java --- @@ -0,0 +1,84 @@ +/** + * Licensed to the Apache