[GitHub] zookeeper pull request #689: ZOOKEEPER-3183:Notifying the WatcherCleaner thr...

Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/689#discussion_r231610533 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatcherCleaner.java --- @@ -50,6 +50,8 @@ private volatile

Re: Re: asfgit commenting on PRs

Now it seems okay. Let me know if there are problems. The docs about the plugin are not very clear. Cheers Enrico Il mar 6 nov 2018, 21:10 Enrico Olivelli ha scritto: > I am not sure what is adding that comment. > I will dig > > Enrico > > > Il mar 6 nov 2018, 21:04 Michael Han ha scritto: >

[GitHub] zookeeper pull request #691: This is only a test for Jenkins

Github user eolivelli closed the pull request at: https://github.com/apache/zookeeper/pull/691 ---

[GitHub] zookeeper issue #689: ZOOKEEPER-3183:Notifying the WatcherCleaner thread and...

Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/689 @tumativ Only 2 days passed, let's give some chance for the community to review your code. I'm particularly interested in @lvfangmin 's opinion. ---

[GitHub] zookeeper pull request #669: ZOOKEEPER-3152: Port ZK netty stack to netty4

GitHub user ivmaykov reopened a pull request: https://github.com/apache/zookeeper/pull/669 ZOOKEEPER-3152: Port ZK netty stack to netty4 Summary: Ported the client connection netty stack from netty3 to netty4. This includes both the server side (NettyServerCnxn and friends) and the

[GitHub] zookeeper pull request #669: ZOOKEEPER-3152: Port ZK netty stack to netty4

Github user ivmaykov closed the pull request at: https://github.com/apache/zookeeper/pull/669 ---

[GitHub] zookeeper issue #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/key sto...

Github user ivmaykov commented on the issue: https://github.com/apache/zookeeper/pull/678 @anmolnar thanks for merging this :) I've rebased #679, #680, and #681 on top of master. Let's get those in soon :) ---

Re: asfgit commenting on PRs

Thanks Enrico! > On 2018. Nov 7., at 10:37, Enrico Olivelli wrote: > > Now it seems okay. > Let me know if there are problems. > The docs about the plugin are not very clear. > > Cheers > Enrico > > Il mar 6 nov 2018, 21:10 Enrico Olivelli ha scritto: > >> I am not sure what is adding

[GitHub] zookeeper pull request #681: ZOOKEEPER-3176: Quorum TLS - add SSL config opt...

GitHub user ivmaykov reopened a pull request: https://github.com/apache/zookeeper/pull/681 ZOOKEEPER-3176: Quorum TLS - add SSL config options Add SSL config options for enabled protocols and client auth mode. Improve handling of SSL config options for protocols and cipher

[ANNOUNCE] New ZooKeeper committer: Fangmin Lv

The Apache ZooKeeper PMC recently extended committer karma to Fangmin and he has accepted. Fangmin has made some great contributions and we are looking forward to even more :) Congratulations and welcome aboard, Fangmin! Michael

[GitHub] zookeeper pull request #689: ZOOKEEPER-3183:Notifying the WatcherCleaner thr...

Github user tumativ commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/689#discussion_r231718078 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatcherCleaner.java --- @@ -50,6 +50,8 @@ private volatile

[GitHub] zookeeper issue #690: ZOOKEEPER-3179: Add snapshot compression to reduce the...

Github user yisong-yue commented on the issue: https://github.com/apache/zookeeper/pull/690 squashed two commits into one. ---

Re: [ANNOUNCE] New ZooKeeper committer: Fangmin Lv

Kudos Fangmin! Patrick On Wed, Nov 7, 2018 at 4:31 PM Michael Han wrote: > The Apache ZooKeeper PMC recently extended committer karma to Fangmin > and he has accepted. Fangmin has made some great contributions and we > are looking forward to even more :) > > > Congratulations and welcome

[GitHub] zookeeper issue #662: ZOOKEEPER-3162. Broken lock semantics in C client lock...

Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/662 Committed to 3.5 and master branches. Thanks @andreareale ! Please create separate pull request for branch-3.4 ---

[GitHub] zookeeper pull request #662: ZOOKEEPER-3162. Broken lock semantics in C clie...

Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/662 ---

Re: [ANNOUNCE] New ZooKeeper committer: Fangmin Lv

Repeating what was said in person - congratulations Fangmin! Andor > On 2018. Nov 7., at 16:31, Michael Han wrote: > > The Apache ZooKeeper PMC recently extended committer karma to Fangmin > and he has accepted. Fangmin has made some great contributions and we > are looking forward to even

[GitHub] zookeeper pull request #681: ZOOKEEPER-3176: Quorum TLS - add SSL config opt...

Github user ivmaykov closed the pull request at: https://github.com/apache/zookeeper/pull/681 ---

[jira] [Commented] (ZOOKEEPER-3162) Broken lock semantics in C client lock-recipe

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679247#comment-16679247 ] Hudson commented on ZOOKEEPER-3162: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #261 (See

Re: [ANNOUNCE] New ZooKeeper committer: Fangmin Lv

Congrats Fangmin! On Thu, Nov 8, 2018, 01:31 Michael Han The Apache ZooKeeper PMC recently extended committer karma to Fangmin > and he has accepted. Fangmin has made some great contributions and we > are looking forward to even more :) > > > Congratulations and welcome aboard, Fangmin! > >

[GitHub] zookeeper issue #689: ZOOKEEPER-3183:Notifying the WatcherCleaner thread and...

Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/689 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2607/ ---

Success: ZOOKEEPER- PreCommit Build #2607

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2607/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 85.60 MB...] [exec]

[GitHub] zookeeper issue #662: ZOOKEEPER-3162. Broken lock semantics in C client lock...

Github user andreareale commented on the issue: https://github.com/apache/zookeeper/pull/662 Hi @nkalmar, @tamaashu and thanks for the reviews. Any chance to see this merged any time soon? ---

[GitHub] zookeeper issue #662: ZOOKEEPER-3162. Broken lock semantics in C client lock...

Github user tamaashu commented on the issue: https://github.com/apache/zookeeper/pull/662 Since I'm not a committer I cannot do so. @anmolnar @hanm could you please review this PR? Thanks. ---

Jenkins build is back to normal : ZooKeeper-trunk-owasp #164

See

[GitHub] zookeeper issue #690: ZOOKEEPER-3179: Add snapshot compression to reduce the...

Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/690 retest this please ---

[GitHub] zookeeper issue #690: ZOOKEEPER-3179: Add snapshot compression to reduce the...

Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/690 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2609/ --nonenone-- ---

Failed: ZOOKEEPER- PreCommit Build #2608

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2608/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 85.29 MB...] [exec] Findbugs

[GitHub] zookeeper issue #690: ZOOKEEPER-3179: Add snapshot compression to reduce the...

Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/690 @yisong-yue sorry for the spam. There is a problem with the pre-commit job. I won't disturb you anymore on this PR ---

[GitHub] zookeeper pull request #691: This is only a test for Jenkins

GitHub user eolivelli opened a pull request: https://github.com/apache/zookeeper/pull/691 This is only a test for Jenkins You can merge this pull request into a Git repository by running: $ git pull https://github.com/eolivelli/zookeeper test Alternatively you can review and

[GitHub] zookeeper issue #690: ZOOKEEPER-3179: Add snapshot compression to reduce the...

Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/690 retest this please ---

Failed: ZOOKEEPER- PreCommit Build #2610

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2610/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 86.44 MB...] [exec]

[GitHub] zookeeper issue #690: ZOOKEEPER-3179: Add snapshot compression to reduce the...

Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/690 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2610/ --nonenone-- ---

[GitHub] zookeeper issue #690: ZOOKEEPER-3179: Add snapshot compression to reduce the...

Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/690 retest this please ---

[GitHub] zookeeper issue #690: ZOOKEEPER-3179: Add snapshot compression to reduce the...

Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/690 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2608/ ---

ZooKeeper_branch35_jdk8 - Build # 1185 - Failure

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1185/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 70.49 KB...] [junit] Tests run: 1, Failures:

[GitHub] zookeeper issue #691: This is only a test for Jenkins

Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/691 retest this please ---

[GitHub] zookeeper issue #691: This is only a test for Jenkins

Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/691 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2611/ ---

Failed: ZOOKEEPER- PreCommit Build #2611

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2611/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 86.16 MB...] [exec]

[GitHub] zookeeper issue #691: This is only a test for Jenkins

Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/691 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2612/ ---

[GitHub] zookeeper issue #691: This is only a test for Jenkins

Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/691 retest this please ---

[GitHub] zookeeper issue #691: This is only a test for Jenkins

Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/691 retest this please ---

[GitHub] zookeeper issue #691: This is only a test for Jenkins

Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/691 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2613/ ---

[GitHub] zookeeper issue #691: This is only a test for Jenkins

Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/691 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2614/ ---

[GitHub] zookeeper issue #691: This is only a test for Jenkins

Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/691 retest this please ---

[GitHub] zookeeper issue #689: ZOOKEEPER-3183:Notifying the WatcherCleaner thread and...

Github user tumativ commented on the issue: https://github.com/apache/zookeeper/pull/689 @anmolnar can I ask you merge pr if there is no review comments? ---

[GitHub] zookeeper issue #679: ZOOKEEPER-3172: Quorum TLS - fix port unification to a...

Github user ivmaykov commented on the issue: https://github.com/apache/zookeeper/pull/679 Rebase on latest master, no longer includes #678 as it has been merged upstream. ---

[GitHub] zookeeper issue #691: This is only a test for Jenkins

Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/691 retest this please ---

[jira] [Commented] (ZOOKEEPER-3175) Quorum TLS - test improvements

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678443#comment-16678443 ] Ilya Maykov commented on ZOOKEEPER-3175: Issue resolved by pull request 678

[jira] [Resolved] (ZOOKEEPER-3175) Quorum TLS - test improvements

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ilya Maykov resolved ZOOKEEPER-3175. Resolution: Fixed Assignee: Ilya Maykov Fix Version/s: 3.5.5