Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/722#discussion_r236150403
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LeaderBean.java
---
@@ -51,6 +51,15 @@ public String followerInfo() {
Andor Molnar created ZOOKEEPER-3204:
---
Summary: Reconfig tests are constantly failing on 3.5 after
applying Java 11 fix
Key: ZOOKEEPER-3204
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3204
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698659#comment-16698659
]
Ankit Kothana commented on ZOOKEEPER-3199:
--
Closing issue. Resolved.
> Unable to produce
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ankit Kothana resolved ZOOKEEPER-3199.
--
Resolution: Fixed
Found a bug in our script.
> Unable to produce verbose logs of
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk8/135/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 43.80 KB...]
[junit] Running
Github user ivmaykov commented on the issue:
https://github.com/apache/zookeeper/pull/679
@anmolnar renamed the tests and cleaned them up quite a bit too (the
formerly-DoS tests don't actually need a background thread for the bad client
socket, which simplifies things).
---
See https://builds.apache.org/job/ZooKeeper-trunk/284/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 322.20 KB...]
[exec] 7fb17df0a000-7fb17df0b000 rw-p
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/294
Hi, @anmolnar @eolivelli . Is there anything I need to do before we merge
this PR?
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-3205:
--
Labels: pull-request-available (was: )
> Jute - o.a.jute.BinaryInputArchive Test
GitHub user akkumar opened a pull request:
https://github.com/apache/zookeeper/pull/726
ZOOKEEPER-3205: o.a.jute test cases
Adding some test cases for o.a.jute BinaryInputArchive . Issue
ZOOKEEPER-3205 contains the patch as well.
You can merge this pull request into a Git
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/294
@anmolnar green lights from CI
This is a trivial patch, do you need another committer ?
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karthik K updated ZOOKEEPER-3205:
-
Attachment: (was: ZOOKEEPER-3205.patch)
> Jute - o.a.jute.BinaryInputArchive Test cases
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698826#comment-16698826
]
Rakesh R commented on ZOOKEEPER-3180:
-
[~lvfangmin], Feature looks pretty interesting and thanks
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk8/134/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 43.44 KB...]
[junit] Running
GitHub user ArtemChernatsky opened a pull request:
https://github.com/apache/zookeeper/pull/725
Zookeeper-3188: Improve resilience to network
According to issue
[ZOOKEEPER-3188](https://issues.apache.org/jira/browse/ZOOKEEPER-3188) added
ability to specify several addresses for
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-3188:
--
Labels: pull-request-available (was: )
> Improve resilience to network
>
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karthik K updated ZOOKEEPER-3205:
-
Summary: Jute - o.a.jute.BinaryInputArchive Test cases (was: Jute -
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karthik K updated ZOOKEEPER-3205:
-
Description:
o.a.j. BinaryInput(Output)Archive handles a bunch of serialization /
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karthik K updated ZOOKEEPER-3205:
-
Description:
o.a.j. BinaryInput(Output)Archive handles a bunch of serialization /
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karthik K updated ZOOKEEPER-3205:
-
Attachment: ZOOKEEPER-3205.patch
> Jute - o.a.jute.BinaryInputArchive Test cases
>
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karthik K updated ZOOKEEPER-3205:
-
Attachment: (was: ZOOKEEPER-3205.patch)
> Jute - o.a.jute.BinaryInputArchive Test cases
Github user tamaashu commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/692#discussion_r236299105
--- Diff: README.md ---
@@ -1,49 +1,24 @@
## Generating the static Apache ZooKeeper website
-In this directory you will find text files
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699223#comment-16699223
]
Karthik K commented on ZOOKEEPER-3205:
--
Revised version attached testing float and double
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karthik K updated ZOOKEEPER-3205:
-
Attachment: ZOOKEEPER-3205.patch
> Jute - o.a.j.BinaryInputArchive Test cases
>
Karthik K created ZOOKEEPER-3205:
Summary: Jute - o.a.j.BinaryInputArchive Test cases
Key: ZOOKEEPER-3205
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3205
Project: ZooKeeper
Issue
Github user ivmaykov commented on the issue:
https://github.com/apache/zookeeper/pull/679
@anmolnar removed DoS tests from `UnifiedServerSocketTest.java`. Added a
new unit test `UnifiedServerSocketModeDetectionTest.java` which checks that
calling certain methods on the server side of
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/703
@lvfangmin Thanks for the clarification!
Still testing your patch, should be done by tomorrow.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/679
@ivmaykov Gosh! I just did another round of review with your tests today
and was tending to accept the DoS tests with just renaming and amending the
comment. :)
Sorry for not responding
Github user ivmaykov commented on the issue:
https://github.com/apache/zookeeper/pull/679
I like the old DoS tests, I'm happy to restore them. The new unit test I
added can stay too.
---
Github user ivmaykov commented on the issue:
https://github.com/apache/zookeeper/pull/679
@anmolnar put the DoS tests back in. If you decide that you're ok with
keeping them, let me know what you'd like me to rename / comment.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/679
@ivmaykov I'm not a fan of them, but understand the intention and can't
figure out a more straightforward way to test the behaviour. So let's go with
them.
What do you think of renaming
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/724
retest this please
---
32 matches
Mail list logo
