[jira] [Resolved] (ZOOKEEPER-3172) Quorum TLS - fix port unification to allow rolling upgrades

2018-11-27 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-3172. - Resolution: Fixed Fix Version/s: 3.5.5 3.6.0 Issue

[GitHub] zookeeper issue #719: [ZOOKEEPER-2778] QuorumPeer: address potential reconfi...

2018-11-27 Thread mkedwards
Github user mkedwards commented on the issue: https://github.com/apache/zookeeper/pull/719 Does this look fit to merge? I'm not a committer, so I'll need help getting it merged. (The version targeted to branch-3.5 is #707.) ---

[GitHub] zookeeper issue #727: ZOOKEEPER-3172: Quorum TLS - fix port unification to a...

2018-11-27 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/727 @ivmaykov Committed. Thanks, please close this PR. ---

[GitHub] zookeeper issue #707: [ZOOKEEPER-2778] QuorumPeer: encapsulate addresses

2018-11-27 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/707 Let's see what @eolivelli saying, but I'd like to commit the other PR to master first and this one only if the other one fails to apply to 3.5. ---

[jira] [Commented] (ZOOKEEPER-2778) Potential server deadlock between follower sync with leader and follower receiving external connection requests.

2018-11-27 Thread Michael K. Edwards (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700689#comment-16700689 ] Michael K. Edwards commented on ZOOKEEPER-2778: --- The current versions of this patch

[GitHub] zookeeper issue #707: [ZOOKEEPER-2778] QuorumPeer: encapsulate addresses

2018-11-27 Thread mkedwards
Github user mkedwards commented on the issue: https://github.com/apache/zookeeper/pull/707 @eolivelli , have I addressed all your concerns? Does this look to you like a complete fix to ZOOKEEPER-2778? ---

[GitHub] zookeeper pull request #680: ZOOKEEPER-3174: Quorum TLS - support reloading ...

2018-11-27 Thread ivmaykov
GitHub user ivmaykov reopened a pull request: https://github.com/apache/zookeeper/pull/680 ZOOKEEPER-3174: Quorum TLS - support reloading trust/key store Allow reloading SSL trust stores and key stores from disk when the files on disk change. ## Added support for reloading

[GitHub] zookeeper pull request #680: ZOOKEEPER-3174: Quorum TLS - support reloading ...

2018-11-27 Thread ivmaykov
Github user ivmaykov closed the pull request at: https://github.com/apache/zookeeper/pull/680 ---

[GitHub] zookeeper issue #719: [ZOOKEEPER-2778] QuorumPeer: address potential reconfi...

2018-11-27 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/719 I'm waiting for @eolivelli 's feedback on the other PR. ---

[GitHub] zookeeper issue #707: [ZOOKEEPER-2778] QuorumPeer: encapsulate addresses

2018-11-27 Thread mkedwards
Github user mkedwards commented on the issue: https://github.com/apache/zookeeper/pull/707 That makes perfect sense. Thanks for keeping an eye on this. ---

[GitHub] zookeeper pull request #727: ZOOKEEPER-3172: Quorum TLS - fix port unificati...

2018-11-27 Thread ivmaykov
GitHub user ivmaykov opened a pull request: https://github.com/apache/zookeeper/pull/727 ZOOKEEPER-3172: Quorum TLS - fix port unification to allow rolling upgrades Fix numerous problems with UnifiedServerSocket, such as hanging the accept() thread when the client doesn't send any

[GitHub] zookeeper issue #727: ZOOKEEPER-3172: Quorum TLS - fix port unification to a...

2018-11-27 Thread ivmaykov
Github user ivmaykov commented on the issue: https://github.com/apache/zookeeper/pull/727 @anmolnar here is the branch-3.5 version of #679 ---

[GitHub] zookeeper issue #721: ZOOKEEPER-3046: wait for clients to reconnect after re...

2018-11-27 Thread mkedwards
Github user mkedwards commented on the issue: https://github.com/apache/zookeeper/pull/721 retest this please ---

[jira] [Commented] (ZOOKEEPER-3174) Quorum TLS - support reloading trust/key store

2018-11-27 Thread Ilya Maykov (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700818#comment-16700818 ] Ilya Maykov commented on ZOOKEEPER-3174: [~mkedwards] yes, I will make sure the fix is

[GitHub] zookeeper pull request #727: ZOOKEEPER-3172: Quorum TLS - fix port unificati...

2018-11-27 Thread ivmaykov
Github user ivmaykov closed the pull request at: https://github.com/apache/zookeeper/pull/727 ---

[GitHub] zookeeper issue #709: ZOOKEEPER-3194: Quorum TLS - fix copy/paste bug in ZKT...

2018-11-27 Thread ivmaykov
Github user ivmaykov commented on the issue: https://github.com/apache/zookeeper/pull/709 @anmolnar could you merge this into master and branch-3.5? ---

[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...

2018-11-27 Thread ivmaykov
Github user ivmaykov commented on the issue: https://github.com/apache/zookeeper/pull/680 @anmolnar I just stumbled across the FileMonitor class, which has similar functionality to my FileChangeWatcher. The main difference is that it polls for changes and sleeps the thread in

[GitHub] zookeeper pull request #726: ZOOKEEPER-3205: o.a.jute test cases

2018-11-27 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/726#discussion_r236804588 --- Diff: zookeeper-jute/src/test/java/org/apache/jute/BinaryInputArchiveTest.java --- @@ -41,4 +42,136 @@ public void testReadStringCheckLength() {

[GitHub] zookeeper issue #709: ZOOKEEPER-3194: Quorum TLS - fix copy/paste bug in ZKT...

2018-11-27 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/709 Committed. Thanks @ivmaykov ! ---

[jira] [Resolved] (ZOOKEEPER-3194) Quorum TLS - fix copy/paste bug in ZKTrustManager

2018-11-27 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-3194. - Resolution: Fixed Fix Version/s: 3.5.5 3.6.0 > Quorum TLS

[GitHub] zookeeper pull request #709: ZOOKEEPER-3194: Quorum TLS - fix copy/paste bug...

2018-11-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/709 ---

[jira] [Commented] (ZOOKEEPER-3194) Quorum TLS - fix copy/paste bug in ZKTrustManager

2018-11-27 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701091#comment-16701091 ] Hudson commented on ZOOKEEPER-3194: --- FAILURE: Integrated in Jenkins build

ZooKeeper_branch35_jdk8 - Build # 1209 - Still Failing

2018-11-27 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1209/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 66.03 KB...] [junit] Tests run: 1, Failures:

[jira] [Commented] (ZOOKEEPER-3194) Quorum TLS - fix copy/paste bug in ZKTrustManager

2018-11-27 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701143#comment-16701143 ] Hudson commented on ZOOKEEPER-3194: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #286 (See

[GitHub] zookeeper issue #726: ZOOKEEPER-3205: o.a.jute test cases

2018-11-27 Thread akkumar
Github user akkumar commented on the issue: https://github.com/apache/zookeeper/pull/726 Ok - in the logs I see this. Any suggestion what needs to be done to get this sorted out ? ``` [exec] [exec] [exec] Error: No value specified

[GitHub] zookeeper issue #726: ZOOKEEPER-3205: o.a.jute test cases

2018-11-27 Thread akkumar
Github user akkumar commented on the issue: https://github.com/apache/zookeeper/pull/726 The test cases seem to run with no failures. It is not obvious what caused the jenkins failure ? Any suggestions where to look for ? ---

[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...

2018-11-27 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/680 @ivmaykov No, I think it's fine to keep `FileChangeWatcher`. I keep looking... ---

[GitHub] zookeeper pull request #676: ZOOKEEPER-3181: ZOOKEEPER-2355 broke Curator Te...

2018-11-27 Thread aajisaka
Github user aajisaka closed the pull request at: https://github.com/apache/zookeeper/pull/676 ---

[GitHub] zookeeper issue #676: ZOOKEEPER-3181: ZOOKEEPER-2355 broke Curator TestingQu...

2018-11-27 Thread aajisaka
Github user aajisaka commented on the issue: https://github.com/apache/zookeeper/pull/676 Apache Curator 2.x release is likely to happen, so I close this PR. Thank you for your discussion. ---

[jira] [Resolved] (ZOOKEEPER-3181) ZOOKEEPER-2355 broke Curator TestingQuorumPeerMain

2018-11-27 Thread Akira Ajisaka (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka resolved ZOOKEEPER-3181. -- Resolution: Not A Problem This problem is likely to be fixed by Apache Curator

[GitHub] zookeeper pull request #726: ZOOKEEPER-3205: o.a.jute test cases

2018-11-27 Thread akkumar
Github user akkumar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/726#discussion_r236957794 --- Diff: zookeeper-jute/src/test/java/org/apache/jute/BinaryInputArchiveTest.java --- @@ -41,4 +42,136 @@ public void testReadStringCheckLength() {

[jira] [Resolved] (ZOOKEEPER-3193) Flaky: org.apache.zookeeper.test.SaslAuthFailNotifyTest

2018-11-27 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-3193. - Resolution: Fixed Fix Version/s: (was: 3.4.14) Issue resolved by pull

[GitHub] zookeeper pull request #706: ZOOKEEPER-3193 Flaky: org.apache.zookeeper.test...

2018-11-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/706 ---

[GitHub] zookeeper issue #706: ZOOKEEPER-3193 Flaky: org.apache.zookeeper.test.SaslAu...

2018-11-27 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/706 Committed to master and 3.5 branches. Thanks @eolivelli ! ---

[GitHub] zookeeper issue #294: ZOOKEEPER-2822: Wrong `ObjectName` about `MBeanServer`...

2018-11-27 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/294 Committed to master and 3.5 branches. Thanks @asdf2014 ! ---

[GitHub] zookeeper pull request #679: ZOOKEEPER-3172: Quorum TLS - fix port unificati...

2018-11-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/679 ---

[GitHub] zookeeper issue #679: ZOOKEEPER-3172: Quorum TLS - fix port unification to a...

2018-11-27 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/679 Thanks @ivmaykov ! Committed to master branch. Please create separate PR for 3.5, because it has some merge conflicts. ---

[jira] [Resolved] (ZOOKEEPER-2822) Wrong `ObjectName` about `MBeanServer` in JMX module

2018-11-27 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-2822. - Resolution: Fixed Issue resolved by pull request 294

[GitHub] zookeeper pull request #294: ZOOKEEPER-2822: Wrong `ObjectName` about `MBean...

2018-11-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/294 ---

[GitHub] zookeeper issue #692: ZOOKEEPER-3184: Use the same method to generate websit...

2018-11-27 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/692 @lvfangmin How about now? ---

[GitHub] zookeeper pull request #720: add an API to get total count of recursive sub ...

2018-11-27 Thread nkalmar
Github user nkalmar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/720#discussion_r236578709 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/ZooDefs.java --- @@ -50,6 +50,8 @@ public final int getChildren = 8;

[GitHub] zookeeper issue #294: ZOOKEEPER-2822: Wrong `ObjectName` about `MBeanServer`...

2018-11-27 Thread asdf2014
Github user asdf2014 commented on the issue: https://github.com/apache/zookeeper/pull/294 You are welcome. ---

[jira] [Commented] (ZOOKEEPER-3193) Flaky: org.apache.zookeeper.test.SaslAuthFailNotifyTest

2018-11-27 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700359#comment-16700359 ] Hudson commented on ZOOKEEPER-3193: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #285 (See

[jira] [Commented] (ZOOKEEPER-3172) Quorum TLS - fix port unification to allow rolling upgrades

2018-11-27 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700362#comment-16700362 ] Hudson commented on ZOOKEEPER-3172: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #285 (See

[jira] [Commented] (ZOOKEEPER-3172) Quorum TLS - fix port unification to allow rolling upgrades

2018-11-27 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700323#comment-16700323 ] Hudson commented on ZOOKEEPER-3172: --- SUCCESS: Integrated in Jenkins build

[jira] [Commented] (ZOOKEEPER-3193) Flaky: org.apache.zookeeper.test.SaslAuthFailNotifyTest

2018-11-27 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700321#comment-16700321 ] Hudson commented on ZOOKEEPER-3193: --- SUCCESS: Integrated in Jenkins build

[jira] [Commented] (ZOOKEEPER-2822) Wrong `ObjectName` about `MBeanServer` in JMX module

2018-11-27 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700322#comment-16700322 ] Hudson commented on ZOOKEEPER-2822: --- SUCCESS: Integrated in Jenkins build

[jira] [Commented] (ZOOKEEPER-2822) Wrong `ObjectName` about `MBeanServer` in JMX module

2018-11-27 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700361#comment-16700361 ] Hudson commented on ZOOKEEPER-2822: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #285 (See

[GitHub] zookeeper pull request #720: add an API to get total count of recursive sub ...

2018-11-27 Thread TyqITstudent
Github user TyqITstudent commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/720#discussion_r236655892 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/ZooDefs.java --- @@ -50,6 +50,8 @@ public final int getChildren =

[GitHub] zookeeper issue #689: ZOOKEEPER-3183:Notifying the WatcherCleaner thread and...

2018-11-27 Thread tumativ
Github user tumativ commented on the issue: https://github.com/apache/zookeeper/pull/689 @Ivfangmin any more changes? ---

ZooKeeper_branch35_jdk8 - Build # 1208 - Failure

2018-11-27 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1208/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 65.82 KB...] [junit] Running