[GitHub] anmolnar commented on issue #813: ZOOKEEPER-3028: MAVEN MIGRATION - 3.5 - Create maven assembly

2019-02-15 Thread GitBox
anmolnar commented on issue #813: ZOOKEEPER-3028: MAVEN MIGRATION - 3.5 - Create maven assembly URL: https://github.com/apache/zookeeper/pull/813#issuecomment-463975662 It's landed. Thanks @nkalmar ! This is an automated

[GitHub] anmolnar closed pull request #813: ZOOKEEPER-3028: MAVEN MIGRATION - 3.5 - Create maven assembly

2019-02-15 Thread GitBox
anmolnar closed pull request #813: ZOOKEEPER-3028: MAVEN MIGRATION - 3.5 - Create maven assembly URL: https://github.com/apache/zookeeper/pull/813 This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (ZOOKEEPER-3277) Add trace listener in NettyServerCnxnFactory only if trace logging is enabled

2019-02-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769452#comment-16769452 ] Hudson commented on ZOOKEEPER-3277: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #402 (See

[GitHub] anmolnar closed pull request #819: ZOOKEEPER-3272: Clean up netty4 code per Norman Maurer's review comments

2019-02-15 Thread GitBox
anmolnar closed pull request #819: ZOOKEEPER-3272: Clean up netty4 code per Norman Maurer's review comments URL: https://github.com/apache/zookeeper/pull/819 This is an automated message from the Apache Git Service. To

[GitHub] anmolnar commented on issue #819: ZOOKEEPER-3272: Clean up netty4 code per Norman Maurer's review comments

2019-02-15 Thread GitBox
anmolnar commented on issue #819: ZOOKEEPER-3272: Clean up netty4 code per Norman Maurer's review comments URL: https://github.com/apache/zookeeper/pull/819#issuecomment-464070068 I agree with @ivmaykov . Will merge it soon.

[GitHub] ivmaykov commented on issue #810: ZOOKEEPER-3274: Use CompositeByteBuf to queue data in NettyServerCnxn

2019-02-15 Thread GitBox
ivmaykov commented on issue #810: ZOOKEEPER-3274: Use CompositeByteBuf to queue data in NettyServerCnxn URL: https://github.com/apache/zookeeper/pull/810#issuecomment-464095278 Yes, it was something he suggested while reviewing #753. It should reduce buffer copies when throttling, and

ZooKeeper_branch35_jdk8 - Build # 1307 - Failure

2019-02-15 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1307/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 67.46 KB...] [junit] Tests run: 1, Failures:

[jira] [Resolved] (ZOOKEEPER-3272) Clean up netty4 code per Norman Maurer's review comments

2019-02-15 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-3272. - Resolution: Fixed Fix Version/s: 3.5.5 3.6.0 Issue

[jira] [Resolved] (ZOOKEEPER-3277) Add trace listener in NettyServerCnxnFactory only if trace logging is enabled

2019-02-15 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-3277. - Resolution: Fixed Fix Version/s: 3.5.5 3.6.0 Issue

[GitHub] anmolnar commented on issue #821: Fix ant package target: pom.template, zooinspector

2019-02-15 Thread GitBox
anmolnar commented on issue #821: Fix ant package target: pom.template, zooinspector URL: https://github.com/apache/zookeeper/pull/821#issuecomment-464016019 Committed to everywhere: master, 3.5, 3.4, 3.4.14. Thanks @eolivelli & @nkalmar !

[GitHub] asfgit closed pull request #821: Fix ant package target: pom.template, zooinspector

2019-02-15 Thread GitBox
asfgit closed pull request #821: Fix ant package target: pom.template, zooinspector URL: https://github.com/apache/zookeeper/pull/821 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] anmolnar commented on issue #819: ZOOKEEPER-3272: Clean up netty4 code per Norman Maurer's review comments

2019-02-15 Thread GitBox
anmolnar commented on issue #819: ZOOKEEPER-3272: Clean up netty4 code per Norman Maurer's review comments URL: https://github.com/apache/zookeeper/pull/819#issuecomment-464071169 Merged. Thanks @ivmaykov ! This is an

[GitHub] anmolnar commented on issue #820: ZOOKEEPER-3277: Add trace listener in NettyServerCnxnFactory only if trace logging is enabled

2019-02-15 Thread GitBox
anmolnar commented on issue #820: ZOOKEEPER-3277: Add trace listener in NettyServerCnxnFactory only if trace logging is enabled URL: https://github.com/apache/zookeeper/pull/820#issuecomment-464072140 Committed to master and 3.5. Thanks @ivmaykov !

[GitHub] asfgit closed pull request #820: ZOOKEEPER-3277: Add trace listener in NettyServerCnxnFactory only if trace logging is enabled

2019-02-15 Thread GitBox
asfgit closed pull request #820: ZOOKEEPER-3277: Add trace listener in NettyServerCnxnFactory only if trace logging is enabled URL: https://github.com/apache/zookeeper/pull/820 This is an automated message from the Apache

[jira] [Commented] (ZOOKEEPER-3277) Add trace listener in NettyServerCnxnFactory only if trace logging is enabled

2019-02-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769863#comment-16769863 ] Hudson commented on ZOOKEEPER-3277: --- SUCCESS: Integrated in Jenkins build

[jira] [Issue Comment Deleted] (ZOOKEEPER-3280) ClientCnxn xid rollover can break sessions

2019-02-15 Thread Liam (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liam updated ZOOKEEPER-3280: Comment: was deleted (was: Jonathan, completely not the space to be asking this. I am trying to

[jira] [Commented] (ZOOKEEPER-3280) ClientCnxn xid rollover can break sessions

2019-02-15 Thread Jonathan Park (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769876#comment-16769876 ] Jonathan Park commented on ZOOKEEPER-3280: -- Liam, I'm afraid I don't have the context to

[jira] [Commented] (ZOOKEEPER-3280) ClientCnxn xid rollover can break sessions

2019-02-15 Thread Liam (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769878#comment-16769878 ] Liam commented on ZOOKEEPER-3280: - In the apache site we have this list of know issues

[GitHub] normanmaurer commented on issue #810: ZOOKEEPER-3274: Use CompositeByteBuf to queue data in NettyServerCnxn

2019-02-15 Thread GitBox
normanmaurer commented on issue #810: ZOOKEEPER-3274: Use CompositeByteBuf to queue data in NettyServerCnxn URL: https://github.com/apache/zookeeper/pull/810#issuecomment-464268547 In general this looks good. If this is a win or not will depend a bit on what you do with the aggregated

[jira] [Updated] (ZOOKEEPER-3280) ClientCnxn xid rollover can break sessions

2019-02-15 Thread Jonathan Park (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Park updated ZOOKEEPER-3280: - Description:   {code:java} 2019-02-15 13:40:21,471 [myid:] - DEBUG

[jira] [Resolved] (ZOOKEEPER-3280) ClientCnxn xid rollover can break sessions

2019-02-15 Thread Jonathan Park (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Park resolved ZOOKEEPER-3280. -- Resolution: Duplicate > ClientCnxn xid rollover can break sessions >

[jira] [Commented] (ZOOKEEPER-3280) ClientCnxn xid rollover can break sessions

2019-02-15 Thread Jonathan Park (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769787#comment-16769787 ] Jonathan Park commented on ZOOKEEPER-3280: -- Indeed it is. My apologies, I looked for a

[jira] [Commented] (ZOOKEEPER-3280) ClientCnxn xid rollover can break sessions

2019-02-15 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769786#comment-16769786 ] Enrico Olivelli commented on ZOOKEEPER-3280: Seems like 

[jira] [Commented] (ZOOKEEPER-3280) ClientCnxn xid rollover can break sessions

2019-02-15 Thread Liam (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769800#comment-16769800 ] Liam commented on ZOOKEEPER-3280: - Jonathan, completely not the space to asking this. I am trying to

[jira] [Comment Edited] (ZOOKEEPER-3280) ClientCnxn xid rollover can break sessions

2019-02-15 Thread Liam (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769800#comment-16769800 ] Liam edited comment on ZOOKEEPER-3280 at 2/15/19 10:44 PM: --- Jonathan,

[jira] [Created] (ZOOKEEPER-3280) ClientCnxn xid rollover can break sessions

2019-02-15 Thread Jonathan Park (JIRA)
Jonathan Park created ZOOKEEPER-3280: Summary: ClientCnxn xid rollover can break sessions Key: ZOOKEEPER-3280 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3280 Project: ZooKeeper

[jira] [Commented] (ZOOKEEPER-3280) ClientCnxn xid rollover can break sessions

2019-02-15 Thread Liam (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769793#comment-16769793 ] Liam commented on ZOOKEEPER-3280: - Jonathan...can I bounce a qq off you? > ClientCnxn xid rollover

[jira] [Commented] (ZOOKEEPER-3280) ClientCnxn xid rollover can break sessions

2019-02-15 Thread Jonathan Park (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769796#comment-16769796 ] Jonathan Park commented on ZOOKEEPER-3280: -- Yes, go ahead unless you want to use a different

[GitHub] ivmaykov commented on issue #810: ZOOKEEPER-3274: Use CompositeByteBuf to queue data in NettyServerCnxn

2019-02-15 Thread GitBox
ivmaykov commented on issue #810: ZOOKEEPER-3274: Use CompositeByteBuf to queue data in NettyServerCnxn URL: https://github.com/apache/zookeeper/pull/810#issuecomment-464284238 > In general this looks good. If this is a win or not will depend a bit on what you do with the aggregated