Code to clean up transaction logs needs snapshots before it works?

2019-08-14 Thread Koen De Groote
Greetings all. I was debugging something an ran into this bit of code: https://github.com/apache/zookeeper/blob/master/zookeeper-server/src/main/java/org/apache/zookeeper/server/PurgeTxnLog.java#L81 If I understand it correctly, it seems that this means log.x files will only get deleted if

Build failed in Jenkins: PreCommit-ZOOKEEPER-github-pr-build-maven #1121

2019-08-14 Thread Apache Jenkins Server
See -- [...truncated 705.20 KB...] Generating

ZooKeeper_branch34_openjdk8 - Build # 420 - Failure

2019-08-14 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk8/420/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 44.80 KB...] [junit] Running

Re: Upgrade FAQ

2019-08-14 Thread Norbert Kalmar
Great, thanks Andor! On Wed, Aug 14, 2019 at 11:52 AM Andor Molnar wrote: > Hi, > > I’ve created the following FAQ page on the wiki to collect all upgrade > related issues and workarounds. > > https://cwiki.apache.org/confluence/display/ZOOKEEPER/Upgrade+FAQ > > Haven’t found any existing doc

Jenkins build is still unstable: zookeeper-master-maven-jdk11 #97

2019-08-14 Thread Apache Jenkins Server
See

Re: Code to clean up transaction logs needs snapshots before it works?

2019-08-14 Thread Norbert Kalmar
Hi, Without a snapshot, we cannot delete the log files, as we would have no means of recovery. txn logs applied to the snapshot gives us back the state. Without snapshot, all txn logs needs to be "replayed" in a recovery. And you need all the log files created since your last snapshot (in this

Jenkins build is back to normal : ZooKeeper-trunk-owasp #457

2019-08-14 Thread Apache Jenkins Server
See

Re: Code to clean up transaction logs needs snapshots before it works?

2019-08-14 Thread Koen De Groote
>Without a snapshot, we cannot delete the log files, as we would have no >means of recovery. txn logs applied to the snapshot gives us back the >state. Without snapshot, all txn logs needs to be "replayed" in a recovery. >And you need all the log files created since your last snapshot (in this

ZooKeeper_branch34_jdk8 - Build # 1894 - Failure

2019-08-14 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch34_jdk8/1894/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 43.39 KB...] [junit] Running

Re: Upgrade FAQ

2019-08-14 Thread Patrick Hunt
Good idea. thx. Patrick On Wed, Aug 14, 2019 at 5:54 AM Enrico Olivelli wrote: > Awesome > > Enrico > > Il mer 14 ago 2019, 14:00 Norbert Kalmar ha > scritto: > > > Great, thanks Andor! > > > > On Wed, Aug 14, 2019 at 11:52 AM Andor Molnar wrote: > > > > > Hi, > > > > > > I’ve created the

Upgrade FAQ

2019-08-14 Thread Andor Molnar
Hi, I’ve created the following FAQ page on the wiki to collect all upgrade related issues and workarounds. https://cwiki.apache.org/confluence/display/ZOOKEEPER/Upgrade+FAQ Haven’t found any existing doc on the topic, hence I’ve created this one quickly. We might want to move it to the

Build failed in Jenkins: zookeeper-master-maven-owasp #95

2019-08-14 Thread Apache Jenkins Server
See -- [...truncated 263.05 KB...] Generating

[jira] [Created] (ZOOKEEPER-3506) correct the SessionTrackerImpl#initializeNextSession's java doc about how to generate the sessionId

2019-08-14 Thread maoling (JIRA)
maoling created ZOOKEEPER-3506: -- Summary: correct the SessionTrackerImpl#initializeNextSession's java doc about how to generate the sessionId Key: ZOOKEEPER-3506 URL:

[jira] [Created] (ZOOKEEPER-3507) Revisit name patterns

2019-08-14 Thread TisonKun (JIRA)
TisonKun created ZOOKEEPER-3507: --- Summary: Revisit name patterns Key: ZOOKEEPER-3507 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3507 Project: ZooKeeper Issue Type: Improvement

Re: Upgrade FAQ

2019-08-14 Thread Enrico Olivelli
Awesome Enrico Il mer 14 ago 2019, 14:00 Norbert Kalmar ha scritto: > Great, thanks Andor! > > On Wed, Aug 14, 2019 at 11:52 AM Andor Molnar wrote: > > > Hi, > > > > I’ve created the following FAQ page on the wiki to collect all upgrade > > related issues and workarounds. > > > >

Re: Code to clean up transaction logs needs snapshots before it works?

2019-08-14 Thread Norbert Kalmar
Read doesn't matter, there will be no txn logs for read. Only modifications are logged (state changes to the datatree). As for why all txn logs are 64MB: "preAllocSize (Java system property: zookeeper.preAllocSize) To avoid seeks ZooKeeper allocates space in the transaction log file in blocks of

Jenkins build is back to normal : PreCommit-ZOOKEEPER-github-pr-build-maven #1122

2019-08-14 Thread Apache Jenkins Server
See

Jenkins build became unstable: PreCommit-ZOOKEEPER-github-pr-build-maven #1123

2019-08-14 Thread Apache Jenkins Server
See

ZooKeeper_branch35_jdk8 - Build # 1505 - Still Failing

2019-08-14 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1505/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 71.04 KB...] [junit] Tests run: 1, Failures:

[jira] [Created] (ZOOKEEPER-3509) Revisit log format

2019-08-14 Thread TisonKun (JIRA)
TisonKun created ZOOKEEPER-3509: --- Summary: Revisit log format Key: ZOOKEEPER-3509 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3509 Project: ZooKeeper Issue Type: Improvement

Build failed in Jenkins: PreCommit-ZOOKEEPER-github-pr-build-maven #1125

2019-08-14 Thread Apache Jenkins Server
See -- [...truncated 436.25 KB...] [INFO] Downloading from central: https://repo.maven.apache.org/maven2/asm/asm/3.3.1/asm-3.3.1.pom [INFO] Downloaded from

Re: Code to clean up transaction logs needs snapshots before it works?

2019-08-14 Thread Koen De Groote
Al right, I'll try and go forward with that info. Thanks. On Wed, Aug 14, 2019 at 2:55 PM Norbert Kalmar wrote: > Read doesn't matter, there will be no txn logs for read. Only modifications > are logged (state changes to the datatree). > > As for why all txn logs are 64MB: > "preAllocSize >

Jenkins build is back to normal : PreCommit-ZOOKEEPER-github-pr-build-maven #1126

2019-08-14 Thread Apache Jenkins Server
See

Re: Code to clean up transaction logs needs snapshots before it works?

2019-08-14 Thread Ted Dunning
On Wed, Aug 14, 2019 at 5:35 AM Koen De Groote wrote: > ... > I've read that the log files are preallocated. I see them as being 65MB a > piece. > Yes. Preallocation of logs is an important performance trick. The point is that if a file doesn't change length when you write to it, then the file

[jira] [Created] (ZOOKEEPER-3508) Strategy on line break

2019-08-14 Thread TisonKun (JIRA)
TisonKun created ZOOKEEPER-3508: --- Summary: Strategy on line break Key: ZOOKEEPER-3508 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3508 Project: ZooKeeper Issue Type: Improvement

Build failed in Jenkins: PreCommit-ZOOKEEPER-github-pr-build-maven #1124

2019-08-14 Thread Apache Jenkins Server
See -- [...truncated 436.30 KB...] [INFO] Downloading from central: https://repo.maven.apache.org/maven2/asm/asm/3.3.1/asm-3.3.1.pom [INFO] Downloaded from

Re: [jira] [Updated] (ZOOKEEPER-1112) Add support for C client for SASL authentication

2019-08-14 Thread Damien Diederen
Greetings, all, Note sure how notifications work on this project, but in case it did not pop up on your radar: I have picked up ZOOKEEPER-1112, which was dormant since 2011, and pushed a first set of patches: https://github.com/apache/zookeeper/pull/1054 Reviews and/or comments would be

Re: [jira] [Updated] (ZOOKEEPER-1112) Add support for C client for SASL authentication

2019-08-14 Thread Ted Dunning
Kudos to you for this! On Wed, Aug 14, 2019 at 10:55 AM Damien Diederen wrote: > > Greetings, all, > > Note sure how notifications work on this project, but in case it did not > pop up on your radar: I have picked up ZOOKEEPER-1112, which was dormant > since 2011, and pushed a first set of

Jenkins build is unstable: zookeeper-master-maven-jdk12 #93

2019-08-14 Thread Apache Jenkins Server
See