No tag for 3.6.0?

2020-04-14 Thread Christopher
Hi ZK Devs, I don't see a tag for 3.6.0 in git. Is there one available that hasn't been pushed? Thanks, Christopher

Re: Cutting 3.6.1 HEADS UP !

2020-04-14 Thread Christopher
Okay, I found the problem. The exec-maven-plugin seems to ignore the now-empty: ${mvngit.commit.id} This is a bug in either exec-maven-plugin or maven itself when parsing config, possibly related to: https://github.com/mojohaus/exec-maven-plugin/issues/132 I provided a pull request to fix it in:

Re: No tag for 3.6.0?

2020-04-14 Thread Patrick Hunt
No worries at all. That does seem odd, perhaps it's related to having multiple remotes? Regards, Patrick On Tue, Apr 14, 2020 at 7:38 PM Christopher wrote: > This was a weird client-side error with git... not sure why it wasn't > working, but `git remote update` wasn't fetching tags for some

Re: No tag for 3.6.0?

2020-04-14 Thread Patrick Hunt
Christopher - I believe it's release-3.6.0 - I have it from either gh or apache gitbox, eg: https://github.com/apache/zookeeper/tree/release-3.6.0 Patrick On Tue, Apr 14, 2020 at 6:26 PM Christopher wrote: > Hi ZK Devs, > > I don't see a tag for 3.6.0 in git. Is there one available that hasn't

Re: No tag for 3.6.0?

2020-04-14 Thread Christopher
This was a weird client-side error with git... not sure why it wasn't working, but `git remote update` wasn't fetching tags for some reason. I did `git fetch --tags`, then `git tag --delete $(git tag)`, then `git remote update` and it worked. So weird. Sorry for the noise. On Tue, Apr 14, 2020 at

Re: Cutting 3.6.1 HEADS UP !

2020-04-14 Thread Christopher
On Sun, Apr 12, 2020 at 12:39 PM Enrico Olivelli wrote: > > Christopher > Maybe with your commit a93ff0fe631d1c96ee056a79e3c16535ab33c794 we have > broken the source release tarball. Possibly. I patched 3.7/master. I wasn't involved in the backport to 3.6 and did not test it there. Speaking of

Re: No tag for 3.6.0?

2020-04-14 Thread Christopher
Possibly. It could also be related to the fact that I renamed my `origin` to `asf` after cloning it. I've seen this issue with git once before, but no idea why. Maybe I'll look into it some time. :) On Tue, Apr 14, 2020 at 11:44 PM Patrick Hunt wrote: > > No worries at all. That does seem odd,

Re: NullPointerException while shutting down ZK server

2020-04-14 Thread Enrico Olivelli
Andor, Il giorno lun 13 apr 2020 alle ore 19:59 Andor Molnar ha scritto: > Hi, > > "...during the shutdown of ZooKeeper Server" > > How do you trigger that? > ZooKeeper is designed to be killed. I'm not aware of a "standard" > shutdown procedure. > You are right, in fact I am in a test case,