[GitHub] zookeeper issue #375: ZOOKEEPER-1363: Categorise unit tests by 'test-commit'...

2017-10-19 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/375 Hi, This patch would be extremely useful for analysing flaky tests. Any plans for merging it? ---

[GitHub] zookeeper issue #402: ZOOKEEPER-2922: Flaky Test fix: org.apache.zookeeper.t...

2017-10-24 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/402 @afine Here is the command I've extracted from build logs showing that junit runs tests on 8 threads: `[ZooKeeper_branch34_jdk8] $ ant -Dtest.output=yes -Dtest.junit.threads=8

[GitHub] zookeeper issue #415: ZOOKEEPER-2939: Added last/min/max proposal size JMX b...

2017-11-15 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/415 @phunt Thanks for looking into this. I'll include the reset capability into this patch as suggested. ---

[GitHub] zookeeper pull request #420: ZOOKEEPER-2924. Refactor tests of LoadFromLogTe...

2017-11-28 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/420#discussion_r153610044 --- Diff: src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java --- @@ -18,77 +18,58 @@ package org.apache.zookeeper.test

[GitHub] zookeeper issue #420: ZOOKEEPER-2924. Refactor tests of LoadFromLogTest.java

2017-11-25 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/420 @phunt I rebased the branch on trunk and the build is now green. Thanks. Please review. ---

[GitHub] zookeeper issue #420: ZOOKEEPER-2924. Refactor tests of LoadFromLogTest.java

2017-11-29 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/420 @phunt @afine thanks for the detail comments. I think @afine made a good point, I've removed setting the SnapCount explicitly in each test, leaving only a common setting in the setUp method

[GitHub] zookeeper issue #420: ZOOKEEPER-2924. Refactor tests of LoadFromLogTest.java

2017-11-30 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/420 Tests don't seem to be related to the snapCount apart from the 2 that @afine mentioned previously. This way we can keep the structure of this testfile nice and clean with doing

[GitHub] zookeeper issue #420: ZOOKEEPER-2924. Refactor tests of LoadFromLogTest.java

2017-12-02 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/420 @phunt Correct. These 2 tests: testLoad and testLoadFailure make assertion on the number of log files. Rest of the tests don't care. Originally they've reset snapCount to 1 to produce only 1

[GitHub] zookeeper issue #300: ZOOKEEPER-2807: Flaky test: org.apache.zookeeper.test....

2017-12-02 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/300 @afine If I'm not mistaken there's a thread running which receives messages from the Leader in QuorumPeer.java:997: Call stack is: QuorumPeer.run() -> Follower.followLea

[GitHub] zookeeper issue #300: ZOOKEEPER-2807: Flaky test: org.apache.zookeeper.test....

2017-12-04 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/300 @afine You're right. I missed that syncWithLeader() call is on the same path and in the same thread as adding commits to the queue. In which case this must be right: - syncWithLeader

[GitHub] zookeeper pull request #300: ZOOKEEPER-2807: Flaky test: org.apache.zookeepe...

2017-12-04 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/300#discussion_r154851878 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java --- @@ -240,84 +240,14 @@ public void run

[GitHub] zookeeper pull request #423: ZOOKEEPER-2949: using hostname and port to crea...

2017-12-01 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/423#discussion_r154133881 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxnSocketNetty.java --- @@ -340,13 +340,24 @@ public static Packet getInstance

[GitHub] zookeeper pull request #430: ZOOKEEPER-2893. very poor choice of logging if ...

2017-12-13 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/430#discussion_r156597536 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -1232,11 +1233,12 @@ public void run() { } else if (e

[GitHub] zookeeper pull request #430: ZOOKEEPER-2893. very poor choice of logging if ...

2017-12-13 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/430#discussion_r156599702 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -1041,6 +1041,8 @@ private void sendPing() { private

[GitHub] zookeeper pull request #430: ZOOKEEPER-2893. very poor choice of logging if ...

2017-12-14 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/430#discussion_r156952287 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -1236,7 +1237,7 @@ public void run

[GitHub] zookeeper issue #415: ZOOKEEPER-2939: Added last/min/max proposal size JMX b...

2017-12-14 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/415 @phunt That's a perfectly valid point Pat, I've been asked about it several times before. Therefore I added some more comments to the parent Jira of monitoring, please take a look

[GitHub] zookeeper pull request #430: ZOOKEEPER-2893. very poor choice of logging if ...

2017-12-14 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/430#discussion_r156951799 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -1041,6 +1041,8 @@ private void sendPing() { private

[GitHub] zookeeper pull request #409: ZOOKEEPER-2924: Refactor tests of LoadFromLogTe...

2017-12-12 Thread anmolnar
Github user anmolnar closed the pull request at: https://github.com/apache/zookeeper/pull/409 ---

[GitHub] zookeeper pull request #433: ZOOKEEPER-2953: Flaky Test: testNoLogBeforeLead...

2017-12-14 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/433#discussion_r157001279 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -335,6 +336,100 @@ public void testHighestZxidJoinLate

[GitHub] zookeeper pull request #433: ZOOKEEPER-2953: Flaky Test: testNoLogBeforeLead...

2017-12-14 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/433#discussion_r157001258 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -335,6 +336,100 @@ public void testHighestZxidJoinLate

[GitHub] zookeeper issue #429: ZOOKEEPER-2952. Upgrade third party libs: netty, slf4j

2017-12-13 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/429 @phunt I've updated the slf4j license. ---

[GitHub] zookeeper pull request #435: ZOOKEEPER-2952. Upgrade third party libs: netty...

2017-12-13 Thread anmolnar
GitHub user anmolnar opened a pull request: https://github.com/apache/zookeeper/pull/435 ZOOKEEPER-2952. Upgrade third party libs: netty, slf4j, log4j This is the branch-3.4 version of https://github.com/apache/zookeeper/pull/429 netty, log4j, slf4j You can merge

[GitHub] zookeeper issue #430: ZOOKEEPER-2893. very poor choice of logging if client ...

2017-12-18 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/430 @paulmillar Please approve it, if you're happy with the change. @phunt Do you think it can be committed? ---

[GitHub] zookeeper issue #415: ZOOKEEPER-2939: Added last/min/max proposal size JMX b...

2017-12-18 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/415 @phunt I asked around quickly: HBase - own library (looks like they've started to use dropwizard somehow) HDFS - Hadoop Metrics2 (included in hadoop-common) Kafka - Yammer (dropwizard

[GitHub] zookeeper pull request #430: ZOOKEEPER-2893. very poor choice of logging if ...

2017-12-15 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/430#discussion_r157266599 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -1231,14 +1231,14 @@ public void run() { LOG.info

[GitHub] zookeeper issue #415: ZOOKEEPER-2939: Added last/min/max proposal size JMX b...

2017-12-15 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/415 @phunt I added proposal stats to 'mntr' command output as requested. In the meantime I found the following metrics lib which could be useful and easily integrated into Zookeeper

[GitHub] zookeeper pull request #435: ZOOKEEPER-2952. Upgrade third party libs: netty...

2017-12-13 Thread anmolnar
Github user anmolnar closed the pull request at: https://github.com/apache/zookeeper/pull/435 ---

[GitHub] zookeeper pull request #432: [WIP] ZOOKEEPER-2953: Flaky Test: testNoLogBefo...

2017-12-13 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/432#discussion_r156660196 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -335,6 +336,100 @@ public void testHighestZxidJoinLate

[GitHub] zookeeper issue #432: [WIP] ZOOKEEPER-2953: Flaky Test: testNoLogBeforeLeade...

2017-12-13 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/432 @afine Generally the new test looks good to me, but would you please elaborate why the old test was flaky and how the new fixes that? ---

[GitHub] zookeeper pull request #432: [WIP] ZOOKEEPER-2953: Flaky Test: testNoLogBefo...

2017-12-13 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/432#discussion_r156658012 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -335,6 +336,100 @@ public void testHighestZxidJoinLate

[GitHub] zookeeper pull request #432: [WIP] ZOOKEEPER-2953: Flaky Test: testNoLogBefo...

2017-12-13 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/432#discussion_r156657072 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -335,6 +336,100 @@ public void testHighestZxidJoinLate

[GitHub] zookeeper issue #432: [WIP] ZOOKEEPER-2953: Flaky Test: testNoLogBeforeLeade...

2017-12-13 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/432 @afine got it ---

[GitHub] zookeeper pull request #432: [WIP] ZOOKEEPER-2953: Flaky Test: testNoLogBefo...

2017-12-13 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/432#discussion_r156793172 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -335,6 +336,100 @@ public void testHighestZxidJoinLate

[GitHub] zookeeper pull request #420: ZOOKEEPER-2924. Refactor tests of LoadFromLogTe...

2017-11-17 Thread anmolnar
GitHub user anmolnar opened a pull request: https://github.com/apache/zookeeper/pull/420 ZOOKEEPER-2924. Refactor tests of LoadFromLogTest.java This patch is the trunk version of https://github.com/apache/zookeeper/pull/409 You can merge this pull request into a Git repository

[GitHub] zookeeper issue #415: ZOOKEEPER-2939: Added last/min/max proposal size JMX b...

2017-11-11 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/415 @afine Thanks for approving. I've added the same byte array verification to the other unit test too. Also squashed everything into single commit. Ready to merge. ---

[GitHub] zookeeper issue #415: ZOOKEEPER-2939: Added last/min/max proposal size JMX b...

2017-11-21 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/415 @afine You're not missing anything, I didn't add jetty support to this patch intentionally, because afaik jetty is not supported in 3.4. So the plan is to keep this patch compatible with all

[GitHub] zookeeper issue #415: ZOOKEEPER-2939: Added last/min/max proposal size JMX b...

2017-11-18 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/415 @phunt 4lw changes have been added. @afine please start the review over, because so many things have been changed since you approved it. For some weird reason I cannot get a green

[GitHub] zookeeper pull request #415: ZOOKEEPER-2939: Added last/min/max proposal siz...

2017-11-21 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/415#discussion_r152276479 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/StatCommandTest.java --- @@ -0,0 +1,106 @@ +/** + * Licensed to the Apache Software

[GitHub] zookeeper pull request #415: ZOOKEEPER-2939: Added last/min/max proposal siz...

2017-11-21 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/415#discussion_r152276508 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/StatResetCommandTest.java --- @@ -0,0 +1,112 @@ +/** + * Licensed to the Apache

[GitHub] zookeeper issue #415: ZOOKEEPER-2939: Added last/min/max proposal size JMX b...

2017-11-16 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/415 @phunt I've added capability of resetting proposal statistics as well as unit tests for LeaderBean class. ---

[GitHub] zookeeper issue #415: ZOOKEEPER-2939: Added last/min/max proposal size JMX b...

2017-11-16 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/415 @phunt Sorry, I've completely forgotten about it. I believe the easiest would be to add proposal stats to 'stat' 4lw in this patch, so that it could be easily applied to all major branches

[GitHub] zookeeper pull request #412: ZOOKEEPER-2101: Transaction larger than max buf...

2017-11-05 Thread anmolnar
Github user anmolnar closed the pull request at: https://github.com/apache/zookeeper/pull/412 ---

[GitHub] zookeeper issue #412: ZOOKEEPER-2101: Transaction larger than max buffer of ...

2017-11-05 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/412 I'm unable to create proper unit test for the issue, because cannot reliably reproduce the problem. Closing this PR. ---

[GitHub] zookeeper issue #412: ZOOKEEPER-2101: Transaction larger than max buffer of ...

2017-11-02 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/412 Thanks @afine for looking into this and the detailed explanation. Unfortunately I cannot answer your question whether there could be other cases than multi when proposal size is bigger

[GitHub] zookeeper pull request #415: ZOOKEEPER-2933: Added last/min/max proposal siz...

2017-11-09 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/415#discussion_r149945747 --- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServerBean.java --- @@ -167,4 +167,9 @@ public String getSecureClientAddress

[GitHub] zookeeper pull request #415: ZOOKEEPER-2933: Added last/min/max proposal siz...

2017-11-09 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/415#discussion_r149947085 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/LeaderStatsTest.java --- @@ -0,0 +1,39 @@ +/** + * Licensed to the Apache Software

[GitHub] zookeeper pull request #415: ZOOKEEPER-2933: Added last/min/max proposal siz...

2017-11-09 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/415#discussion_r149946142 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java --- @@ -984,8 +990,6 @@ public void commitAndActivate(long zxid, long

[GitHub] zookeeper pull request #415: ZOOKEEPER-2933: Added last/min/max proposal siz...

2017-11-09 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/415#discussion_r149946634 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/LeaderStatsTest.java --- @@ -0,0 +1,39 @@ +/** + * Licensed to the Apache Software

[GitHub] zookeeper pull request #415: ZOOKEEPER-2933: Added last/min/max proposal siz...

2017-11-09 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/415#discussion_r149946468 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/LeaderStats.java --- @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache Software

[GitHub] zookeeper pull request #415: ZOOKEEPER-2933: Added last/min/max proposal siz...

2017-11-09 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/415#discussion_r149946413 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/LeaderStats.java --- @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache Software

[GitHub] zookeeper pull request #415: ZOOKEEPER-2933: Added last/min/max proposal siz...

2017-11-09 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/415#discussion_r149945916 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java --- @@ -34,12 +33,12 @@ import java.util.List; import java.util.Map

[GitHub] zookeeper issue #415: ZOOKEEPER-2933: Added last/min/max proposal size JMX b...

2017-11-09 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/415 @afine I've created 2 subtasks for the Jira as you suggested and changed this PR to refer to the right one. ---

[GitHub] zookeeper pull request #415: ZOOKEEPER-2933: Added last/min/max proposal siz...

2017-11-09 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/415#discussion_r149948702 --- Diff: src/java/test/org/apache/zookeeper/server/util/SerializeUtilsTest.java --- @@ -0,0 +1,73 @@ +/** + * Licensed to the Apache Software

[GitHub] zookeeper issue #415: ZOOKEEPER-2939: Added last/min/max proposal size JMX b...

2017-11-09 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/415 @afine Take a look at please the latest commit, I've added verification of the byte array itself to serializeRequest() unit test. I'm not 100% sure it's needed, but it might makes sense this way. ---

[GitHub] zookeeper pull request #416: ZOOKEEPER-2934: Updated usage of LOG_DEBUG in r...

2017-11-09 Thread anmolnar
GitHub user anmolnar opened a pull request: https://github.com/apache/zookeeper/pull/416 ZOOKEEPER-2934: Updated usage of LOG_DEBUG in recipes to follow changes in ZK client LOG_DEBUG macro has been changed recently in https://issues.apache.org/jira/browse/ZOOKEEPER-1400

[GitHub] zookeeper pull request #415: ZOOKEEPER-2933: Added last/min/max proposal siz...

2017-11-08 Thread anmolnar
GitHub user anmolnar opened a pull request: https://github.com/apache/zookeeper/pull/415 ZOOKEEPER-2933: Added last/min/max proposal size JMX beans https://issues.apache.org/jira/browse/ZOOKEEPER-2933 - Refactor proposal serialization logic to a common place (SerializeUtils

[GitHub] zookeeper issue #409: ZOOKEEPER-2924: Refactor tests of LoadFromLogTest.java

2017-11-08 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/409 @phunt Do you think we can merge this now into branch-3.4? ---

[GitHub] zookeeper issue #409: ZOOKEEPER-2924: Refactor tests of LoadFromLogTest.java

2017-11-01 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/409 @phunt would you please kindly commit this patch? ---

[GitHub] zookeeper issue #413: WriteLock recipe: Fix bug in znode ordering when the s...

2017-11-03 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/413 @javicacheiro The change looks good to me. I believe too that it'd be nice to add some unit tests to validate the comparison. ---

[GitHub] zookeeper issue #410: [ZOOKEEPER-2338] - set SOCK_CLOEXEC on socket if defin...

2017-11-03 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/410 @fr0stbyte Reading some Stackoverflow about the flag (https://stackoverflow.com/questions/22304631/what-is-the-purpose-to-set-sock-cloexec-flag-with-accept4-same-as-o-cloexec), the change looks

[GitHub] zookeeper pull request #413: WriteLock recipe: Fix bug in znode ordering whe...

2017-11-06 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/413#discussion_r149077678 --- Diff: src/recipes/lock/test/org/apache/zookeeper/recipes/lock/ZNodeNameTest.java --- @@ -37,17 +37,30 @@ public void testOrderWithSamePrefix

[GitHub] zookeeper issue #409: ZOOKEEPER-2924: Refactor tests of LoadFromLogTest.java

2017-12-08 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/409 @phunt Patch has been updated with the trunk review changes. Please take a look. ---

[GitHub] zookeeper issue #415: ZOOKEEPER-2939: Added last/min/max proposal size JMX b...

2017-12-04 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/415 @afine @phunt Findbugs issues have been resolved. Please review & commit. ---

[GitHub] zookeeper pull request #300: ZOOKEEPER-2807: Flaky test: org.apache.zookeepe...

2017-12-01 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/300#discussion_r154363054 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java --- @@ -327,6 +257,95 @@ public void run() { LOG.info

[GitHub] zookeeper pull request #300: ZOOKEEPER-2807: Flaky test: org.apache.zookeepe...

2017-12-01 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/300#discussion_r154367742 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java --- @@ -240,84 +240,14 @@ public void run

[GitHub] zookeeper issue #300: ZOOKEEPER-2807: Flaky test: org.apache.zookeeper.test....

2017-12-01 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/300 @afine Generally speaking, I like the idea of using LinkedBlockingQueue's intrinsic lock to wait for becoming empty, but in this particular case I think it's possible that committedRequests

[GitHub] zookeeper issue #420: ZOOKEEPER-2924. Refactor tests of LoadFromLogTest.java

2017-12-05 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/420 @phunt do you still have concerns? ---

[GitHub] zookeeper issue #415: ZOOKEEPER-2939: Added last/min/max proposal size JMX b...

2017-12-05 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/415 @phunt do you think we can commit this patch? ---

[GitHub] zookeeper pull request #300: ZOOKEEPER-2807: Flaky test: org.apache.zookeepe...

2017-12-05 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/300#discussion_r155103949 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java --- @@ -240,84 +240,14 @@ public void run

[GitHub] zookeeper issue #300: ZOOKEEPER-2807: Flaky test: org.apache.zookeeper.test....

2017-12-05 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/300 +1 looks good to me. @afine Would you please trigger another build to get a green one? ---

[GitHub] zookeeper issue #409: ZOOKEEPER-2924: Refactor tests of LoadFromLogTest.java

2017-12-07 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/409 @phunt Yes, I'm working on it. ---

[GitHub] zookeeper issue #427: [ZOOKEEPER-2338] - set SOCK_CLOEXEC on socket if defin...

2017-12-10 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/427 @fr0stbyte no thanks, that's fine, I've dug it out already. Going forward I suggest to make linter / indentation / whitespace changes in a commit separate from the code changes. ---

[GitHub] zookeeper issue #415: ZOOKEEPER-2939: Added last/min/max proposal size JMX b...

2017-12-11 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/415 @phunt @afine are u happy with the change? ---

[GitHub] zookeeper issue #409: ZOOKEEPER-2924: Refactor tests of LoadFromLogTest.java

2017-12-11 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/409 @phunt Build is green now. Please review & commit if you have a chance. ---

[GitHub] zookeeper pull request #429: ZOOKEEPER-2952. Upgrade third party libs: netty...

2017-12-12 Thread anmolnar
GitHub user anmolnar opened a pull request: https://github.com/apache/zookeeper/pull/429 ZOOKEEPER-2952. Upgrade third party libs: netty, slf4j You can merge this pull request into a Git repository by running: $ git pull https://github.com/anmolnar/zookeeper ZOOKEEPER-2952

[GitHub] zookeeper pull request #430: ZOOKEEPER-2893. Make 'addr' variable available ...

2017-12-12 Thread anmolnar
GitHub user anmolnar opened a pull request: https://github.com/apache/zookeeper/pull/430 ZOOKEEPER-2893. Make 'addr' variable available for error handling code to give a chance to fallback if the socket hasn't been initialized yet 'addr' variable is used to identify which server

[GitHub] zookeeper issue #410: [ZOOKEEPER-2338] - set SOCK_CLOEXEC on socket if defin...

2017-12-06 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/410 @fr0stbyte According to my tiny C knowledge, it looks good to me. ---

[GitHub] zookeeper issue #409: ZOOKEEPER-2924: Refactor tests of LoadFromLogTest.java

2017-10-30 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/409 Thanks @afine . I've updated the PR. ---

[GitHub] zookeeper pull request #412: ZOOKEEPER-2101: Transaction larger than max buf...

2017-10-30 Thread anmolnar
GitHub user anmolnar opened a pull request: https://github.com/apache/zookeeper/pull/412 ZOOKEEPER-2101: Transaction larger than max buffer of jute makes zookeeper unavailable This patch has been created to reanimate an ancient, unclosed Jira: https://issues.apache.org/jira

[GitHub] zookeeper issue #411: ZOOKEEPER-2684 Fix a crashing bug in the mixed workloa...

2017-10-30 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/411 @kfirlevari yeah, that's an outstanding flaky test. Here's the jira about it: https://issues.apache.org/jira/browse/ZOOKEEPER-2807 Amend your latest commit to trigger another Jenkins

[GitHub] zookeeper issue #404: ZOOKEEPER-2690: Update documentation source for ZOOKEE...

2017-10-25 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/404 This change looks good to me. ---

[GitHub] zookeeper issue #402: ZOOKEEPER-2922: Flaky Test fix: org.apache.zookeeper.t...

2017-10-24 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/402 @afine Do you think it's better to cancel this change? Affected tests have been running fine for a couple of builds. ---

[GitHub] zookeeper issue #403: Zookeeper 2923

2017-10-24 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/403 You could use git rebase command to squash/fixup the commits to merge them into one. http://fle.github.io/git-tip-keep-your-branch-clean-with-fixup-and-autosquash.html Rebasing

[GitHub] zookeeper issue #402: ZOOKEEPER-2922: Flaky Test fix: org.apache.zookeeper.t...

2017-10-20 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/402 I got your point @afine, however I'm still under the impression that the root cause is that tests are running in parallel and multiple instances of Zookeeper are trying to run. I've seen

[GitHub] zookeeper issue #440: ZOOKEEPER-2979 Use dropwizard library histogram for pr...

2018-05-07 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/440 Rebased and resolved conflicts. ---

[GitHub] zookeeper issue #466: ZOOKEEPER-2940. Deal with maxbuffer as it relates to l...

2018-05-07 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/466 @phunt Sure, just let me try to clarify what needs to be done, because I think you wanted to link #415 instead of #466 which is this PR. - stats should be added to JMX (done, already

[GitHub] zookeeper pull request #514: ZOOKEEPER-3012. Fix unit test: testDataDirAndDa...

2018-05-08 Thread anmolnar
GitHub user anmolnar opened a pull request: https://github.com/apache/zookeeper/pull/514 ZOOKEEPER-3012. Fix unit test: testDataDirAndDataLogDir should not use hardcode test folders A little bit more than just fixing the hardcoded folder names. Because the original issue was only

[GitHub] zookeeper pull request #515: ZOOKEEPER-3012. Fix unit test: testDataDirAndDa...

2018-05-08 Thread anmolnar
GitHub user anmolnar opened a pull request: https://github.com/apache/zookeeper/pull/515 ZOOKEEPER-3012. Fix unit test: testDataDirAndDataLogDir should not use hardcode test folders Replaced by creating random folders. https://issues.apache.org/jira/browse/ZOOKEEPER-3012

[GitHub] zookeeper issue #511: Incorrect constant value

2018-05-14 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/511 @roy2220 Thanks for submitting this patch. This is actually a duplicate of https://issues.apache.org/jira/browse/ZOOKEEPER-1919 and a patch is already available in there. I'll create

[GitHub] zookeeper pull request #522: ZOOKEEPER-1919 Update the C implementation of r...

2018-05-14 Thread anmolnar
GitHub user anmolnar opened a pull request: https://github.com/apache/zookeeper/pull/522 ZOOKEEPER-1919 Update the C implementation of removeWatches to have it match ZOOKEEPER-1910 Existing patch on Jira has been rebased and applied to master. You can merge this pull request

[GitHub] zookeeper issue #451: ZOOKEEPER-2184: Zookeeper Client should re-resolve hos...

2018-05-14 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/451 @fpj I think this patch is ready for merging as it is. Are you still having concerns? ---

[GitHub] zookeeper issue #150: ZOOKEEPER-2184: Zookeeper Client should re-resolve hos...

2018-05-14 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/150 @tophei Sounds great, thanks for testing. ---

[GitHub] zookeeper pull request #451: ZOOKEEPER-2184: Zookeeper Client should re-reso...

2018-05-07 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/451#discussion_r186591545 --- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java --- @@ -111,9 +154,18 @@ public InetSocketAddress next(long spinDelay

[GitHub] zookeeper pull request #451: ZOOKEEPER-2184: Zookeeper Client should re-reso...

2018-05-07 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/451#discussion_r186591140 --- Diff: src/java/main/org/apache/zookeeper/client/HostProvider.java --- @@ -53,7 +54,7 @@ * @param spinDelay

[GitHub] zookeeper pull request #451: ZOOKEEPER-2184: Zookeeper Client should re-reso...

2018-05-07 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/451#discussion_r186591847 --- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java --- @@ -111,9 +154,18 @@ public InetSocketAddress next(long spinDelay

[GitHub] zookeeper issue #466: ZOOKEEPER-2940. Deal with maxbuffer as it relates to l...

2018-05-07 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/466 @eribeiro Thanks. In which case given that this PR is targeted for the master branch, I'll add them to Jetty and JMX commands. ---

[GitHub] zookeeper issue #377: [ZOOKEEPER-2901] TTL Nodes don't work with Server IDs ...

2018-05-09 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/377 Never mind. I'll create a separate PR for that. ---

[GitHub] zookeeper issue #377: [ZOOKEEPER-2901] TTL Nodes don't work with Server IDs ...

2018-05-09 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/377 @Randgalt Not strictly part of this PR, but I noticed that ContainerManager doesn't log the name of the container being deleted here: ```java try { LOG.info("Attem

[GitHub] zookeeper pull request #501: ZOOKEEPER-3019 add metric for slow fsyncs count

2018-04-27 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/501#discussion_r184673319 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -311,6 +325,9 @@ public synchronized void commit() throws

[GitHub] zookeeper issue #509: ZOOKEEPER-3027 Accidently removed public API of FileTx...

2018-04-27 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/509 @phunt all commits lgtm +1 thanks. ---

  1   2   3   4   5   6   7   8   9   >