[GitHub] zookeeper issue #667: ZOOKEEPER-3158:firstConnect.countDown() will not be ex...

Github user dineshappavoo commented on the issue: https://github.com/apache/zookeeper/pull/667 This change LGTM 👍 ---

[GitHub] zookeeper pull request #702: ZOOKEEPER-3190: Spell check on the Zookeeper se...

GitHub user dineshappavoo opened a pull request: https://github.com/apache/zookeeper/pull/702 ZOOKEEPER-3190: Spell check on the Zookeeper server files This pull request is to do spell check on the zookeeper server files [ zookeeper/zookeeper-server/src/main/java/org/apache

[GitHub] zookeeper issue #630: ZOOKEEPER-2284:LogFormatter and SnapshotFormatter does...

Github user dineshappavoo commented on the issue: https://github.com/apache/zookeeper/pull/630 LGTM. 👍 ---

[GitHub] zookeeper issue #623: [ZOOKEEPER-3146] Limit the maximum client connections ...

Github user dineshappavoo commented on the issue: https://github.com/apache/zookeeper/pull/623 Hey @lvfangmin , This change looks good overall. I am trying to involve in the community. I had a question about this change. I thought I would ask here. Please bare with me

[GitHub] zookeeper issue #702: ZOOKEEPER-3190: Spell check on the Zookeeper server fi...

Github user dineshappavoo commented on the issue: https://github.com/apache/zookeeper/pull/702 Thank you @eolivelli for the review. Addressed your comments. ---

[GitHub] zookeeper pull request #735: ZOOKEEPER-3209: New `getEphemerals` api to get ...

GitHub user dineshappavoo opened a pull request: https://github.com/apache/zookeeper/pull/735 ZOOKEEPER-3209: New `getEphemerals` api to get all the ephemeral nodes created by the session See https://issues.apache.org/jira/browse/ZOOKEEPER-3209 for details about the API

[GitHub] zookeeper issue #731: [ZOOKEEPER-3208] Remove the SSLTest.java.orig introduc...

Github user dineshappavoo commented on the issue: https://github.com/apache/zookeeper/pull/731 This LGTM 👍 ---