[GitHub] zookeeper pull request #160: ZOOKEEPER-2680:Correct DataNode.getChildren() i...

Github user edwardoliveira commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/160#discussion_r98967876 --- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java --- @@ -1045,18 +1046,16 @@ private void getCounts(String path, Counts counts

[GitHub] zookeeper pull request #150: ZOOKEEPER-2184: Zookeeper Client should re-reso...

Github user edwardoliveira commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/150#discussion_r98263409 --- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java --- @@ -87,15 +75,104 @@ public StaticHostProvider(Collection

[GitHub] zookeeper pull request #150: ZOOKEEPER-2184: Zookeeper Client should re-reso...

Github user edwardoliveira commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/150#discussion_r98483994 --- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java --- @@ -122,18 +122,19 @@ public int size() { private int

[GitHub] zookeeper pull request #180: ZOOKEEPER-2700 add `snap` command to take snaps...

Github user edwardoliveira commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/180#discussion_r101841044 --- Diff: src/java/main/org/apache/zookeeper/server/command/SnapCommand.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software

[GitHub] zookeeper pull request #179: ZOOKEEPER-2693: DOS attack on wchp/wchc four le...

Github user edwardoliveira commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/179#discussion_r101586810 --- Diff: src/java/main/org/apache/zookeeper/server/command/FourLetterCommands.java --- @@ -153,13 +155,33 @@ */ public final

[GitHub] zookeeper issue #85: ZOOKEEPER-2597: Add script to merge PR from Apache git ...

Github user edwardoliveira commented on the issue: https://github.com/apache/zookeeper/pull/85 Thanks @hanm ! :smiley: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zookeeper issue #562: [ZOOKEEPER-3084] Exit when zeus cannot bind to the lea...

Github user edwardoliveira commented on the issue: https://github.com/apache/zookeeper/pull/562 We could print an error message before quitting. I think -1 is a nice value to return, but it's up to you. :) Also, Zeus isn't the ZooKeeper fork from Facebook? Lol. ---

[GitHub] zookeeper pull request #501: ZOOKEEPER-3019 add metric for slow fsyncs count

Github user edwardoliveira commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/501#discussion_r181134958 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java --- @@ -55,6 +53,7 @@ private final File snapDir

[GitHub] zookeeper pull request #501: ZOOKEEPER-3019 add metric for slow fsyncs count

Github user edwardoliveira commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/501#discussion_r181126991 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java --- @@ -30,10 +30,8 @@ import

[GitHub] zookeeper pull request #501: ZOOKEEPER-3019 add metric for slow fsyncs count

Github user edwardoliveira commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/501#discussion_r181129644 --- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java --- @@ -148,9 +150,23 @@ synchronized public void resetRequestCounters

[GitHub] zookeeper pull request #501: ZOOKEEPER-3019 add metric for slow fsyncs count

Github user edwardoliveira commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/501#discussion_r181127170 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -135,6 +136,8 @@ long currentSize; File

[GitHub] zookeeper pull request #501: ZOOKEEPER-3019 add metric for slow fsyncs count

Github user edwardoliveira commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/501#discussion_r181127430 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java --- @@ -55,6 +53,7 @@ private final File snapDir

[GitHub] zookeeper pull request #500: ZOOKEEPER-2959: ignore accepted epoch and LEADE...

Github user edwardoliveira commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/500#discussion_r182180406 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java --- @@ -161,8 +127,8 @@ public void testLeaderInConnectingFollowers

[GitHub] zookeeper pull request #493: ZOOKEEPER-3006: Potential NPE in ZKDatabase#cal...

GitHub user edwardoliveira opened a pull request: https://github.com/apache/zookeeper/pull/493 ZOOKEEPER-3006: Potential NPE in ZKDatabase#calculateTxnLogSizeLimit You can merge this pull request into a Git repository by running: $ git pull https://github.com/eribeiro

[GitHub] zookeeper issue #493: ZOOKEEPER-3006: Potential NPE in ZKDatabase#calculateT...

Github user edwardoliveira commented on the issue: https://github.com/apache/zookeeper/pull/493 Hey, @LJ1043041006, I have just added a unit test. Cheers! ---

[GitHub] zookeeper pull request #632: [ZOOKEEPER-3150] Add tree digest check and veri...

Github user edwardoliveira commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/632#discussion_r223546118 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java --- @@ -1521,4 +1562,179 @@ public boolean removeWatch(String

[GitHub] zookeeper issue #617: ZOOKEEPER-1990 - fix Random instances

Github user edwardoliveira commented on the issue: https://github.com/apache/zookeeper/pull/617 +1 ---