GitHub user mjeelanimsft opened a pull request:
https://github.com/apache/zookeeper/pull/542
[ZOOKEEPER-3060] Logging the server local port to stderr
This simple straightforward patch adds logging of the server local port to
stderr which aids in simplifying debugging if you want
Github user mjeelanimsft closed the pull request at:
https://github.com/apache/zookeeper/pull/542
---
GitHub user mjeelanimsft opened a pull request:
https://github.com/apache/zookeeper/pull/548
[ZOOKEEPER-3057] Fix IPv6 literal usage
This patch contains fixes for IPv6 literal usage and corresponding unit
test changes.
As per discussion in ZOOKEEPER-3057 - The issue
Github user mjeelanimsft commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/548#discussion_r197976612
--- Diff: src/java/test/org/apache/zookeeper/common/NetUtilsTest.java ---
@@ -0,0 +1,46 @@
+package apache.zookeeper.common;
+
+import
Github user mjeelanimsft commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/548#discussion_r197950541
--- Diff: src/java/test/org/apache/zookeeper/common/NetUtilsTest.java ---
@@ -0,0 +1,46 @@
+package apache.zookeeper.common;
--- End diff
Github user mjeelanimsft commented on the issue:
https://github.com/apache/zookeeper/pull/579
Thanks for the commit @breed ! My email was indeed not set properly; thanks
for letting me know - I've fixed it now.
---
Github user mjeelanimsft commented on the issue:
https://github.com/apache/zookeeper/pull/577
Thanks for accepting and merging @hanm !
---
GitHub user mjeelanimsft opened a pull request:
https://github.com/apache/zookeeper/pull/577
[3094] Make BufferSizeTest reliable
ZKPatch: d8b825d6533e9848565beff09e9a018136ca32bd (extract)
Changes made to the testStartupFailure test to remember the old directory
and switch
GitHub user mjeelanimsft opened a pull request:
https://github.com/apache/zookeeper/pull/579
Connect string fix for non-existent hosts
ZKPatch: eda58d9970c76831046ddc45251c9b110856836e (extract)
You can merge this pull request into a Git repository by running:
$ git pull https
Github user mjeelanimsft commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/548#discussion_r203816489
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -857,15 +869,15 @@ public void run
Github user mjeelanimsft commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/548#discussion_r203817750
--- Diff: src/java/main/org/apache/zookeeper/server/util/ConfigUtils.java
---
@@ -61,10 +61,16 @@ static public String getClientConfigStr(String
Github user mjeelanimsft commented on the issue:
https://github.com/apache/zookeeper/pull/548
Thanks for the feedback @maoling - I've incorporated the below changes.
@maoling @anmolnar - let me know what you think
- Assert actual host and port in unit tests for getHostAndPort
Github user mjeelanimsft commented on the issue:
https://github.com/apache/zookeeper/pull/548
Hi @anmolnar - I see it here - would you mind looking now?
https://github.com/mjeelanimsft/zookeeper/blob/1ce5b8bdcf0925d1ce25d16bf70c1d13de44bf08/src/java/test/org/apache/zookeeper
Github user mjeelanimsft commented on the issue:
https://github.com/apache/zookeeper/pull/548
Thanks Andor - I've added the unit test cases - For the one w/o [ - its
also an invalid case for this method as its needed to specify the port. I've
added that as one at the end, let me know
Github user mjeelanimsft commented on the issue:
https://github.com/apache/zookeeper/pull/548
Thanks @anmolnar & @maoling - I've added the Unit Test as well as the
JavaDoc for splitServerConfig() method
---
Github user mjeelanimsft commented on the issue:
https://github.com/apache/zookeeper/pull/548
@anmolnar Resolved the merge conflict. You can see the commit with the unit
test changes here -
https://github.com/apache/zookeeper/pull/548/commits/ff4704984203921071877bdee4efef47b8c2a706
---
16 matches
Mail list logo
