GitHub user nikhilbhide opened a pull request:
https://github.com/apache/zookeeper/pull/372
ZOOKEEPER-2896: Remove unused imports from
org.apache.zookeeper.test.CreateTest.java
Following imports are not used in the code and do not adhere to code
convention and style
Github user nikhilbhide commented on the issue:
https://github.com/apache/zookeeper/pull/372
Closing because of conflicts
---
Github user nikhilbhide closed the pull request at:
https://github.com/apache/zookeeper/pull/372
---
GitHub user nikhilbhide opened a pull request:
https://github.com/apache/zookeeper/pull/373
ZOOKEEPER-2896: Remove unused imports from
org.apache.zookeeper.test.CreateTest.java
Following imports are not used in the code and do not adhere to code
convention and style.
import
Github user nikhilbhide commented on the issue:
https://github.com/apache/zookeeper/pull/373
Closed because of conflicts
---
Github user nikhilbhide commented on the issue:
https://github.com/apache/zookeeper/pull/373
Closed because of conflicts
---
Github user nikhilbhide closed the pull request at:
https://github.com/apache/zookeeper/pull/373
---
GitHub user nikhilbhide opened a pull request:
https://github.com/apache/zookeeper/pull/374
ZOOKEEPER-2896: Remove unused imports from
org.apache.zookeeper.test.CreateTest.java
Remove unused imports from org.apache.zookeeper.test.CreateTest.java
Following imports are not used
Github user nikhilbhide commented on the issue:
https://github.com/apache/zookeeper/pull/374
Patch is ready, please apply to master.
---
Github user nikhilbhide commented on the issue:
https://github.com/apache/zookeeper/pull/347
patch is ready
---
Github user nikhilbhide closed the pull request at:
https://github.com/apache/zookeeper/pull/347
---
GitHub user nikhilbhide opened a pull request:
https://github.com/apache/zookeeper/pull/365
ZOOKEEPER-2777: There is a typo in zk.py which prevents from
using/compiling it
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user nikhilbhide commented on the issue:
https://github.com/apache/zookeeper/pull/345
Patch is ready
---
Github user nikhilbhide closed the pull request at:
https://github.com/apache/zookeeper/pull/345
---
Github user nikhilbhide closed the pull request at:
https://github.com/apache/zookeeper/pull/345
---
Github user nikhilbhide commented on the issue:
https://github.com/apache/zookeeper/pull/345
Patch is ready to be applied
---
GitHub user nikhilbhide reopened a pull request:
https://github.com/apache/zookeeper/pull/345
Zookeeper 2814: ignore space after comma in connection string
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nikhilbhide/zookeeper
Github user nikhilbhide closed the pull request at:
https://github.com/apache/zookeeper/pull/364
---
GitHub user nikhilbhide opened a pull request:
https://github.com/apache/zookeeper/pull/364
ZOOKEEPER-2777: There is a typo in zk.py which prevents from
using/compiling it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user nikhilbhide opened a pull request:
https://github.com/apache/zookeeper/pull/367
ZOOKEEPER-2777: There is a typo in zk.py which prevents from
using/compiling it
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user nikhilbhide opened a pull request:
https://github.com/apache/zookeeper/pull/366
ZOOKEEPER-2777: There is a typo in zk.py which prevents from
using/compiling it
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user nikhilbhide closed the pull request at:
https://github.com/apache/zookeeper/pull/366
---
Github user nikhilbhide closed the pull request at:
https://github.com/apache/zookeeper/pull/365
---
GitHub user nikhilbhide opened a pull request:
https://github.com/apache/zookeeper/pull/368
ZOOKEEPER-2814: Ignore space after comma in connection string
Ported ZOOKEEPER-2814 from master to branch 3.4.
Added files
src/java/main/org/apache/zookeeper/common
GitHub user nikhilbhide opened a pull request:
https://github.com/apache/zookeeper/pull/370
Ported ZOOKEEPER-2814 from master to branch 3.4. Added files
src/java/main/org/apache/zookeeper/common/StringUtils.java
src/java/test/org/apache/zookeeper/test/StringUtilTest.java Modified
Github user nikhilbhide closed the pull request at:
https://github.com/apache/zookeeper/pull/369
---
Github user nikhilbhide closed the pull request at:
https://github.com/apache/zookeeper/pull/368
---
GitHub user nikhilbhide opened a pull request:
https://github.com/apache/zookeeper/pull/369
ZOOKEEPER-2814: Ignore space after comma in connection string
Ported ZOOKEEPER-2814 from master to branch 3.4.
Added files
src/java/main/org/apache/zookeeper/common
Github user nikhilbhide closed the pull request at:
https://github.com/apache/zookeeper/pull/370
---
GitHub user nikhilbhide opened a pull request:
https://github.com/apache/zookeeper/pull/371
ZOOKEEPER-2814: Ignore space after comma in connection string
Ported ZOOKEEPER-2814 from master to branch 3.4.
Added files
src/java/main/org/apache/zookeeper/common
Github user nikhilbhide closed the pull request at:
https://github.com/apache/zookeeper/pull/374
---
Github user nikhilbhide commented on the issue:
https://github.com/apache/zookeeper/pull/374
Please apply the patch
---
GitHub user nikhilbhide opened a pull request:
https://github.com/apache/zookeeper/pull/379
ZOOKEEPER-2896: Remove unused imports from
org.apache.zookeeper.test.CreateTest.java
Following imports are not used in the code and do not adhere to code
convention and style
GitHub user nikhilbhide opened a pull request:
https://github.com/apache/zookeeper/pull/387
ZOOKEEPER-2904: Remove unused imports from
org.apache.zookeeper.server.quorum.WatchLeakTest
Following imports are never used and unused imports do not adhere to code
standard
GitHub user nikhilbhide opened a pull request:
https://github.com/apache/zookeeper/pull/343
ZOOKEEPER-2814: Ignore space after comma in connection string
Proposed changes:
- StringUtils.java
- New class org.apache.zookeeper.common.StringUtils to be added
- Logic
Github user nikhilbhide closed the pull request at:
https://github.com/apache/zookeeper/pull/343
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user nikhilbhide reopened a pull request:
https://github.com/apache/zookeeper/pull/343
ZOOKEEPER-2814: Ignore space after comma in connection string
Proposed changes:
- StringUtils.java
- New class org.apache.zookeeper.common.StringUtils to be added
- Logic
Github user nikhilbhide commented on the issue:
https://github.com/apache/zookeeper/pull/343
Reopening pull request #343
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user nikhilbhide commented on the issue:
https://github.com/apache/zookeeper/pull/343
Closing pull request #343 as there seems to be a conflict.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user nikhilbhide closed the pull request at:
https://github.com/apache/zookeeper/pull/343
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user nikhilbhide opened a pull request:
https://github.com/apache/zookeeper/pull/345
Zookeeper 2814: ignore space after comma in connection string
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nikhilbhide/zookeeper
Github user nikhilbhide closed the pull request at:
https://github.com/apache/zookeeper/pull/345
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user nikhilbhide reopened a pull request:
https://github.com/apache/zookeeper/pull/345
Zookeeper 2814: ignore space after comma in connection string
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nikhilbhide/zookeeper
Github user nikhilbhide closed the pull request at:
https://github.com/apache/zookeeper/pull/346
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user nikhilbhide commented on the issue:
https://github.com/apache/zookeeper/pull/346
Corrected typo in zk.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user nikhilbhide opened a pull request:
https://github.com/apache/zookeeper/pull/347
ZOOKEEPER-2777: There is a typo in zk.py which prevents from
using/compiling it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user nikhilbhide reopened a pull request:
https://github.com/apache/zookeeper/pull/346
ZOOKEEPER-2777: There is a typo in zk.py which prevents from
using/compiling it.
ZOOKEEPER-2777: There is a typo in zk.py which prevents from
using/compiling it.
You can merge this pull
GitHub user nikhilbhide opened a pull request:
https://github.com/apache/zookeeper/pull/346
ZOOKEEPER-2777: There is a typo in zk.py which prevents from
using/compiling it.
ZOOKEEPER-2777: There is a typo in zk.py which prevents from
using/compiling it.
You can merge this pull
Github user nikhilbhide closed the pull request at:
https://github.com/apache/zookeeper/pull/347
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user nikhilbhide reopened a pull request:
https://github.com/apache/zookeeper/pull/347
ZOOKEEPER-2777: There is a typo in zk.py which prevents from
using/compiling it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user nikhilbhide closed the pull request at:
https://github.com/apache/zookeeper/pull/346
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user nikhilbhide commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/345#discussion_r135084898
--- Diff:
src/java/main/org/apache/zookeeper/client/ConnectStringParser.java ---
@@ -20,8 +20,11 @@
import java.net.InetSocketAddress
Github user nikhilbhide commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/345#discussion_r135085577
--- Diff: src/java/main/org/apache/zookeeper/common/StringUtils.java ---
@@ -0,0 +1,44 @@
+/* Licensed to the Apache Software Foundation (ASF
Github user nikhilbhide commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/345#discussion_r135083779
--- Diff:
src/java/main/org/apache/zookeeper/client/ConnectStringParser.java ---
@@ -20,8 +20,11 @@
import java.net.InetSocketAddress
Github user nikhilbhide commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/345#discussion_r135085831
--- Diff: src/java/test/org/apache/zookeeper/test/StringUtilTest.java ---
@@ -0,0 +1,44 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user nikhilbhide commented on the issue:
https://github.com/apache/zookeeper/pull/347
Please apply patch to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user nikhilbhide commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/345#discussion_r135181414
--- Diff:
src/java/main/org/apache/zookeeper/client/ConnectStringParser.java ---
@@ -20,8 +20,11 @@
import java.net.InetSocketAddress
Github user nikhilbhide commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/345#discussion_r135207087
--- Diff: src/java/test/org/apache/zookeeper/test/StringUtilTest.java ---
@@ -0,0 +1,44 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user nikhilbhide commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/345#discussion_r136246013
--- Diff: src/java/main/org/apache/zookeeper/common/StringUtils.java ---
@@ -0,0 +1,44 @@
+/* Licensed to the Apache Software Foundation (ASF
Github user nikhilbhide commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/345#discussion_r136245995
--- Diff:
src/java/main/org/apache/zookeeper/client/ConnectStringParser.java ---
@@ -20,8 +20,11 @@
import java.net.InetSocketAddress
60 matches
Mail list logo
