[GitHub] zookeeper issue #120: ZOOKEEPER-261
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/120 As a side effect of a new commit (https://github.com/apache/zookeeper/commit/42c75b5f2457f8ea5b4106ce5dc1c34c330361c0) that triggers git mirror sync, this PR is closed :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #120: ZOOKEEPER-261
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/120 Right, it is committed, confirmed. I was only checking the apache mirror on git (https://github.com/apache/zookeeper), instead of the apache git directly. I suspect there is some infra issues on Apache (the JIRA was done yesterday) which contributes to the bridging between various systems not working as expected, leading to this PR not closed automatically. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #120: ZOOKEEPER-261
Github user breed commented on the issue: https://github.com/apache/zookeeper/pull/120 it shows up in https://git-wip-us.apache.org/repos/asf?p=zookeeper.git --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #120: ZOOKEEPER-261
Github user breed commented on the issue: https://github.com/apache/zookeeper/pull/120 hmm, perhaps you are right. i don't think the script is working for me properly... checking. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #120: ZOOKEEPER-261
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/120 Also https://issues.apache.org/jira/browse/ZOOKEEPER-261 does not have Fixed Version set, which implies that the JIRA was resolved manually (my guess) instead of automatically as part of commit flow through https://github.com/apache/zookeeper/blob/master/zk-merge-pr.py - usually if we use the merge script it will take care everything including close the PR and resolve the JIRA (provided right credential has been set up.). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #120: ZOOKEEPER-261
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/120 I don't see this is committed in master. No commit log from git, no notification emails. @breed Are you sure this is committed (and pushed to apache git)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #120: ZOOKEEPER-261
Github user breed commented on the issue: https://github.com/apache/zookeeper/pull/120 hmm this is committed. anyone understands why it doesn't autoclose? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #120: ZOOKEEPER-261
Github user breed commented on the issue: https://github.com/apache/zookeeper/pull/120 commited. thanx everyone for reviewing and brian for your contribution. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #120: ZOOKEEPER-261
Github user eribeiro commented on the issue: https://github.com/apache/zookeeper/pull/120 @enixon Thank you very much for the explanation! Makes sense, sorry for my misunderstanding. @breed Yep, agree. Let's push it forward. :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #120: ZOOKEEPER-261
Github user breed commented on the issue: https://github.com/apache/zookeeper/pull/120 @eribeiro i think this is ready to go. do you feel that your question has been answer sufficiently? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #120: ZOOKEEPER-261
Github user enixon commented on the issue: https://github.com/apache/zookeeper/pull/120 @eribeiro Thanks for checking the diff! The `initialize` file will not be required for standard restarts. The expected pattern is to create one on each host just before ensemble creation (when the file system is trusted to be the most stable) and ZooKeeper will clean it up once the server has inspected the file system and found no data. Restarting servers should see the data already present and not require the file (or not see the data and require _not_ seeing the file). New servers expanding an existing ensemble probably shouldn't be granted voting privileges until they get a copy of the data. Admins should have scripts available to handle ensemble creation and this represents a minimal extension of that. I would be hesitant to rely on the existence of any file to provide guarantees during regular execution and that precludes the use of `recover` file pattern. The category of events that motivate this pull request necessarily include those that would remove any pre-staged `recover` file. I'm imagining a scenario where your server dies and file system gets wiped then automated restart scripts spring into action to bring the server back up. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #120: ZOOKEEPER-261
Github user enixon commented on the issue: https://github.com/apache/zookeeper/pull/120 Rebased on to latest master to avoid any potential conflicts with @breed 's changes for 2325. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #120: ZOOKEEPER-261
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/120 lgtm +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #120: ZOOKEEPER-261
Github user enixon commented on the issue: https://github.com/apache/zookeeper/pull/120 - add documentation on 'zookeeper.db.autocreate' to zookeeperAdmin.xml - extend bin/zkServer-initialize.sh to create the initialize file - treat failure to delete initialization file as fatal, throw IOException instead of logging a warning --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #120: ZOOKEEPER-261
Github user enixon commented on the issue: https://github.com/apache/zookeeper/pull/120 Thanks, @hanm , let's see if editing the correct string into the title suffices or if I need to open up a new PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #120: Zookeeper 261
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/120 Nit: the PR title should contain the string "ZOOKEEPER-261" for the merge script to work - otherwise comments made here will not be bridged to JIRA https://issues.apache.org/jira/browse/ZOOKEEPER-261 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zookeeper issue #120: Zookeeper 261
Github user enixon commented on the issue: https://github.com/apache/zookeeper/pull/120 This pull request is built on top of @breed 's changes for #117 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
