[GitHub] zookeeper issue #325: Fix typos in zookeeperAdmin.html

2017-08-12 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/325 merged to master. In the future, please create a JIRA issue before sending a pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] zookeeper issue #325: Fix typos in zookeeperAdmin.html

2017-08-04 Thread makubi
Github user makubi commented on the issue: https://github.com/apache/zookeeper/pull/325 Thank you for the information. @eribeiro The branch can not be merged to `branch-3.4` or `branch-3.5` as it's originated from `master`. You can cherry-pick the commit if the branches are

[GitHub] zookeeper issue #325: Fix typos in zookeeperAdmin.html

2017-08-03 Thread eribeiro
Github user eribeiro commented on the issue: https://github.com/apache/zookeeper/pull/325 +1. :+1: @makubi could you confirm that this patch can be applied on branch-3.4 and branch-3.5 too, please? --- If your project is set up for it, you can reply to this email and have

[GitHub] zookeeper issue #325: Fix typos in zookeeperAdmin.html

2017-08-03 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/325 The doc artifacts (html, pdf, etc) were added to repo because there was a tale that without them in trunk, the documentation on [zookeeper web site](https://zookeeper.apache.org/doc/trunk/) would

[GitHub] zookeeper issue #325: Fix typos in zookeeperAdmin.html

2017-08-03 Thread makubi
Github user makubi commented on the issue: https://github.com/apache/zookeeper/pull/325 Alright, so is there a reason the generated doc is added to the repository? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zookeeper issue #325: Fix typos in zookeeperAdmin.html

2017-08-02 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/325 Doc change should be done on doc source file instead of on the html file directly - see my comment here: https://github.com/apache/zookeeper/pull/275#issuecomment-307161978 --- If your project