[GitHub] zookeeper issue #534: ZOOKEEPER-2184 Zookeeper Client should re-resolve host...

Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/534 >> it seems like we also introduced a findbug issue with #562 Let's do this as a separate issue. I committed the patch, so I feel obligated to fix it:

[GitHub] zookeeper issue #534: ZOOKEEPER-2184 Zookeeper Client should re-resolve host...

Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/534 I think this one is good to commit - I'll commit in next few days if no one raise other concerns. ---

[GitHub] zookeeper issue #534: ZOOKEEPER-2184 Zookeeper Client should re-resolve host...

Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/534 @lvfangmin Unit tests failed, but it seems like we also introduced a findbug issue with #562 Shall I fix it in this patch or would you like to do it separately? ---

[GitHub] zookeeper issue #534: ZOOKEEPER-2184 Zookeeper Client should re-resolve host...

Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/534 @hanm @lvfangmin Are you happy with commiting the patch? ---

[GitHub] zookeeper issue #534: ZOOKEEPER-2184 Zookeeper Client should re-resolve host...

Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/534 Unit test refactoring: https://issues.apache.org/jira/browse/ZOOKEEPER-3065 ---

[GitHub] zookeeper issue #534: ZOOKEEPER-2184 Zookeeper Client should re-resolve host...

Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/534 @hanm @lvfangmin Reconfig tests have previously been implemented only for IP addresses and hasn't covered hostnames which need to be resolved. I added a few unit tests for coverage, but found

[GitHub] zookeeper issue #534: ZOOKEEPER-2184 Zookeeper Client should re-resolve host...

Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/534 @hanm Sorry for the delay. I'll work on it today. ---

[GitHub] zookeeper issue #534: ZOOKEEPER-2184 Zookeeper Client should re-resolve host...

Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/534 @anmolnar do you have a chance to address the issues from code review? Please let me know if you plan to work on this in next few days - otherwise I'll just go ahead and do the 3.4 release without

[GitHub] zookeeper issue #534: ZOOKEEPER-2184 Zookeeper Client should re-resolve host...

Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/534 @hanm Thanks, I updated the comments to be consistent with the original PR. Unfortunately the comment of `HostProvider` wasn't updated, so I also made changes in there. ---

[GitHub] zookeeper issue #534: ZOOKEEPER-2184 Zookeeper Client should re-resolve host...

Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/534 @hanm Did you have a chance to take a look? ---