[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...
Github user ivmaykov commented on the issue: https://github.com/apache/zookeeper/pull/680 @anmolnar is there anything blocking this from being merged at this point? ---
[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/680 @ivmaykov For the future, I think it's more convenient for reviewers if you submit your commits separately instead of squashing them. Especially if you provide some feedback on code review, it's hard to locate new changes if everything is in a single patch. Commit script will squash all them eventually, so it doesn't really matter in PRs. ---
[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...
Github user ivmaykov commented on the issue: https://github.com/apache/zookeeper/pull/680 @anmolnar removed finalizer, use explicit close() ---
[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...
Github user ivmaykov commented on the issue: https://github.com/apache/zookeeper/pull/680 @anmolnar looks like FileMonitor only exists in our fork for now and is not upstreamed yet, so never mind about that comment! I'll work with other FB engineers to unify the two classes. ---
[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...
Github user ivmaykov commented on the issue: https://github.com/apache/zookeeper/pull/680 @anmolnar is there anything I can do to help move this PR and #681 along? ---
[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/680 @ivmaykov No, I think it's fine to keep `FileChangeWatcher`. I keep looking... ---
[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...
Github user ivmaykov commented on the issue: https://github.com/apache/zookeeper/pull/680 @anmolnar I just stumbled across the FileMonitor class, which has similar functionality to my FileChangeWatcher. The main difference is that it polls for changes and sleeps the thread in between, rather than using WatchService. It also ignores mtime changes if the file contents have not changed. Maybe I should use FileMonitor and remove the FileChangeWatcher class? ---
[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/680 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2601/ ---
[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/680 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2595/ ---
[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/680 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2593/ ---
[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/680 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2590/ ---
[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/680 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2586/ ---
[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/680 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2575/ ---
[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/680 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2573/ ---
[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/680 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2571/ ---
[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/680 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2568/ ---
[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/680 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2566/ ---
[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/680 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2565/ ---
[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...
Github user ivmaykov commented on the issue: https://github.com/apache/zookeeper/pull/680 @eolivelli switched to lambdas, kept the finalizer in for now but added a TODO to remove it. ---
[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/680 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2561/ ---
[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/680 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2557/ ---
[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/680 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2546/ ---
[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/680 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2542/ ---
[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/680 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2538/ ---
[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/680 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2534/ ---
[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/680 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2530/ ---
[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...
Github user ivmaykov commented on the issue: https://github.com/apache/zookeeper/pull/680 I should mention that this code has been internally reviewed at Facebook, has been landed on our internal fork, and has been running in production for weeks. ---
[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...
Github user ivmaykov commented on the issue: https://github.com/apache/zookeeper/pull/680 I should mention that this code has been internally reviewed at Facebook, has been landed on our internal fork, and has been running in production for weeks. ---
[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/680 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2526/ ---
[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/680 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2523/ ---
[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/680 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2512/ ---
[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/680 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2502/ ---
