Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/703
Here is the PR for 3.5: #714, thanks @mkedwards.
---
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/703
Thanks @anmolnar, I'll send out the PR for 3.5.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/703
Committed to master branch. Thanks @lvfangmin !
Please create another pull request for branch-3.5.
---
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/703
@lvfangmin lgtm, thanks!
---
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/703
@hanm is the latest change looking good to you?
---
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/703
@lvfangmin will review and provide feedback tonight. thanks
---
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/703
May need an extra +1 from another committer, @hanm do you have time to
review this?
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/703
@lvfangmin Thanks for the clarification!
Still testing your patch, should be done by tomorrow.
---
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/703
@anmolnar following are my understanding about the acceptedEpoch,
currentEpoch and electionEpoch:
* acceptedEpoch : the previous epoch we accepted so far, usually is the
epoch is the
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/703
Thanks @lvfangmin for working on this.
To be honest I'm lost following how FLE works and additionally what issue
is this patch intended to fix. I only ran a few blind test with manually
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/703
@anmolnar this is the fix for the DONTCARE on trunk, please take a look,
I'll port it to 3.5 when it's being reviewed and merged.
---
11 matches
Mail list logo
