Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/377
---
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r186427922
--- Diff: src/java/main/org/apache/zookeeper/server/OldEphemeralType.java
---
@@ -0,0 +1,74 @@
+/**
+ * Licensed to the Apache Software
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r186422920
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml ---
@@ -950,6 +952,39 @@ server.3=zoo3:2888:3888
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r186415246
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml ---
@@ -950,6 +952,39 @@ server.3=zoo3:2888:3888
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r172509908
--- Diff: src/java/main/org/apache/zookeeper/server/OldEphemeralType.java
---
@@ -0,0 +1,74 @@
+/**
+ * Licensed to the Apache Software
Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r170009123
--- Diff: src/java/main/org/apache/zookeeper/server/OldEphemeralType.java
---
@@ -0,0 +1,74 @@
+/**
+ * Licensed to the Apache Software
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r170008461
--- Diff: src/java/main/org/apache/zookeeper/server/OldEphemeralType.java
---
@@ -0,0 +1,74 @@
+/**
+ * Licensed to the Apache Software
Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r169985373
--- Diff: src/java/main/org/apache/zookeeper/server/EphemeralType.java ---
@@ -37,41 +77,152 @@
/**
* TTL node
*/
-
Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r169984867
--- Diff: src/java/main/org/apache/zookeeper/server/OldEphemeralType.java
---
@@ -0,0 +1,74 @@
+/**
+ * Licensed to the Apache Software
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r169865059
--- Diff: src/java/main/org/apache/zookeeper/server/EphemeralType.java ---
@@ -37,41 +77,152 @@
/**
* TTL node
*/
-
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r169863794
--- Diff: src/java/main/org/apache/zookeeper/server/OldEphemeralType.java
---
@@ -0,0 +1,74 @@
+/**
+ * Licensed to the Apache Software
Github user phunt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r166787684
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml ---
@@ -950,6 +952,39 @@ server.3=zoo3:2888:3888
Github user phunt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r166787489
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml ---
@@ -950,6 +952,39 @@ server.3=zoo3:2888:3888
Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r163747537
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -476,9 +474,12 @@ public ZooKeeperServerListener
Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r163746348
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -476,9 +474,12 @@ public ZooKeeperServerListener
Github user phunt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r163712641
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -476,9 +474,12 @@ public ZooKeeperServerListener
Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r163671234
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -476,9 +474,12 @@ public ZooKeeperServerListener
Github user phunt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r163420180
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -476,9 +474,12 @@ public ZooKeeperServerListener
Github user phunt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r163419925
--- Diff: src/java/main/org/apache/zookeeper/server/EphemeralType.java ---
@@ -40,19 +39,40 @@
TTL;
public static final long
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r161147063
--- Diff: src/java/main/org/apache/zookeeper/server/EphemeralType.java ---
@@ -40,19 +39,40 @@
TTL;
public static final long
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r161146799
--- Diff: src/java/main/org/apache/zookeeper/server/EphemeralType.java ---
@@ -40,19 +39,40 @@
TTL;
public static final long
Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r159091495
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml ---
@@ -949,14 +949,15 @@ server.3=zoo3:2888:3888
Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r159091284
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -476,9 +474,12 @@ public ZooKeeperServerListener
Github user phunt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r156821209
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml
---
@@ -271,9 +271,9 @@
is not modified within the TTL and has
Github user phunt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r156821178
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml ---
@@ -949,14 +949,15 @@ server.3=zoo3:2888:3888
Github user phunt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r156821102
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -476,9 +474,12 @@ public ZooKeeperServerListener
Github user phunt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r156809696
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml ---
@@ -949,14 +949,15 @@ server.3=zoo3:2888:3888
Github user phunt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r156808074
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml ---
@@ -949,14 +949,15 @@ server.3=zoo3:2888:3888
Github user phunt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r153668817
--- Diff: src/java/main/org/apache/zookeeper/server/EphemeralType.java ---
@@ -40,19 +39,21 @@
TTL;
public static final long
Github user phunt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r153668593
--- Diff: src/java/main/org/apache/zookeeper/server/EphemeralType.java ---
@@ -40,19 +39,21 @@
TTL;
public static final long
Github user DanBenediktson commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r146089767
--- Diff: conf/zoo_sample.cfg ---
@@ -6,6 +6,10 @@ initLimit=10
# The number of ticks that can pass between
# sending a request and
Github user phunt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r146087059
--- Diff: conf/zoo_sample.cfg ---
@@ -6,6 +6,10 @@ initLimit=10
# The number of ticks that can pass between
# sending a request and getting an
Github user phunt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r146086967
--- Diff: conf/zoo_sample.cfg ---
@@ -6,6 +6,10 @@ initLimit=10
# The number of ticks that can pass between
# sending a request and getting an
Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r141521002
--- Diff: src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java
---
@@ -84,6 +84,9 @@ public static long initializeNextSession(long id) {
Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r141521029
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -125,6 +125,8 @@
private final ZooKeeperServerListener listener;
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r141200124
--- Diff: src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java
---
@@ -84,6 +84,9 @@ public static long initializeNextSession(long id) {
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r141200554
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -125,6 +125,8 @@
private final ZooKeeperServerListener listener;
GitHub user Randgalt opened a pull request:
https://github.com/apache/zookeeper/pull/377
[ZOOKEEPER-2901] TTL Nodes don't work with Server IDs > 127
There was a major oversight when TTL nodes were implemented. The session ID
generator for each server is seeded with the configured
38 matches
Mail list logo
