[GitHub] zookeeper pull request #467: ZOOKEEPER-2968: Add C client code coverage test...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zookeeper/pull/467


---

[GitHub] zookeeper pull request #467: ZOOKEEPER-2968: Add C client code coverage test...

[mfenes]

GitHub user mfenes opened a pull request:

https://github.com/apache/zookeeper/pull/467

 ZOOKEEPER-2968: Add C client code coverage tests

ZOOKEEPER-2968: Add C client code coverage tests

This PR adds a new ant target 'c_coverage_report' which generates coverage 
report for the ZK C client.
The report is generated to build/c_coverage/report in html format.
As a requirement, lcov has to be installed prior to running target 
'c_coverage_report'.

An additional check was added to 'check-cppunit-makefile' to ensure that 
the Makefile gets deleted and regenerated without the coverage compiler flags 
when running targets without --enable-gcov.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mfenes/zookeeper ZOOKEEPER-2968

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/467.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #467


commit 3c902262217c236cab2804a2932c7eb68f6f1539
Author: Mark Fenes 
Date:   2018-02-15T15:24:53Z

ZOOKEEPER-2968: Add C client code coverage tests

commit d8757821add5930b08bce52a11ddd7b3428d01ff
Author: Mark Fenes 
Date:   2018-02-19T13:44:14Z

ZOOKEEPER-2968: Add C client code coverage tests

Added check to ensure that the Makefile gets regenerated if someone runs
the cpp unit tests after generating C coverage reports without running ant 
clean first.




---