[GitHub] zookeeper pull request #632: [ZOOKEEPER-3150] Add tree digest check and veri...

2018-10-23 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/632#discussion_r227533265 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/util/AdHash.java --- @@ -0,0 +1,84 @@ +/** + * Licensed to the Apache

[GitHub] zookeeper pull request #632: [ZOOKEEPER-3150] Add tree digest check and veri...

2018-10-23 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/632#discussion_r227532976 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/command/HashCommand.java --- @@ -0,0 +1,49 @@ +/** + * Licensed to the

[GitHub] zookeeper pull request #632: [ZOOKEEPER-3150] Add tree digest check and veri...

2018-10-14 Thread eribeiro
Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/632#discussion_r225016751 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/command/HashCommand.java --- @@ -0,0 +1,49 @@ +/** + * Licensed to the

[GitHub] zookeeper pull request #632: [ZOOKEEPER-3150] Add tree digest check and veri...

2018-10-14 Thread eribeiro
Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/632#discussion_r225016824 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/util/AdHash.java --- @@ -0,0 +1,84 @@ +/** + * Licensed to the Apache

[GitHub] zookeeper pull request #632: [ZOOKEEPER-3150] Add tree digest check and veri...

2018-10-14 Thread eribeiro
Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/632#discussion_r225016598 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java --- @@ -1521,4 +1566,179 @@ public boolean removeWatch(String path,

[GitHub] zookeeper pull request #632: [ZOOKEEPER-3150] Add tree digest check and veri...

2018-10-14 Thread eribeiro
Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/632#discussion_r225016509 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/util/AdHash.java --- @@ -0,0 +1,84 @@ +/** + * Licensed to the Apache

[GitHub] zookeeper pull request #632: [ZOOKEEPER-3150] Add tree digest check and veri...

2018-10-14 Thread eribeiro
Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/632#discussion_r225016431 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java --- @@ -154,6 +160,26 @@ private final

[GitHub] zookeeper pull request #632: [ZOOKEEPER-3150] Add tree digest check and veri...

2018-10-12 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/632#discussion_r224842221 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java --- @@ -154,6 +160,26 @@ private final

[GitHub] zookeeper pull request #632: [ZOOKEEPER-3150] Add tree digest check and veri...

2018-10-12 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/632#discussion_r224843197 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java --- @@ -1521,4 +1566,179 @@ public boolean removeWatch(String path,

[GitHub] zookeeper pull request #632: [ZOOKEEPER-3150] Add tree digest check and veri...

2018-10-12 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/632#discussion_r224844559 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/util/AdHash.java --- @@ -0,0 +1,84 @@ +/** + * Licensed to the Apache

[GitHub] zookeeper pull request #632: [ZOOKEEPER-3150] Add tree digest check and veri...

2018-10-12 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/632#discussion_r224841261 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/DataNode.java --- @@ -37,6 +37,14 @@ * */ public class DataNode

[GitHub] zookeeper pull request #632: [ZOOKEEPER-3150] Add tree digest check and veri...

2018-10-12 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/632#discussion_r224843869 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/NodeHashMapImpl.java --- @@ -0,0 +1,116 @@ +/** + * Licensed to the

[GitHub] zookeeper pull request #632: [ZOOKEEPER-3150] Add tree digest check and veri...

2018-10-10 Thread eribeiro
Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/632#discussion_r224206365 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java --- @@ -1521,4 +1566,179 @@ public boolean removeWatch(String path,

[GitHub] zookeeper pull request #632: [ZOOKEEPER-3150] Add tree digest check and veri...

2018-10-10 Thread eribeiro
Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/632#discussion_r224208545 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java --- @@ -154,6 +160,26 @@ private final

[GitHub] zookeeper pull request #632: [ZOOKEEPER-3150] Add tree digest check and veri...

2018-10-10 Thread eribeiro
Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/632#discussion_r224212868 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/DataNode.java --- @@ -37,6 +37,14 @@ * */ public class DataNode

[GitHub] zookeeper pull request #632: [ZOOKEEPER-3150] Add tree digest check and veri...

2018-10-10 Thread eribeiro
Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/632#discussion_r224210799 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/NodeHashMapImpl.java --- @@ -0,0 +1,116 @@ +/** + * Licensed to the Apache

[GitHub] zookeeper pull request #632: [ZOOKEEPER-3150] Add tree digest check and veri...

2018-10-10 Thread eribeiro
Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/632#discussion_r224209494 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/util/AdHash.java --- @@ -0,0 +1,84 @@ +/** + * Licensed to the Apache

[GitHub] zookeeper pull request #632: [ZOOKEEPER-3150] Add tree digest check and veri...

2018-10-10 Thread eribeiro
Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/632#discussion_r224206681 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java --- @@ -1521,4 +1566,179 @@ public boolean removeWatch(String path,

[GitHub] zookeeper pull request #632: [ZOOKEEPER-3150] Add tree digest check and veri...

2018-10-10 Thread eribeiro
Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/632#discussion_r224213395 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/DataNode.java --- @@ -37,6 +37,14 @@ * */ public class DataNode

[GitHub] zookeeper pull request #632: [ZOOKEEPER-3150] Add tree digest check and veri...

2018-10-08 Thread edwardoliveira
Github user edwardoliveira commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/632#discussion_r223546118 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java --- @@ -1521,4 +1562,179 @@ public boolean removeWatch(String

[GitHub] zookeeper pull request #632: [ZOOKEEPER-3150] Add tree digest check and veri...

2018-10-08 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/632#discussion_r223538616 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java --- @@ -1521,4 +1562,179 @@ public boolean removeWatch(String path,

[GitHub] zookeeper pull request #632: [ZOOKEEPER-3150] Add tree digest check and veri...

2018-10-06 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/632#discussion_r223181405 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java --- @@ -1521,4 +1562,179 @@ public boolean removeWatch(String path,

[GitHub] zookeeper pull request #632: [ZOOKEEPER-3150] Add tree digest check and veri...

2018-10-06 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/632#discussion_r223181364 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java --- @@ -1521,4 +1562,179 @@ public boolean removeWatch(String path,

[GitHub] zookeeper pull request #632: [ZOOKEEPER-3150] Add tree digest check and veri...

2018-10-06 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/632#discussion_r223181383 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java --- @@ -1521,4 +1562,179 @@ public boolean removeWatch(String path,

[GitHub] zookeeper pull request #632: [ZOOKEEPER-3150] Add tree digest check and veri...

2018-09-18 Thread lvfangmin
GitHub user lvfangmin opened a pull request: https://github.com/apache/zookeeper/pull/632 [ZOOKEEPER-3150] Add tree digest check and verify data integrity when loading from disk Jira ZOOKEEPER-3114 will be divided into two parts: 1. data integrity check when loading